From: Wei Liu <wei.liu2@citrix.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
Wei Liu <wei.liu2@citrix.com>, Jan Beulich <jbeulich@suse.com>,
Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] Fix issues introduced in 3a7f872a
Date: Tue, 20 Sep 2016 14:11:22 +0100 [thread overview]
Message-ID: <20160920131122.GU30319@citrix.com> (raw)
In-Reply-To: <22497.10523.568233.698514@mariner.uk.xensource.com>
On Tue, Sep 20, 2016 at 01:18:35PM +0100, Ian Jackson wrote:
> Wei Liu writes ("[PATCH] Fix issues introduced in 3a7f872a"):
> > 3a7f872a ("tools: lift BUILD_BUG_ON to a tools header file") was taken
> > out from an rather old half finished branch by dropping unrelated
> > changes. Unfortunately two issues sneaked in.
> >
> > 1. Hvmloader should be standalone. Revert the changes to hvmloader.
> > 2. The define guard in libs.h was erroneously deleted. Add that back.
>
> Sorry, I didn't realise you were waiting for my ack.
>
> Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
>
Pushed. Thanks everyone.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-09-20 13:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-19 18:13 [PATCH] Fix issues introduced in 3a7f872a Wei Liu
2016-09-20 7:44 ` Jan Beulich
2016-09-20 12:18 ` Ian Jackson
2016-09-20 13:11 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160920131122.GU30319@citrix.com \
--to=wei.liu2@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).