From: Wei Liu <wei.liu2@citrix.com>
To: Charles Arnold <carnold@suse.com>
Cc: Ian Jackson <Ian.Jackson@eu.citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH] tools: fix vif-route add|remove
Date: Tue, 20 Sep 2016 14:57:10 +0100 [thread overview]
Message-ID: <20160920135710.GA18494@citrix.com> (raw)
In-Reply-To: <57CFE35F020000910011119A@prv-mh.provo.novell.com>
On Wed, Sep 07, 2016 at 09:52:31AM -0600, Charles Arnold wrote:
> From 2b4e942ad75f4a4546c417d8bd1116e3af368daf Mon Sep 17 00:00:00 2001
> From: Charles Arnold <carnold@suse.com>
> Date: Wed, 7 Sep 2016 09:48:18 -0600
> Subject: [PATCH] tools: fix vif-route add|remove
>
> vif-route is called twice. First for the vif interface and
> second for the vif-emu interface. vif-route takes 4 parameters,
>
> (add|remove|online|offline)
>
> When called with 'online|offline' then 'ipcmd' is set. When called
> with 'add|remove' then 'ipcmd' is empty ('') and the command,
>
> ${cmdprefix} ip route ${ipcmd} ${addr} dev ${dev} src ${main_ip}
>
> will fail.
>
> Signed-off-by: Charles Arnold <carnold@suse.com>
OK, there is indeed a bug.
But do we need to do anything about add / remove? I suppose the script
works fine for you with this patch applied?
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-09-20 13:57 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-07 15:52 [PATCH] tools: fix vif-route add|remove Charles Arnold
2016-09-20 13:57 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160920135710.GA18494@citrix.com \
--to=wei.liu2@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=carnold@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).