From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Chris Patterson <cjp256@gmail.com>
Cc: Chris Patterson <pattersonc@ainfosec.com>,
Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
simon.rowe@eu.citrix.com, xen-devel@lists.xen.org,
roger.pau@citrix.com
Subject: Re: [RFC PATCH] xs: use system's default stack size for xs_watch's reader thread
Date: Wed, 21 Sep 2016 10:07:10 -0400 [thread overview]
Message-ID: <20160921140710.GC855@char.us.oracle.com> (raw)
In-Reply-To: <CABZSBQcBOhGi4cm-WZPu=yZWtyrZ7220CXJoiQV6op=gzQm=PA@mail.gmail.com>
On Wed, Sep 21, 2016 at 09:50:30AM -0400, Chris Patterson wrote:
> On Wed, Sep 21, 2016 at 9:00 AM, Wei Liu <wei.liu2@citrix.com> wrote:
> > On Wed, Sep 21, 2016 at 08:51:07AM -0400, Konrad Rzeszutek Wilk wrote:
> >> On Tue, Sep 20, 2016 at 05:29:39PM -0400, Chris Patterson wrote:
> >> > From: Chris Patterson <pattersonc@ainfosec.com>
> >> >
> >> > xs_watch() creates a thread to listen to xenstore events. Currently, the
> >> > thread is created with the greater of 16K or PTHREAD_MIN_SIZE.
> >> >
> >> > There have been several bug reports and workarounds related to the issue
> >> > where xs_watch() fails because its attempt to create the reader thread with
> >> > pthread_create() fails. This is due to insufficient stack space size
> >> > given the requirements for thread-local storage usage in the applications
> >> > and libraries that are linked against libxenstore. [1,2,3,4].
> >> >
> >> > Specifying the stack size appears to have been added to reduce memory
> >> > footprint (1d00c73b983b09fbee4d9dc0f58f6663c361c345).
> >>
> >> Ugh. 8MB.
> >
> > OOI isn't that 8MB virtual memory, which means it shouldn't have real
> > impact unless it is used?
/me nods. That is my recollection too. But it does mean that 'top'
shows the application as bigger (by 8MB).
> >
>
> >From what I understand, that is correct. At least in the Linux/glibc
> case, I believe the stack is allocated using anonymous mmap() and that
> resident memory usage shouldn't be greater than what you actually end
> up writing. However, I do not know if this holds true universally...
That should be faily easy to find out. One just needs to check
the RSS size. Not sure how to do that on FreeBSD thought..
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-09-21 14:07 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-20 21:29 [RFC PATCH] xs: use system's default stack size for xs_watch's reader thread Chris Patterson
2016-09-21 12:51 ` Konrad Rzeszutek Wilk
2016-09-21 13:00 ` Wei Liu
2016-09-21 13:50 ` Chris Patterson
2016-09-21 14:07 ` Konrad Rzeszutek Wilk [this message]
2016-09-21 14:23 ` Chris Patterson
2016-09-21 14:39 ` Konrad Rzeszutek Wilk
2016-09-26 16:53 ` Roger Pau Monné
2016-09-27 10:06 ` Wei Liu
2016-09-27 10:56 ` Simon Rowe
2016-09-27 11:01 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160921140710.GC855@char.us.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=cjp256@gmail.com \
--cc=ian.jackson@eu.citrix.com \
--cc=pattersonc@ainfosec.com \
--cc=roger.pau@citrix.com \
--cc=simon.rowe@eu.citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).