From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Ross Lagerwall <ross.lagerwall@citrix.com>,
wei.liu2@citrix.com, xen-devel@lists.xenproject.org
Subject: Re: [PATCH v1 3/3] xen-livepatch: If hypervisor is not compiled with Livepatching
Date: Thu, 22 Sep 2016 06:41:30 -0400 [thread overview]
Message-ID: <20160922104130.GB6990@localhost.localdomain> (raw)
In-Reply-To: <22499.46136.796712.113502@mariner.uk.xensource.com>
On Thu, Sep 22, 2016 at 11:36:40AM +0100, Ian Jackson wrote:
> Ian Jackson writes ("Re: [PATCH v1 3/3] xen-livepatch: If hypervisor is not compiled with Livepatching"):
> > Konrad Rzeszutek Wilk writes ("Re: [PATCH v1 3/3] xen-livepatch: If hypervisor is not compiled with Livepatching"):
> > > Why would fprintf mess up 'errno' ?
> >
> > Any libc function is entitled to set errno, if it fails.
>
> And, I forget the exact rules, but I think most are allowed to trash
> it even if they succeed. I just remember that errno needs to be saved
> across libc calls, if the value is important.
>
> In practice, for example, the first fprintf on a particular FILE* can
> end up setting errno to ENOTTY as the libc calls isatty() to decide on
> the buffering mode.
Aaah! Thanks!
>
> Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-09-22 10:41 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-21 19:20 [PATCH v1] xen-livepatch fixes for Xen 4.8 Konrad Rzeszutek Wilk
2016-09-21 19:20 ` [PATCH v1 1/3] xen-livepatch: Remove the 'test' part Konrad Rzeszutek Wilk
2016-09-22 7:20 ` Ross Lagerwall
2016-09-21 19:20 ` [PATCH v1 2/3] xen-livepatch: Print the header _after_ the first livepatch hypercall Konrad Rzeszutek Wilk
2016-09-22 7:21 ` Ross Lagerwall
2016-09-21 19:20 ` [PATCH v1 3/3] xen-livepatch: If hypervisor is not compiled with Livepatching Konrad Rzeszutek Wilk
2016-09-22 7:25 ` Ross Lagerwall
2016-09-22 10:12 ` Konrad Rzeszutek Wilk
2016-09-22 10:34 ` Ian Jackson
2016-09-22 10:36 ` Ian Jackson
2016-09-22 10:41 ` Konrad Rzeszutek Wilk [this message]
2016-09-22 10:37 ` Ross Lagerwall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160922104130.GB6990@localhost.localdomain \
--to=konrad.wilk@oracle.com \
--cc=ian.jackson@eu.citrix.com \
--cc=ross.lagerwall@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).