From: Wei Liu <wei.liu2@citrix.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
Wei Liu <wei.liu2@citrix.com>
Subject: Re: [OSSTEST PATCH] TestSupport: use qemu-img to create vhd image
Date: Fri, 23 Sep 2016 15:31:50 +0100 [thread overview]
Message-ID: <20160923143150.GS16004@citrix.com> (raw)
In-Reply-To: <22501.14959.49799.153022@mariner.uk.xensource.com>
On Fri, Sep 23, 2016 at 03:21:35PM +0100, Ian Jackson wrote:
> Ian Jackson writes ("Re: [OSSTEST PATCH] TestSupport: use qemu-img to create vhd image"):
> > FAOD, I haven't dropped this. This patch LGTM.
> >
> > Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>
> >
> > I have queued it for a push at some point. Right now there's a d-i
> > update in the pipeline ahead of it.
>
> Well, it did this:
>
> ++ ./make-flight osstest xen-unstable real
> No such class disk_mb_s at Osstest/TestSupport.pm line 1764, near "my disk_mb_s"
> syntax error at Osstest/TestSupport.pm line 1764, near "my disk_mb_s ="
> Global symbol "$disk_mb_s" requires explicit package name at Osstest/TestSupport.pm line 1765.
> BEGIN not safe after errors--compilation aborted at Osstest/TestSupport.pm line 1812.
> Compilation failed in require at Osstest/JobDB/Executive.pm line 24.
> BEGIN failed--compilation aborted at Osstest/JobDB/Executive.pm line 24.
> Compilation failed in require at (eval 18) line 2.
> + flight=
>
> This is because of a missing dollar sign. I will fix it up and retry.
>
Oops... Sorry about that and thanks for fixing that up.
> Ian.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-09-23 14:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-08 15:52 [OSSTEST PATCH] TestSupport: use qemu-img to create vhd image Wei Liu
2016-09-21 10:39 ` Ian Jackson
2016-09-23 14:21 ` Ian Jackson
2016-09-23 14:31 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160923143150.GS16004@citrix.com \
--to=wei.liu2@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).