From mboxrd@z Thu Jan 1 00:00:00 1970 From: Samuel Thibault Subject: Re: [PATCH] pvgrub: use printk() instead of grub_printf() Date: Wed, 28 Sep 2016 12:59:30 +0200 Message-ID: <20160928105930.GE4138@var.bordeaux.inria.fr> References: <1475051518-3452-1-git-send-email-jgross@suse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1475051518-3452-1-git-send-email-jgross@suse.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Juergen Gross Cc: wei.liu2@citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org SnVlcmdlbiBHcm9zcywgb24gV2VkIDI4IFNlcCAyMDE2IDEwOjMxOjU4ICswMjAwLCB3cm90ZToK PiBncnViX3ByaW50ZigpIGlzIHN1cHBvcnRpbmcgb25seSBhIHZlcnkgbGltaXRlZCBudW1iZXIg b2YgZm9ybWF0cy4KPiBFc3BlY2lhbGx5IHNvbWUgZXJyb3IgbWVzc2FnZXMgc3VmZmVyIGZyb20g dGhhdCwgZS5nLiAlbHggd29uJ3Qgd29yay4KPiBTd2l0Y2ggdG8gdXNlIHByaW50aygpIGZvciBl cnJvciBtZXNzYWdlcyBpbnN0ZWFkLgo+IAo+IFNpZ25lZC1vZmYtYnk6IEp1ZXJnZW4gR3Jvc3Mg PGpncm9zc0BzdXNlLmNvbT4KCkFja2VkLWJ5OiBTYW11ZWwgVGhpYmF1bHQgPHNhbXVlbC50aGli YXVsdEBlbnMtbHlvbi5vcmc+Cgo+IC0tLQo+ICBzdHViZG9tL2dydWIva2V4ZWMuYyB8IDIyICsr KysrKysrKysrLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5nZWQsIDExIGluc2VydGlvbnMoKyks IDExIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9zdHViZG9tL2dydWIva2V4ZWMuYyBi L3N0dWJkb20vZ3J1Yi9rZXhlYy5jCj4gaW5kZXggOGZkOWZmOS4uMmVkNGY2YyAxMDA2NDQKPiAt LS0gYS9zdHViZG9tL2dydWIva2V4ZWMuYwo+ICsrKyBiL3N0dWJkb20vZ3J1Yi9rZXhlYy5jCj4g QEAgLTI0NiwyNiArMjQ2LDI2IEBAIHZvaWQga2V4ZWModm9pZCAqa2VybmVsLCBsb25nIGtlcm5l bF9zaXplLCB2b2lkICptb2R1bGUsIGxvbmcgbW9kdWxlX3NpemUsIGNoYXIKPiAgICAgIHRwbV9o YXNoMnBjcihkb20sIGNtZGxpbmUpOwo+ICAKPiAgICAgIGlmICggKHJjID0geGNfZG9tX2Jvb3Rf eGVuX2luaXQoZG9tLCB4Y19oYW5kbGUsIGRvbWlkKSkgIT0gMCApIHsKPiAtICAgICAgICBncnVi X3ByaW50ZigieGNfZG9tX2Jvb3RfeGVuX2luaXQgcmV0dXJuZWQgJWRcbiIsIHJjKTsKPiArICAg ICAgICBwcmludGsoInhjX2RvbV9ib290X3hlbl9pbml0IHJldHVybmVkICVkXG4iLCByYyk7Cj4g ICAgICAgICAgZXJybnVtID0gRVJSX0JPT1RfRkFJTFVSRTsKPiAgICAgICAgICBnb3RvIG91dDsK PiAgICAgIH0KPiAgICAgIGlmICggKHJjID0geGNfZG9tX3BhcnNlX2ltYWdlKGRvbSkpICE9IDAg KSB7Cj4gLSAgICAgICAgZ3J1Yl9wcmludGYoInhjX2RvbV9wYXJzZV9pbWFnZSByZXR1cm5lZCAl ZFxuIiwgcmMpOwo+ICsgICAgICAgIHByaW50aygieGNfZG9tX3BhcnNlX2ltYWdlIHJldHVybmVk ICVkXG4iLCByYyk7Cj4gICAgICAgICAgZXJybnVtID0gRVJSX0JPT1RfRkFJTFVSRTsKPiAgICAg ICAgICBnb3RvIG91dDsKPiAgICAgIH0KPiAgCj4gICNpZmRlZiBfX2kzODZfXwo+ICAgICAgaWYg KHN0cmNtcChkb20tPmd1ZXN0X3R5cGUsICJ4ZW4tMy4wLXg4Nl8zMnAiKSkgewo+IC0gICAgICAg IGdydWJfcHJpbnRmKCJjYW4gb25seSBib290IHg4NiAzMiBQQUUga2VybmVscywgbm90ICVzXG4i LCBkb20tPmd1ZXN0X3R5cGUpOwo+ICsgICAgICAgIHByaW50aygiY2FuIG9ubHkgYm9vdCB4ODYg MzIgUEFFIGtlcm5lbHMsIG5vdCAlc1xuIiwgZG9tLT5ndWVzdF90eXBlKTsKPiAgICAgICAgICBl cnJudW0gPSBFUlJfRVhFQ19GT1JNQVQ7Cj4gICAgICAgICAgZ290byBvdXQ7Cj4gICAgICB9Cj4g ICNlbmRpZgo+ICAjaWZkZWYgX194ODZfNjRfXwo+ICAgICAgaWYgKHN0cmNtcChkb20tPmd1ZXN0 X3R5cGUsICJ4ZW4tMy4wLXg4Nl82NCIpKSB7Cj4gLSAgICAgICAgZ3J1Yl9wcmludGYoImNhbiBv bmx5IGJvb3QgeDg2IDY0IGtlcm5lbHMsIG5vdCAlc1xuIiwgZG9tLT5ndWVzdF90eXBlKTsKPiAr ICAgICAgICBwcmludGsoImNhbiBvbmx5IGJvb3QgeDg2IDY0IGtlcm5lbHMsIG5vdCAlc1xuIiwg ZG9tLT5ndWVzdF90eXBlKTsKPiAgICAgICAgICBlcnJudW0gPSBFUlJfRVhFQ19GT1JNQVQ7Cj4g ICAgICAgICAgZ290byBvdXQ7Cj4gICAgICB9Cj4gQEAgLTI3Myw3ICsyNzMsNyBAQCB2b2lkIGtl eGVjKHZvaWQgKmtlcm5lbCwgbG9uZyBrZXJuZWxfc2l6ZSwgdm9pZCAqbW9kdWxlLCBsb25nIG1v ZHVsZV9zaXplLCBjaGFyCj4gIAo+ICAgICAgLyogZXF1aXZhbGVudCBvZiB4Y19kb21fbWVtX2lu aXQgKi8KPiAgICAgIGlmICh4Y19kb21fc2V0X2FyY2hfaG9va3MoZG9tKSkgewo+IC0gICAgICAg IGdydWJfcHJpbnRmKCJ4Y19kb21fc2V0X2FyY2hfaG9va3MgZmFpbGVkXG4iKTsKPiArICAgICAg ICBwcmludGsoInhjX2RvbV9zZXRfYXJjaF9ob29rcyBmYWlsZWRcbiIpOwo+ICAgICAgICAgIGVy cm51bSA9IEVSUl9FWEVDX0ZPUk1BVDsKPiAgICAgICAgICBnb3RvIG91dDsKPiAgICAgIH0KPiBA QCAtMjkwLDcgKzI5MCw3IEBAIHZvaWQga2V4ZWModm9pZCAqa2VybmVsLCBsb25nIGtlcm5lbF9z aXplLCB2b2lkICptb2R1bGUsIGxvbmcgbW9kdWxlX3NpemUsIGNoYXIKPiAgICAgICAgICBkb20t PnAybV9ob3N0W2ldID0gcGZuX3RvX21mbihpKTsKPiAgCj4gICAgICBpZiAoIChyYyA9IHhjX2Rv bV9idWlsZF9pbWFnZShkb20pKSAhPSAwICkgewo+IC0gICAgICAgIGdydWJfcHJpbnRmKCJ4Y19k b21fYnVpbGRfaW1hZ2UgcmV0dXJuZWQgJWRcbiIsIHJjKTsKPiArICAgICAgICBwcmludGsoInhj X2RvbV9idWlsZF9pbWFnZSByZXR1cm5lZCAlZFxuIiwgcmMpOwo+ICAgICAgICAgIGVycm51bSA9 IEVSUl9CT09UX0ZBSUxVUkU7Cj4gICAgICAgICAgZ290byBvdXQ7Cj4gICAgICB9Cj4gQEAgLTMw Niw3ICszMDYsNyBAQCB2b2lkIGtleGVjKHZvaWQgKmtlcm5lbCwgbG9uZyBrZXJuZWxfc2l6ZSwg dm9pZCAqbW9kdWxlLCBsb25nIG1vZHVsZV9zaXplLCBjaGFyCj4gICAgICBkb20tPnNoYXJlZF9p bmZvX21mbiA9IFBIWVNfUEZOKHN0YXJ0X2luZm8uc2hhcmVkX2luZm8pOwo+ICAKPiAgICAgIGlm ICgheGNfZG9tX2NvbXBhdF9jaGVjayhkb20pKSB7Cj4gLSAgICAgICAgZ3J1Yl9wcmludGYoInhj X2RvbV9jb21wYXRfY2hlY2sgZmFpbGVkXG4iKTsKPiArICAgICAgICBwcmludGsoInhjX2RvbV9j b21wYXRfY2hlY2sgZmFpbGVkXG4iKTsKPiAgICAgICAgICBlcnJudW0gPSBFUlJfRVhFQ19GT1JN QVQ7Cj4gICAgICAgICAgZ290byBvdXQ7Cj4gICAgICB9Cj4gQEAgLTMyNCwxNCArMzI0LDE0IEBA IHZvaWQga2V4ZWModm9pZCAqa2VybmVsLCBsb25nIGtlcm5lbF9zaXplLCB2b2lkICptb2R1bGUs IGxvbmcgbW9kdWxlX3NpemUsIGNoYXIKPiAgICAgIC8qIE1ha2Ugc3VyZSB0aGUgYm9vdHN0cmFw IHBhZ2UgdGFibGUgZG9lcyBub3QgUlctbWFwIGFueSBvZiBvdXIgY3VycmVudAo+ICAgICAgICog cGFnZSB0YWJsZSBmcmFtZXMgKi8KPiAgICAgIGlmICggKHJjID0geGNfZG9tX3VwZGF0ZV9ndWVz dF9wMm0oZG9tKSkpIHsKPiAtICAgICAgICBncnViX3ByaW50ZigieGNfZG9tX3VwZGF0ZV9ndWVz dF9wMm0gcmV0dXJuZWQgJWRcbiIsIHJjKTsKPiArICAgICAgICBwcmludGsoInhjX2RvbV91cGRh dGVfZ3Vlc3RfcDJtIHJldHVybmVkICVkXG4iLCByYyk7Cj4gICAgICAgICAgZXJybnVtID0gRVJS X0JPT1RfRkFJTFVSRTsKPiAgICAgICAgICBnb3RvIG91dDsKPiAgICAgIH0KPiAgCj4gICAgICBp ZiAoIGRvbS0+YXJjaF9ob29rcy0+c2V0dXBfcGd0YWJsZXMgKQo+ICAgICAgICAgIGlmICggKHJj ID0gZG9tLT5hcmNoX2hvb2tzLT5zZXR1cF9wZ3RhYmxlcyhkb20pKSkgewo+IC0gICAgICAgICAg ICBncnViX3ByaW50Zigic2V0dXBfcGd0YWJsZXMgcmV0dXJuZWQgJWRcbiIsIHJjKTsKPiArICAg ICAgICAgICAgcHJpbnRrKCJzZXR1cF9wZ3RhYmxlcyByZXR1cm5lZCAlZFxuIiwgcmMpOwo+ICAg ICAgICAgICAgICBlcnJudW0gPSBFUlJfQk9PVF9GQUlMVVJFOwo+ICAgICAgICAgICAgICBnb3Rv IG91dDsKPiAgICAgICAgICB9Cj4gQEAgLTM2Miw4ICszNjIsOCBAQCB2b2lkIGtleGVjKHZvaWQg Kmtlcm5lbCwgbG9uZyBrZXJuZWxfc2l6ZSwgdm9pZCAqbW9kdWxlLCBsb25nIG1vZHVsZV9zaXpl LCBjaGFyCj4gICNlbmRpZgo+ICAgICAgICAgICAgICAgICAgeGNfZG9tX3AybShkb20sIGRvbS0+ cGd0YWJsZXNfc2VnLnBmbiksCj4gICAgICAgICAgICAgICAgICBkb20tPmd1ZXN0X2RvbWlkKSkg IT0gMCApIHsKPiAtICAgICAgICBncnViX3ByaW50ZigicGluX3RhYmxlKCVseCkgcmV0dXJuZWQg JWRcbiIsIHhjX2RvbV9wMm0oZG9tLAo+IC0gICAgICAgICAgICAgICAgICAgIGRvbS0+cGd0YWJs ZXNfc2VnLnBmbiksIHJjKTsKPiArICAgICAgICBwcmludGsoInBpbl90YWJsZSglbHgpIHJldHVy bmVkICVkXG4iLCB4Y19kb21fcDJtKGRvbSwKPiArICAgICAgICAgICAgICAgZG9tLT5wZ3RhYmxl c19zZWcucGZuKSwgcmMpOwo+ICAgICAgICAgIGVycm51bSA9IEVSUl9CT09UX0ZBSUxVUkU7Cj4g ICAgICAgICAgZ290byBvdXRfcmVtYXA7Cj4gICAgICB9Cj4gLS0gCj4gMi42LjYKPiAKCi0tIApT YW11ZWwKQ2xpZW50OiAiVGhpcyBwcm9ncmFtIGhhcyBiZWVuIHN1Y2Nlc3NmdWxseSBpbnN0YWxs ZWQuIgpWZW5kZXVyIChzdXJwcmlzKTogIkV0IG/DuSB2b3llei12b3VzIHVuZSBlcnJldXIgPyIK Q2xpZW50OiAiQydlc3QgPDwgSEFTIEJFRU4gPj4gISIKCl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fClhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKWGVuLWRldmVs QGxpc3RzLnhlbi5vcmcKaHR0cHM6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAo=