From: Wei Liu <wei.liu2@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
IanJackson <Ian.Jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
Julien Grall <julien.grall@arm.com>,
Shannon Zhao <zhaoshenglong@huawei.com>,
xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] pub-headers: reduce C99 dependencies
Date: Wed, 28 Sep 2016 15:17:13 +0100 [thread overview]
Message-ID: <20160928141713.GL16004@citrix.com> (raw)
In-Reply-To: <57EBEC7B02000078001135FA@prv-mh.provo.novell.com>
On Wed, Sep 28, 2016 at 08:14:51AM -0600, Jan Beulich wrote:
> >>> On 28.09.16 at 16:04, <wei.liu2@citrix.com> wrote:
> > On Wed, Sep 28, 2016 at 06:00:31AM -0600, Jan Beulich wrote:
> >> For consumers not using (fully) C99-aware compilers, limit the number
> >> of places where tweaking of the headers would be necessary: Introduce
> >> and use xen_mk_ullong(), allowing its helper macro to be overridden at
> >> once.
> >>
> >> For now don't touch public/io/, which also has a few offenders.
> >>
> >> The need to include xen.h in hvm/e820.h demonstrates that it is a bad
> >> idea to include public headers first thing - arch/x86/hvm/mtrr.c needs
> >> adjustment just because of this.
> >>
> >> Signed-off-by: Jan Beulich <jbeulich@suse.com>
> >> ---
> >> I wonder why all those ARM constants carry the ULL suffix despite only
> >> two of them actually exceeding 32 significant bits.
> >>
> >> --- a/xen/arch/x86/hvm/mtrr.c
> >> +++ b/xen/arch/x86/hvm/mtrr.c
> >> @@ -16,7 +16,6 @@
> >> * this program; If not, see <http://www.gnu.org/licenses/>.
> >> */
> >>
> >> -#include <public/hvm/e820.h>
> >> #include <xen/domain_page.h>
> >> #include <asm/e820.h>
> >> #include <asm/iocap.h>
> >> @@ -25,6 +24,7 @@
> >> #include <asm/mtrr.h>
> >> #include <asm/hvm/support.h>
> >> #include <asm/hvm/cacheattr.h>
> >> +#include <public/hvm/e820.h>
> >>
> >
> > Unrelated change here.
>
> Definitely not - see the commit message.
>
Ah, sorry about the noise.
> Jan
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-09-28 14:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-28 12:00 [PATCH] pub-headers: reduce C99 dependencies Jan Beulich
2016-09-28 13:31 ` George Dunlap
2016-09-28 13:49 ` Jan Beulich
2016-09-28 14:04 ` Wei Liu
2016-09-28 14:14 ` Jan Beulich
2016-09-28 14:17 ` Wei Liu [this message]
2016-09-28 19:42 ` Julien Grall
2016-09-29 6:04 ` Jan Beulich
2016-09-29 19:11 ` Julien Grall
2016-09-29 19:22 ` Julien Grall
2016-09-29 19:33 ` Wei Liu
2016-09-30 9:05 ` Jan Beulich
2016-09-30 9:14 ` Wei Liu
2016-09-29 9:41 ` Ian Jackson
2016-09-29 19:15 ` Julien Grall
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160928141713.GL16004@citrix.com \
--to=wei.liu2@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=julien.grall@arm.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
--cc=zhaoshenglong@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).