From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [Resend PATCH 1/2] Xen/Keyhandler: Make keyhandler always run in tasklet Date: Fri, 30 Sep 2016 14:07:07 -0400 Message-ID: <20160930180707.GC23341@char.us.oracle.com> References: <1475201946-31898-1-git-send-email-tianyu.lan@intel.com> <1475201946-31898-2-git-send-email-tianyu.lan@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1475201946-31898-2-git-send-email-tianyu.lan@intel.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Lan Tianyu Cc: sstabellini@kernel.org, wei.liu2@citrix.com, George.Dunlap@eu.citrix.com, andrew.cooper3@citrix.com, ian.jackson@eu.citrix.com, xen-devel@lists.xen.org, jbeulich@suse.com, xen-devel@lists.xenproject.org List-Id: xen-devel@lists.xenproject.org T24gRnJpLCBTZXAgMzAsIDIwMTYgYXQgMTA6MTk6MDVBTSArMDgwMCwgTGFuIFRpYW55dSB3cm90 ZToKPiBLZXloYW5kbGVyIG1heSBydW4gZm9yIGEgbG9uZyB0aW1lIGluIGEgdGltZXIgaGFuZGxl ciBvbiB0aGUgbGFyZ2UgbWFjaGluZQoKSSBhbSBiaXQgbG9zdC4KCllvdSBzYXkgJ3RpbWVyIGhh bmRsZXInIHdoaWNoIHdpbGwgaW1wbHkgdGhhdCB0aGVyZSBpcyBzb21lIGZvcm0Kb2YgJ2luaXRf dGltZXInIGFuZCAnc2V0X3RpbWVyJyB0aGF0IHdvdWxkIGNhbGwgdGhlIGhhbmRsZV9rZXlwcmVz cwpmdW5jdGlvbj8KQnV0IEkgYW0gbm90IHNlZWluZyBpdD8KCk9yIGFyZSB5b3Ugc2F5aW5nIHRo YXQgd2hlbiAnZHVtcF90aW1lcnEnIGlzIGludm9rZWQ/CklmIHNvIHBsZWFzZSBzYXkgdGhhdC4K Cj4gd2l0aCBhIGxvdCBvZiBwaHlzaWNhbCBjcHVzKEUsRyBrZXloYW5kbGVyIGZvciBkdW1waW5n IHRpbWVyIGluZm8pIHdoZW4gc2VyaWFsCgpzL0UsRy9lLmcuZy8KCj4gcG9ydCBkcml2ZXIgd29y a3MgaW4gdGhlIHBvbGwgbW9kZS4gV2hlbiB0aW1lciBpbnRlcnJ1cHQgYXJyaXZlcywgdGltZXIg c3Vic3lzdGVtCgpzL3BvbGwgbW9kZS9wb2xsIG1vZGUgKHZpYSB0aGUgZXhjZXB0aW9uIG1lY2hh bmlzbSkvCgo+IHJ1bnMgYWxsIHRpbWVyIGhhbmRsZXJzIGJlZm9yZSBwcm9ncmFtbWluZyBuZXh0 IHRpbWVyIGludGVycnVwdC4gU28gaWYgdGltZXIgaGFuZGxlcgo+IHJ1bnMgbG9uZ2VyIHRoYW4g dGltZSBmb3Igd2F0Y2hkb2cgdGltZW91dCwgdGhlIHRpbWVyIGhhbmRsZXIgb2Ygd2F0Y2hkb2cg d2lsbCBiZQoKQWgsIHNvIHRoaXMgaXMgaWYgYSBndWVzdCBoYXMgc2V0IGEgdGltZXIgYW5kIHdl IGFyZSBleGVjdXRpbmcgaXQuIE9yIHdlIGhhdmUKbWFueSBvZiB0aGVtIHRvIGdvIHRocm91Z2gu Cgo+IGJsb2NrZWQgdG8gZmVlZCB3YXRjaGRvZyBhbmQgeGVuIGh5cGVydmlzb3IgcGFuaWNzLiBU aGlzIHBhdGNoIGlzIHRvIGZpeCB0aGUgaXNzdWUKPiB2aWEgYWx3YXlzIHNjaGVkdWxpbmcgYSB0 YXNrbGV0IHRvIHJ1biBrZXloYW5kbGVyIHRvIGF2b2lkIHRpbWVyIGhhbmRsZXIgcnVubmluZwo+ IHRvbyBsb25nLgoKWW91IHNheSAidGltZXIgaGFuZGxlciIgYWdhaW4uIEJ1dCB0aGUgdGltZXIg aGFuZGxlcnMgYXJlIGV4ZWN1dGVkIHZpYQp0aW1lcl9zb2Z0aXJxX2FjdGlvbiAod2hpY2ggaXMg YSBzb2Z0aXJxLCBha2EgdHJpZ2dlcmVkIGJ5IElQSSkuCgpBbmQgdGhlIHRhc2tsZXQgd2lsbCBt ZWFuIHRoYXQgdGhhdCBpdCBnZXRzIHRvIGJlIGV4ZWN1dGVkIF9hZnRlcl8gdGhlCmRvX3NvZnRp cnEgaXMgZG9uZSAoYXMgc29mdGlycS5oIHB1dHMgdGhlIGxvdyBudW1iZXJlZCBvbmVzIGZpcnN0 LCBzdWNoCmFzIHRoZSBUSU1FUl9TT0ZUSVJRKT8KClNvIHdoYXQgSSB0aGluayB5b3UgYXJlIHNh eWluZyBpcyB0aGF0IHlvdSBkbyBub3Qgd2FudCB0aGUgJ3RpbWVyX3NvZnRpcnFfYWN0aW9uJwp0 byBiZSBwcmVlbXB0ZWQgYnkgdGhlICdkdW1wX3RpbWVycScgKG9yIGFueSBvdGhlciBvbmVzKSB3 aGljaCB3aWxsCnRyaXAgdGhlIHdhdGNoZG9nIHRpbWVvdXQuIAoKSWYgdGhhdCBpcyB0aGUgY2Fz ZSBwbGVhc2UgcHV0IHNvbWV0aGluZyB0byB0aGF0IGFmZmVjdCBpbiB0aGUKY29tbWl0IGRlc2Ny aXB0aW9uLgoKVGhhdCBiZWdzIG9uZSBxdWVzdGlvbiB0aGF0IHNob3VsZCBiZSBwcm9iYWJseSBh bnN3ZXJlZCBpbiB0aGUgY29tbWl0CmRlc2NyaXB0aW9uOgoKV2h5IGNhbid0IHRoZSBkdW1wX3Rp bWVycSBvciBhbnkgb3RoZXIga2V5aGFuZGxlciBwb2tlIHRoZSB3YXRjaGRvZwooZXhwb3NlIG5t aV90aW1lcl9mbiBhbmQgY2FsbCB0aGF0PykKCj4gCj4gU2lnbmVkLW9mZi1ieTogTGFuIFRpYW55 dSA8dGlhbnl1LmxhbkBpbnRlbC5jb20+CgpPdGhlcndpc2UgdGhlIG1lY2hhbmljYWwgcGFydHMg b2YgdGhlIHBhdGNoIGxvb2sgZ29vZC4KCj4gLS0tCj4gIHhlbi9jb21tb24va2V5aGFuZGxlci5j IHwgICAgOCArKysrKy0tLQo+ICAxIGZpbGVzIGNoYW5nZWQsIDUgaW5zZXJ0aW9ucygrKSwgMyBk ZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEveGVuL2NvbW1vbi9rZXloYW5kbGVyLmMgYi94 ZW4vY29tbW9uL2tleWhhbmRsZXIuYwo+IGluZGV4IDE2ZGU2ZTguLmZjZTUyZDIgMTAwNjQ0Cj4g LS0tIGEveGVuL2NvbW1vbi9rZXloYW5kbGVyLmMKPiArKysgYi94ZW4vY29tbW9uL2tleWhhbmRs ZXIuYwo+IEBAIC03NSw3ICs3NSw5IEBAIHN0YXRpYyBzdHJ1Y3Qga2V5aGFuZGxlciB7Cj4gIAo+ ICBzdGF0aWMgdm9pZCBrZXlwcmVzc19hY3Rpb24odW5zaWduZWQgbG9uZyB1bnVzZWQpCj4gIHsK PiAtICAgIGhhbmRsZV9rZXlwcmVzcyhrZXlwcmVzc19rZXksIE5VTEwpOwo+ICsgICAgY29uc29s ZV9zdGFydF9sb2dfZXZlcnl0aGluZygpOwo+ICsgICAga2V5X3RhYmxlW2tleXByZXNzX2tleV0u Zm4oa2V5cHJlc3Nfa2V5KTsKPiArICAgIGNvbnNvbGVfZW5kX2xvZ19ldmVyeXRoaW5nKCk7Cj4g IH0KPiAgCj4gIHN0YXRpYyBERUNMQVJFX1RBU0tMRVQoa2V5cHJlc3NfdGFza2xldCwga2V5cHJl c3NfYWN0aW9uLCAwKTsKPiBAQCAtODcsMTAgKzg5LDEwIEBAIHZvaWQgaGFuZGxlX2tleXByZXNz KHVuc2lnbmVkIGNoYXIga2V5LCBzdHJ1Y3QgY3B1X3VzZXJfcmVncyAqcmVncykKPiAgICAgIGlm ICgga2V5ID49IEFSUkFZX1NJWkUoa2V5X3RhYmxlKSB8fCAhKGggPSAma2V5X3RhYmxlW2tleV0p LT5mbiApCj4gICAgICAgICAgcmV0dXJuOwo+ICAKPiAtICAgIGlmICggIWluX2lycSgpIHx8IGgt PmlycV9jYWxsYmFjayApCj4gKyAgICBpZiAoIGgtPmlycV9jYWxsYmFjayApCj4gICAgICB7Cj4g ICAgICAgICAgY29uc29sZV9zdGFydF9sb2dfZXZlcnl0aGluZygpOwo+IC0gICAgICAgIGgtPmly cV9jYWxsYmFjayA/IGgtPmlycV9mbihrZXksIHJlZ3MpIDogaC0+Zm4oa2V5KTsKPiArICAgICAg ICBoLT5pcnFfZm4oa2V5LCByZWdzKTsKPiAgICAgICAgICBjb25zb2xlX2VuZF9sb2dfZXZlcnl0 aGluZygpOwo+ICAgICAgfQo+ICAgICAgZWxzZQo+IC0tIAo+IDEuNy4xCj4gCgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpYZW4tZGV2ZWwgbWFpbGluZyBs aXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHBzOi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2 ZWwK