From: Martin Kletzander <mkletzan@redhat.com>
To: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: libvir-list@redhat.com, xen-devel@lists.xenproject.org,
Jim Fehlig <jfehlig@suse.com>,
Julien Grall <julien.grall@arm.com>
Subject: Re: [OSSTEST PATCH 2/2] libvirt: Do not attempt save/restore when migration not advertised
Date: Thu, 6 Oct 2016 12:42:55 +0200 [thread overview]
Message-ID: <20161006104255.GP16414@wheatley> (raw)
In-Reply-To: <22518.8298.846651.893440@mariner.uk.xensource.com>
[-- Attachment #1.1: Type: text/plain, Size: 1590 bytes --]
On Thu, Oct 06, 2016 at 10:59:06AM +0100, Ian Jackson wrote:
>Martin Kletzander writes ("Re: [OSSTEST PATCH 2/2] libvirt: Do not attempt save/restore when migration not advertised"):
>> Since offline migration (as in migrating a domain between hosts without
>> being running) is not that used in the code and talked about, I'm
>> guessing offline means save restore. Looking at the history it was
>> added before the "offline" migration, so it probably means
>> save/restore. To avoid confusion, I would suggest we add either
>> <offline/> or rather <save/> (the naming is not important) and document
>> what it means. And then you can use it exactly how you'd like. And
>> you'll be also sure it means what you need it to mean ;) The patches
>> will be straigh-forward, let me know if I can help anyhow.
>
>Except that the point of the exercise is to detect which features are
>supported in which versions. Whatever I do in osstest needs to work
>with older libvirt versions, which do not report
> /capabilities/host/migration_features/save
>even on x86, where it is supported. I suppose I could detect
> /capabilities/host/migration_features/live
>and assume that save/restore was supported (since it's unlikely that
>live migration would be supported but not save/restore).
>
>So for now I think I need to use
> /capabilities/host/migration_features
>as a proxy for save/restore ?
>
Well then, unfortunately you do.
Also, looking at how the code is structured, if you have live migration
but don't have save/restore, you won't have <migration_features/> there
at all.
>Ian.
[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]
[-- Attachment #2: Type: text/plain, Size: 127 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-10-06 10:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-04 17:02 [OSSTEST PATCH 0/2] libvirt: Fix save/restore capability check on ARM Ian Jackson
2016-10-04 17:02 ` [OSSTEST PATCH 1/2] libvirt: Check migration capabilities using proper XML parser Ian Jackson
2016-10-04 17:05 ` Ian Jackson
2016-10-05 18:36 ` Julien Grall
2016-10-06 10:00 ` Ian Jackson
2016-10-11 13:42 ` Julien Grall
2016-10-11 13:50 ` Ian Jackson
2016-10-05 23:50 ` Jim Fehlig
2016-10-04 17:02 ` [OSSTEST PATCH 2/2] libvirt: Do not attempt save/restore when migration not advertised Ian Jackson
2016-10-05 6:46 ` [libvirt] " Martin Kletzander
2016-10-06 0:06 ` Jim Fehlig
2016-10-06 9:43 ` Martin Kletzander
2016-10-06 9:59 ` Ian Jackson
2016-10-06 10:42 ` Martin Kletzander [this message]
2016-10-06 16:44 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161006104255.GP16414@wheatley \
--to=mkletzan@redhat.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jfehlig@suse.com \
--cc=julien.grall@arm.com \
--cc=libvir-list@redhat.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).