From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Kletzander Subject: Re: [OSSTEST PATCH 2/2] libvirt: Do not attempt save/restore when migration not advertised Date: Thu, 6 Oct 2016 12:42:55 +0200 Message-ID: <20161006104255.GP16414@wheatley> References: <1475600547-1009-1-git-send-email-ian.jackson@eu.citrix.com> <1475600547-1009-3-git-send-email-ian.jackson@eu.citrix.com> <20161006094307.GN16414@wheatley> <22518.8298.846651.893440@mariner.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============5786633861305991637==" Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bs68j-00016W-TU for xen-devel@lists.xenproject.org; Thu, 06 Oct 2016 10:43:02 +0000 In-Reply-To: <22518.8298.846651.893440@mariner.uk.xensource.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Ian Jackson Cc: libvir-list@redhat.com, xen-devel@lists.xenproject.org, Jim Fehlig , Julien Grall List-Id: xen-devel@lists.xenproject.org --===============5786633861305991637== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="CUrluEZVXmx7ezWQ" Content-Disposition: inline --CUrluEZVXmx7ezWQ Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline On Thu, Oct 06, 2016 at 10:59:06AM +0100, Ian Jackson wrote: >Martin Kletzander writes ("Re: [OSSTEST PATCH 2/2] libvirt: Do not attempt save/restore when migration not advertised"): >> Since offline migration (as in migrating a domain between hosts without >> being running) is not that used in the code and talked about, I'm >> guessing offline means save restore. Looking at the history it was >> added before the "offline" migration, so it probably means >> save/restore. To avoid confusion, I would suggest we add either >> or rather (the naming is not important) and document >> what it means. And then you can use it exactly how you'd like. And >> you'll be also sure it means what you need it to mean ;) The patches >> will be straigh-forward, let me know if I can help anyhow. > >Except that the point of the exercise is to detect which features are >supported in which versions. Whatever I do in osstest needs to work >with older libvirt versions, which do not report > /capabilities/host/migration_features/save >even on x86, where it is supported. I suppose I could detect > /capabilities/host/migration_features/live >and assume that save/restore was supported (since it's unlikely that >live migration would be supported but not save/restore). > >So for now I think I need to use > /capabilities/host/migration_features >as a proxy for save/restore ? > Well then, unfortunately you do. Also, looking at how the code is structured, if you have live migration but don't have save/restore, you won't have there at all. >Ian. --CUrluEZVXmx7ezWQ Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- iQIcBAEBCAAGBQJX9iqvAAoJEAgfwp8kF4bd9/IP/2Nzh9jb0d51DzWki76mwg8Q S5iYYgRZJTCCEUoX/vOFjsTTrs7RQR73+Fehmdh6VMUELsi/l7/OrEfOa4S6Wk2q BYd+hAIDL1sM4x9ViQUD3SYywTfyBkLNQU1Wccgvxla5UsBRGnNeAtJG/lOOdDYt BwsGzMApnc13J6qRslpcT0k/bqOLHuzMJ/Mnx5LasUvEZwBX45urO/pzXNLtx5cA pplIpdBg0oJ3/8wQlJGI8NlIkXpQecsqMrFqtLxl1rf8PZiLxO1xqVM2Y3Mburm0 XOltlMyKUTbjZ1QjdDGA2G/3/pZvjvGrF5FYk2/V/hfvjZ/tJxY0ED+782l28ZJu s8qOW8SjaoUWC5DxlGrYCCGjp+Ckas3bKWCK+f4EoR3avtHYorYy4FdlDzU95dCz Q+lKIw9apky245xztBRfbeNVRC28f6ggnPxHm0p2LafRbAOWV/4lBtTvHy83TJ5G d0c53lvou+M/kHD9a6LHNpk/teTz8QLWLZ1dLPt/lO4dTGgrZ7WYCgyGDpEEUXiv 6S/1MBU8ldKv/cmmbkn2V81ZVlBtc/csE2pc4KahQkZ3VBZ82227BJwR1djiQ+ia l6a2AHqaQ8MLcjbNcx/aLXogL7nal2bKqEjBnHG6L+IVCa/NRX0No01W4PglU2Sm KtisAaI3ZY0k/IuSEhWh =0ypd -----END PGP SIGNATURE----- --CUrluEZVXmx7ezWQ-- --===============5786633861305991637== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============5786633861305991637==--