From: Wei Liu <wei.liu2@citrix.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Xen-devel <xen-devel@lists.xenproject.org>,
philippe.gabriel@citrix.com, Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>
Subject: Re: [RFC PATCH 5/8] gcov: userspace tools to extract and split gcov data
Date: Fri, 7 Oct 2016 11:49:30 +0100 [thread overview]
Message-ID: <20161007104930.GE3687@citrix.com> (raw)
In-Reply-To: <229e9464-f127-a7d7-5cf0-9d315c7a3132@citrix.com>
On Fri, Oct 07, 2016 at 11:47:13AM +0100, Andrew Cooper wrote:
> On 06/10/16 15:37, Wei Liu wrote:
> > Provide two tools: a small C program to extract data from hypervisor and
> > a python script to split data into multiple files.
> >
> > The file xencov.c is salvaged and modified from the original xencov.c.
> >
> > Signed-off-by: Wei Liu <wei.liu2@citrix.com>
> > ---
> > Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> > ---
> > tools/misc/Makefile | 6 ++
> > tools/misc/xencov.c | 148 ++++++++++++++++++++++++++++++++++++++++++++++++
> > tools/misc/xencov_split | 100 ++++++++++++++++++++++++++++++++
> > 3 files changed, 254 insertions(+)
> > create mode 100644 tools/misc/xencov.c
> > create mode 100755 tools/misc/xencov_split
> >
> > diff --git a/tools/misc/Makefile b/tools/misc/Makefile
> > index 5ba6672..c029401 100644
> > --- a/tools/misc/Makefile
> > +++ b/tools/misc/Makefile
> > @@ -13,6 +13,7 @@ CFLAGS += $(CFLAGS_libxenstore)
> > INSTALL_BIN-$(CONFIG_X86) += xen-cpuid
> > INSTALL_BIN-$(CONFIG_X86) += xen-detect
> > INSTALL_BIN += xencons
> > +INSTALL-BIN += xencov_split
>
> You have typo'd INSTALL_BIN here, causing xencov_split not to be
> installed. (Luckily, RPM catches this, but I have spent a while staring
> in disbelief, trying to work out what was wrong.)
>
I stared at the two lines for 30s and finally figured out that went
wrong.
Sorry about this! I will fix that in v2.
Wei.
> ~Andrew
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-10-07 10:49 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-06 14:37 [RFC PATCH 0/8] Rework gcov support in Xen Wei Liu
2016-10-06 14:37 ` [RFC PATCH 1/8] Kconfig: add BROKEN config Wei Liu
2016-10-07 9:48 ` Jan Beulich
2016-10-06 14:37 ` [RFC PATCH 2/8] xen: delete gcno files in clean target Wei Liu
2016-10-06 14:55 ` Andrew Cooper
2016-10-06 15:00 ` Wei Liu
2016-10-06 14:37 ` [RFC PATCH 3/8] xen, tools: rip out old gcov implementation Wei Liu
2016-10-06 14:37 ` [RFC PATCH 4/8] gcov: add new interface and 3.4 and 4.7 format support Wei Liu
2016-10-07 11:06 ` Jan Beulich
2016-10-07 11:10 ` Wei Liu
2016-10-07 11:43 ` Wei Liu
2016-10-07 11:52 ` Jan Beulich
2016-10-07 11:54 ` Wei Liu
2016-10-06 14:37 ` [RFC PATCH 5/8] gcov: userspace tools to extract and split gcov data Wei Liu
2016-10-07 10:47 ` Andrew Cooper
2016-10-07 10:49 ` Wei Liu [this message]
2016-10-06 14:37 ` [RFC PATCH 6/8] Config.mk: expand cc-ver a bit Wei Liu
2016-10-07 9:52 ` Jan Beulich
2016-10-07 10:13 ` Wei Liu
2016-10-06 14:37 ` [RFC PATCH 7/8] Config.mk: introduce cc-ifversion Wei Liu
2016-10-06 14:37 ` [RFC PATCH 8/8] gcov: provide the capability to select gcov format automatically Wei Liu
2016-10-07 9:55 ` Jan Beulich
2016-10-07 11:06 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161007104930.GE3687@citrix.com \
--to=wei.liu2@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=philippe.gabriel@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).