From: Wei Liu <wei.liu2@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
AndrewCooper <andrew.cooper3@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>, Tim Deegan <tim@xen.org>,
philippe.gabriel@citrix.com,
Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [RFC PATCH 8/8] gcov: provide the capability to select gcov format automatically
Date: Fri, 7 Oct 2016 12:06:50 +0100 [thread overview]
Message-ID: <20161007110650.GG3687@citrix.com> (raw)
In-Reply-To: <57F78D430200007800115962@prv-mh.provo.novell.com>
On Fri, Oct 07, 2016 at 03:55:47AM -0600, Jan Beulich wrote:
> >>> On 06.10.16 at 16:37, <wei.liu2@citrix.com> wrote:
> > +config GCOV_FORMAT_AUTODETECT
> > + bool "Autodetect"
> > + ---help---
> > + Automatically select gcov format based on GCC version.
>
> Tab indentation again please, and I think help text usually gets
> indented by another one or two spaces from the "help" or "---help---"
> keyword's.
>
I will fix the issues you point out in this patch and previous ones.
Thanks for reviewing.
Wei.
> Jan
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-10-07 11:06 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-06 14:37 [RFC PATCH 0/8] Rework gcov support in Xen Wei Liu
2016-10-06 14:37 ` [RFC PATCH 1/8] Kconfig: add BROKEN config Wei Liu
2016-10-07 9:48 ` Jan Beulich
2016-10-06 14:37 ` [RFC PATCH 2/8] xen: delete gcno files in clean target Wei Liu
2016-10-06 14:55 ` Andrew Cooper
2016-10-06 15:00 ` Wei Liu
2016-10-06 14:37 ` [RFC PATCH 3/8] xen, tools: rip out old gcov implementation Wei Liu
2016-10-06 14:37 ` [RFC PATCH 4/8] gcov: add new interface and 3.4 and 4.7 format support Wei Liu
2016-10-07 11:06 ` Jan Beulich
2016-10-07 11:10 ` Wei Liu
2016-10-07 11:43 ` Wei Liu
2016-10-07 11:52 ` Jan Beulich
2016-10-07 11:54 ` Wei Liu
2016-10-06 14:37 ` [RFC PATCH 5/8] gcov: userspace tools to extract and split gcov data Wei Liu
2016-10-07 10:47 ` Andrew Cooper
2016-10-07 10:49 ` Wei Liu
2016-10-06 14:37 ` [RFC PATCH 6/8] Config.mk: expand cc-ver a bit Wei Liu
2016-10-07 9:52 ` Jan Beulich
2016-10-07 10:13 ` Wei Liu
2016-10-06 14:37 ` [RFC PATCH 7/8] Config.mk: introduce cc-ifversion Wei Liu
2016-10-06 14:37 ` [RFC PATCH 8/8] gcov: provide the capability to select gcov format automatically Wei Liu
2016-10-07 9:55 ` Jan Beulich
2016-10-07 11:06 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161007110650.GG3687@citrix.com \
--to=wei.liu2@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=philippe.gabriel@citrix.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).