xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: "Lai, Paul" <paul.c.lai@intel.com>
To: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Cc: ravi.sahita@intel.com, xen-devel@lists.xensource.com,
	george.dunlap@citrix.com, jbeulich@suse.com
Subject: Re: [PATCH Altp2m cleanup 2/3 v9 1/2] Move altp2m specific functions to altp2m files.
Date: Tue, 11 Oct 2016 12:26:21 -0700	[thread overview]
Message-ID: <20161011192621.GA5042@intel.com> (raw)
In-Reply-To: <20161011192049.GE23193@localhost.localdomain>

On Tue, Oct 11, 2016 at 03:20:49PM -0400, Konrad Rzeszutek Wilk wrote:
> On Tue, Oct 11, 2016 at 10:41:24AM -0700, Paul Lai wrote:
[snip]
> > +
> > +    for ( i = 0; i < MAX_ALTP2M; i++ )
> > +    {
> > +        rc = p2m_alloc_table(d->arch.altp2m_p2m[i]);
> > +        if ( rc != 0 ) {
> 
> { should be on its own line.
> 
> And you can also do:
> 	if ( rc )
> 	{
> 		...

Thanks... I caught 2-3 like this before sending this out, but... 
Will respin.

-Paul

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2016-10-11 19:26 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-11 17:41 [PATCH Altp2m cleanup 2/3 v9 0/2] Cleaning up altp2m code Paul Lai
2016-10-11 17:41 ` [PATCH Altp2m cleanup 2/3 v9 1/2] Move altp2m specific functions to altp2m files Paul Lai
2016-10-11 19:20   ` Konrad Rzeszutek Wilk
2016-10-11 19:26     ` Lai, Paul [this message]
2016-10-11 17:41 ` [PATCH Altp2m cleanup 2/3 v9 2/2] Moving ept code to ept specific files as requested in: https://lists.xenproject.org/archives/html/xen-devel/2015-07/msg04323.html Renamed p2m_init_altp2m_helper() to p2m_init_altp2m_ept() Paul Lai
2016-10-11 19:22   ` Konrad Rzeszutek Wilk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161011192621.GA5042@intel.com \
    --to=paul.c.lai@intel.com \
    --cc=george.dunlap@citrix.com \
    --cc=jbeulich@suse.com \
    --cc=konrad.wilk@oracle.com \
    --cc=ravi.sahita@intel.com \
    --cc=xen-devel@lists.xensource.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).