From: Wei Liu <wei.liu2@citrix.com>
To: Dario Faggioli <dario.faggioli@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
Dagaen Golomb <dgolomb@cis.upenn.edu>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Haoran Li <lihaoran@wustl.edu>,
Linh Thi Xuan Phan <linhphan@cis.upenn.edu>,
Meng Xu <xumengpanda@gmail.com>, Meng Xu <mengxu@cis.upenn.edu>,
xen-devel@lists.xenproject.org,
Tianyang Chen <tiche@cis.upenn.edu>
Subject: Re: [PATCH] xen:rtds:Clear __RTDS_depleted bit once replenish vcpu
Date: Wed, 26 Oct 2016 13:41:15 +0100 [thread overview]
Message-ID: <20161026124115.GN30231@citrix.com> (raw)
In-Reply-To: <1477387251.27407.53.camel@citrix.com>
On Tue, Oct 25, 2016 at 11:20:51AM +0200, Dario Faggioli wrote:
> On Fri, 2016-10-21 at 22:12 -0400, Meng Xu wrote:
> > We should clear the __RTDS_depleted bit once a VCPU budget is
> > replenished.
> > Because repl_timer_handler may be called after rt_schedule
> > but before rt_context_saved, the VCPU may be not on CPU or on queue
> > when the VCPU is the middle of context switch
> >
> Yes, this makes sense, and is a good fix.
>
> I actually would prefer the subject to become (something like):
>
> "xen: rtds: always clear the flag when replenishing a depleted vcpu"
>
> whith that changed:
>
> > Signed-off-by: Meng Xu <mengxu@cis.upenn.edu>
> >
> Acked-by: Dario Faggioli <dario.faggioli@citrix.com>
>
Fixed the subject line and applied for 4.8.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-10-26 12:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-22 2:12 [PATCH] xen:rtds:Clear __RTDS_depleted bit once replenish vcpu Meng Xu
2016-10-25 9:20 ` Dario Faggioli
2016-10-25 13:27 ` Meng Xu
2016-10-26 12:41 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161026124115.GN30231@citrix.com \
--to=wei.liu2@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=dario.faggioli@citrix.com \
--cc=dgolomb@cis.upenn.edu \
--cc=lihaoran@wustl.edu \
--cc=linhphan@cis.upenn.edu \
--cc=mengxu@cis.upenn.edu \
--cc=tiche@cis.upenn.edu \
--cc=xen-devel@lists.xenproject.org \
--cc=xumengpanda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).