* [PATCH v1] Documentation and various fixes to osstest.
@ 2016-10-18 14:56 Konrad Rzeszutek Wilk
2016-10-18 14:56 ` [PATCH 1/2] README: Also mention other requirements Konrad Rzeszutek Wilk
2016-10-18 14:56 ` [PATCH 2/2] s/HttpProxy/DebianMirrorProxy/ Konrad Rzeszutek Wilk
0 siblings, 2 replies; 6+ messages in thread
From: Konrad Rzeszutek Wilk @ 2016-10-18 14:56 UTC (permalink / raw)
To: ian.jackson, xen-devel; +Cc: Marcos.Matsunaga
Hey,
Two little fixes, nothing major - but things I spotted as I was
setting up osstest.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 1/2] README: Also mention other requirements.
2016-10-18 14:56 [PATCH v1] Documentation and various fixes to osstest Konrad Rzeszutek Wilk
@ 2016-10-18 14:56 ` Konrad Rzeszutek Wilk
2016-10-18 15:51 ` Ian Jackson
2016-10-18 14:56 ` [PATCH 2/2] s/HttpProxy/DebianMirrorProxy/ Konrad Rzeszutek Wilk
1 sibling, 1 reply; 6+ messages in thread
From: Konrad Rzeszutek Wilk @ 2016-10-18 14:56 UTC (permalink / raw)
To: ian.jackson, xen-devel
Cc: Marcos.Matsunaga, Konrad Rzeszutek Wilk, Konrad Rzeszutek Wilk
From: Konrad Rzeszutek Wilk <konrad@osstest.dumpdata.com>
Mainly dctrl-grep which is in the dctrl-tools.
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
README | 1 +
1 file changed, 1 insertion(+)
diff --git a/README b/README
index 4ff7e8d..97f098b 100644
--- a/README
+++ b/README
@@ -253,6 +253,7 @@ To run osstest in standalone mode:
netcat
chiark-utils-bin
libxml-libxml-perl
+ dctrl-tools
- Optional:
ipmitool -- for hosts which use IPMI for power control
--
2.1.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH 2/2] s/HttpProxy/DebianMirrorProxy/
2016-10-18 14:56 [PATCH v1] Documentation and various fixes to osstest Konrad Rzeszutek Wilk
2016-10-18 14:56 ` [PATCH 1/2] README: Also mention other requirements Konrad Rzeszutek Wilk
@ 2016-10-18 14:56 ` Konrad Rzeszutek Wilk
2016-10-18 15:50 ` Ian Jackson
1 sibling, 1 reply; 6+ messages in thread
From: Konrad Rzeszutek Wilk @ 2016-10-18 14:56 UTC (permalink / raw)
To: ian.jackson, xen-devel
Cc: Marcos.Matsunaga, Konrad Rzeszutek Wilk, Konrad Rzeszutek Wilk
From: Konrad Rzeszutek Wilk <konrad@osstest.dumpdata.com>
where appropiate.
When constructing Debian related items we should be using the
DebianMirrorProxy instead of all catch HttpProxy.
Or alternatively support the case where are no HttProxy at all.
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
---
mg-debian-installer-update | 4 ++--
mgi-common | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/mg-debian-installer-update b/mg-debian-installer-update
index 38ae782..84127ad 100755
--- a/mg-debian-installer-update
+++ b/mg-debian-installer-update
@@ -64,8 +64,8 @@ dstroot=`getconfig TftpPath`/`getconfig TftpDiBase`/
date=`date +%Y-%m-%d`
dst=$arch/$date-$suite
-case "`getconfig HttpProxy`" in
-?*) export http_proxy=`getconfig HttpProxy` ;;
+case "`getconfig DebianMirrorProxy`" in
+?*) export http_proxy=`getconfig DebianMirrorProxy` ;;
esac
cd $dstroot
diff --git a/mgi-common b/mgi-common
index 8a2c2d9..45cae69 100644
--- a/mgi-common
+++ b/mgi-common
@@ -27,7 +27,7 @@ fetch () {
# and (2) if we are explicitly using a proxy to avoid getting
# stale data (bearing in mind that we run this interactively only)
: ${mg_update_proxy=$(
- cd $mg_update_org_pwd && getconfig HttpProxy
+ cd $mg_update_org_pwd && getconfig DebianMirrorProxy
)}
curl -s -H 'Pragma: no-cache' \
${mg_update_proxy+-x} ${mg_update_proxy} \
--
2.1.4
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] s/HttpProxy/DebianMirrorProxy/
2016-10-18 14:56 ` [PATCH 2/2] s/HttpProxy/DebianMirrorProxy/ Konrad Rzeszutek Wilk
@ 2016-10-18 15:50 ` Ian Jackson
2016-10-26 13:56 ` Konrad Rzeszutek Wilk
0 siblings, 1 reply; 6+ messages in thread
From: Ian Jackson @ 2016-10-18 15:50 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk; +Cc: xen-devel, Marcos.Matsunaga, Konrad Rzeszutek Wilk
Konrad Rzeszutek Wilk writes ("[PATCH 2/2] s/HttpProxy/DebianMirrorProxy/"):
> From: Konrad Rzeszutek Wilk <konrad@osstest.dumpdata.com>
...
> When constructing Debian related items we should be using the
> DebianMirrorProxy instead of all catch HttpProxy.
I don't think this is right, because apt-cachers and the like are only
required to support apt's uses, and not wgets of bits of installer.
But:
> Or alternatively support the case where are no HttProxy at all.
This is right. So I think the patch below is better.
Ian.
From 85741f132e62e0cdaef66860d417fa80e9df7a13 Mon Sep 17 00:00:00 2001
From: Ian Jackson <ian.jackson@eu.citrix.com>
Date: Tue, 18 Oct 2016 16:46:20 +0100
Subject: [OSSTEST PATCH] mgi-common: Support empty (unset) HttpProxy properly
mg_update_proxy ends up being set to the empty string so the {...:+-x}
form is needed to expand only non-empty values to `-x'.
Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
Reported-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
CC: Marcos Matsunaga <Marcos.Matsunaga@oracle.com>
---
mgi-common | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mgi-common b/mgi-common
index 8a2c2d9..5081521 100644
--- a/mgi-common
+++ b/mgi-common
@@ -30,7 +30,7 @@ fetch () {
cd $mg_update_org_pwd && getconfig HttpProxy
)}
curl -s -H 'Pragma: no-cache' \
- ${mg_update_proxy+-x} ${mg_update_proxy} \
+ ${mg_update_proxy:+-x} ${mg_update_proxy} \
$1
}
--
2.9.3
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] s/HttpProxy/DebianMirrorProxy/
2016-10-18 15:50 ` Ian Jackson
@ 2016-10-26 13:56 ` Konrad Rzeszutek Wilk
0 siblings, 0 replies; 6+ messages in thread
From: Konrad Rzeszutek Wilk @ 2016-10-26 13:56 UTC (permalink / raw)
To: Ian Jackson; +Cc: xen-devel, Marcos.Matsunaga, Konrad Rzeszutek Wilk
On Tue, Oct 18, 2016 at 04:50:31PM +0100, Ian Jackson wrote:
> Konrad Rzeszutek Wilk writes ("[PATCH 2/2] s/HttpProxy/DebianMirrorProxy/"):
> > From: Konrad Rzeszutek Wilk <konrad@osstest.dumpdata.com>
> ...
> > When constructing Debian related items we should be using the
> > DebianMirrorProxy instead of all catch HttpProxy.
>
> I don't think this is right, because apt-cachers and the like are only
> required to support apt's uses, and not wgets of bits of installer.
Yup!
>
> But:
>
> > Or alternatively support the case where are no HttProxy at all.
>
> This is right. So I think the patch below is better.
>
> Ian.
>
> >From 85741f132e62e0cdaef66860d417fa80e9df7a13 Mon Sep 17 00:00:00 2001
> From: Ian Jackson <ian.jackson@eu.citrix.com>
> Date: Tue, 18 Oct 2016 16:46:20 +0100
> Subject: [OSSTEST PATCH] mgi-common: Support empty (unset) HttpProxy properly
>
> mg_update_proxy ends up being set to the empty string so the {...:+-x}
> form is needed to expand only non-empty values to `-x'.
>
> Signed-off-by: Ian Jackson <ian.jackson@eu.citrix.com>
> Reported-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
And Tested-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> CC: Marcos Matsunaga <Marcos.Matsunaga@oracle.com>
> ---
> mgi-common | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mgi-common b/mgi-common
> index 8a2c2d9..5081521 100644
> --- a/mgi-common
> +++ b/mgi-common
> @@ -30,7 +30,7 @@ fetch () {
> cd $mg_update_org_pwd && getconfig HttpProxy
> )}
> curl -s -H 'Pragma: no-cache' \
> - ${mg_update_proxy+-x} ${mg_update_proxy} \
> + ${mg_update_proxy:+-x} ${mg_update_proxy} \
> $1
> }
>
> --
> 2.9.3
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-10-26 13:56 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-18 14:56 [PATCH v1] Documentation and various fixes to osstest Konrad Rzeszutek Wilk
2016-10-18 14:56 ` [PATCH 1/2] README: Also mention other requirements Konrad Rzeszutek Wilk
2016-10-18 15:51 ` Ian Jackson
2016-10-18 14:56 ` [PATCH 2/2] s/HttpProxy/DebianMirrorProxy/ Konrad Rzeszutek Wilk
2016-10-18 15:50 ` Ian Jackson
2016-10-26 13:56 ` Konrad Rzeszutek Wilk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).