Re: [PATCH 3/3] README: Mention the / requirement in Tftp[Dir|Tmp]Dir

[Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>]

On Wed, Oct 26, 2016 at 04:12:47PM +0100, Ian Jackson wrote:
> Konrad Rzeszutek Wilk writes ("[PATCH 3/3] README: Mention the / requirement in Tftp[Dir|Tmp]Dir"):
> > That is the / should be part of the directory name. Otherwise
> > we get strange files such as: pxelinux.cfgC0A86A3C
> > in the TftpPath directory.
> 
> I've edited this slightly.
> 
> Ian.
> 
> >From 9f0b83ebefc90c46fafd8efdba2b258926d18be0 Mon Sep 17 00:00:00 2001
> From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Date: Wed, 26 Oct 2016 14:14:09 -0400
> Subject: [OSSTEST PATCH] README: Mention the / requirement in Tftp[Dir|Tmp]Dir
                                                                     ^^^ - > Pxe

Ooops:

s/[Dir/[Pxe/

+1!
> 
> That is the / should be part of the directory name. Otherwise
> we get strange files such as: pxelinux.cfgC0A86A3C
> in the TftpPath directory.
> 
> Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
> Signed-off-by: Ian Jackson <Ian.Jackson@eu.citrix.com>
> ---
> v2: Slightly improved wording.
> ---
>  README | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/README b/README
> index 167c1bd..e3519a4 100644
> --- a/README
> +++ b/README
> @@ -497,9 +497,10 @@ Tftp*
>      TftpPath          The path to the root of the directory which is exposed by
>                        the tftpserver (e.g. /tftpboot).
>      TftpTmpDir        A directory under `Path' to use for temporary files.
> +                      Make sure you include the trailing / (e.g. tmp/)
>  
>      TftpPxeDir        The path under `Path' to the PXE configuration directory
> -                      (e.g. pxelinux.cfg)
> +                      (e.g. pxelinux.cfg/).   Include the trailing /.
>      TftpPxeGroup      The Unix group which should own files under `PxeDir'.
>      TftpPxeTemplates  See TftpPxeTemplates
>      TftpPxeTemplatesReal
> -- 
> 2.1.4
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel