xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: Dario Faggioli <dario.faggioli@citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
	Dagaen Golomb <dgolomb@cis.upenn.edu>,
	George Dunlap <George.Dunlap@eu.citrix.com>,
	Haoran Li <lihaoran@wustl.edu>,
	Linh Thi Xuan Phan <linhphan@cis.upenn.edu>,
	Meng Xu <xumengpanda@gmail.com>, Meng Xu <mengxu@cis.upenn.edu>,
	xen-devel@lists.xenproject.org,
	Tianyang Chen <tiche@cis.upenn.edu>
Subject: Re: [PATCH v3] xen:rtds: Fix bug in budget accounting
Date: Thu, 27 Oct 2016 11:03:39 +0100	[thread overview]
Message-ID: <20161027100339.GV30231@citrix.com> (raw)
In-Reply-To: <1477558463.16647.6.camel@citrix.com>

On Thu, Oct 27, 2016 at 10:54:23AM +0200, Dario Faggioli wrote:
> On Wed, 2016-10-26 at 15:06 -0400, Meng Xu wrote:
> > Fix:
> > We keeps last_start always within the current period for a VCPU, so
> > that
> > we only deduct the time spent in the current period from the VCPU
> > budget.
> > We always update last_start whenever we update cur_deadline for a
> > VCPU.
> > 
> > Signed-off-by: Meng Xu <mengxu@cis.upenn.edu>
> > Reported-by: Dagaen Golomb <dgolomb@cis.upenn.edu>
> > 
> Acked-by: Dario Faggioli <dario.faggioli@citrix.com>
> 
> Thanks.
> 
> Ehi, Wei. As said yesterday on IRC about the other patch:
>  - this is a bugfix
>  - this is a super-self contained change (all within RTDS)
>  - RTDS is Experimental
>  - it brings value, as it removes a subtle but annoying
>    behavioral bug in the scheduler
> 
> So, I know it's late, but if still possible, I think we should have it
> in 4.8.
> 

Applied.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

      reply	other threads:[~2016-10-27 10:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-26 19:06 [PATCH v3] xen:rtds: Fix bug in budget accounting Meng Xu
2016-10-27  8:54 ` Dario Faggioli
2016-10-27 10:03   ` Wei Liu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161027100339.GV30231@citrix.com \
    --to=wei.liu2@citrix.com \
    --cc=George.Dunlap@eu.citrix.com \
    --cc=dario.faggioli@citrix.com \
    --cc=dgolomb@cis.upenn.edu \
    --cc=lihaoran@wustl.edu \
    --cc=linhphan@cis.upenn.edu \
    --cc=mengxu@cis.upenn.edu \
    --cc=tiche@cis.upenn.edu \
    --cc=xen-devel@lists.xenproject.org \
    --cc=xumengpanda@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).