From: Wei Liu <wei.liu2@citrix.com>
To: Meng Xu <mengxu@cis.upenn.edu>
Cc: Wei Liu <wei.liu2@citrix.com>,
Dagaen Golomb <dgolomb@cis.upenn.edu>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Haoran Li <lihaoran@wustl.edu>,
Dario Faggioli <dario.faggioli@citrix.com>,
Linh Thi Xuan Phan <linhphan@cis.upenn.edu>,
"xen-devel@lists.xenproject.org" <xen-devel@lists.xenproject.org>,
Tianyang Chen <tiche@cis.upenn.edu>
Subject: Re: [PATCH] xen:rtds: Update last_start whenever cur_budget is updated
Date: Thu, 27 Oct 2016 14:43:45 +0100 [thread overview]
Message-ID: <20161027134345.GB30231@citrix.com> (raw)
In-Reply-To: <CAENZ-+my7eJiTP71SpD6c=f-CcW_k87rmF3p2G1hO77jcsmpfQ@mail.gmail.com>
On Thu, Oct 27, 2016 at 09:42:56AM -0400, Meng Xu wrote:
> Sorry, I accidentally sent out the previous email...
>
> On Thu, Oct 27, 2016 at 6:03 AM, Wei Liu <wei.liu2@citrix.com> wrote:
> > On Thu, Oct 27, 2016 at 11:14:36AM +0200, Dario Faggioli wrote:
> >> On Wed, 2016-10-26 at 15:06 -0400, Meng Xu wrote:
> >> > We keep last_start updated whenever cur_budget is updated.
> >> > This avoids subtle bugs in case burn_budget() will be called
> >> > in other places in the future.
> >> >
> >> I'd change this into something like:
> >>
> >> "Make budget accounting code more consistent by making sure the values
> >> used to compute how much budget has been consumed are updated together.
> >>
> >> This makes code resilient to calling burn_budget() from more than just
> >> one place --in case we will need to do that-- without risking subtle
> >> bugs."
> >>
>
> Agree.
>
> >> Also, when that is the case, like here, you need to explicitly state
> >> that no functional changes are intended.
>
> As Dario suggested, it's better to add one more line in the change log
> "No functional changes are intended."
>
> >>
> >> With all this done to the changelog:
> >>
> >> > Signed-off-by: Meng Xu <mengxu@cis.upenn.edu>
> >> >
> >> Acked-by: Dario Faggioli <dario.faggioli@citrix.com>
> >>
> >> This can go in 4.8, but can also well wait for 4.9.
>
> Agree..
>
> >>
> >
> > Meng, let me know if you're OK with Dario's suggestion.
>
> I'm OK with his suggestion.
> I can send out a new patch with the new commit change log, if needed.
>
No need. I will fix it up.
Wei.
> Thanks,
>
> Meng
>
> --
> ------------
> Meng Xu
> PhD Student in Computer and Information Science
> University of Pennsylvania
> http://www.cis.upenn.edu/~mengxu/
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-10-27 13:43 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-26 19:06 [PATCH] xen:rtds: Update last_start whenever cur_budget is updated Meng Xu
2016-10-27 9:14 ` Dario Faggioli
2016-10-27 10:03 ` Wei Liu
2016-10-27 13:40 ` Meng Xu
2016-10-27 13:42 ` Meng Xu
2016-10-27 13:43 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161027134345.GB30231@citrix.com \
--to=wei.liu2@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=dario.faggioli@citrix.com \
--cc=dgolomb@cis.upenn.edu \
--cc=lihaoran@wustl.edu \
--cc=linhphan@cis.upenn.edu \
--cc=mengxu@cis.upenn.edu \
--cc=tiche@cis.upenn.edu \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).