Re: [PATCH v3.1 03/15] xen/x86: allow calling {sh/hap}_set_allocation with the idle domain

[Roger Pau Monne <roger.pau@citrix.com>]

On Wed, Nov 02, 2016 at 06:14:13PM +0100, Roger Pau Monne wrote:
> On Tue, Nov 01, 2016 at 10:45:05AM +0000, Tim Deegan wrote:
> > At 10:34 -0600 on 31 Oct (1477910088), Jan Beulich wrote:
> > > >>> On 29.10.16 at 10:59, <roger.pau@citrix.com> wrote:
> >   * the idle vcpu (e.g. during dom0 construction), check if there is
> >   * background work to be done that should interrupt this operation.
> >   */
> >  static inline bool general_preempt_check(void)
> >  {
> >      return unlikely(softirq_pending(smp_processor_id()) ||
> >                      (!is_idle_vcpu(current) && local_events_need_delivery()));
> >  }
> >
> > If you're feeling keen, you could convert hypercall_preempt_check() to
> > an inline function and comment it too. :)
> 
> IMHO this is better, and I don't mind changing hypercall_preempt_check to an 
> inline function :).

So it turns out this is not trivial at all. Converting 
hypercall_preempt_check and also adding general_preempt_check as inline 
functions into shed.h causes trouble because they depend on 
local_events_need_delivery which in turn depends on the struct vcpu being 
defined. I could possibly move {general/hypercall}_preempt_check into 
xen/event.h and fixup the callers, but I would maybe prefer to leave this 
as-is for the time being, and add general_preempt_check as a macro.

Roger.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel