Libvirt build broken

Libvirt build broken

[Wei Liu]

Hi

Xen Project's CI system found a build failure between libvirt changes
06a7b1ff..478ddedc.  I don't think this is Xen specific FWIW.

The build log can be found at:

http://logs.test-lab.xenproject.org/osstest/logs/101868/build-amd64-libvirt/5.ts-libvirt-build.log

The first error:

  CC       libvirt_driver_la-libvirt-host.lo
libvirt.c:320:15: error: variable 'virTLSThreadImpl' has initializer but incomplete type
 static struct gcry_thread_cbs virTLSThreadImpl = {
               ^
Earlier in configure:

  configure:     gnutls: no 

From the look of it configure doesn't work properly anymore.


Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [libvirt] Libvirt build broken

[Olga Krishtal]

On 03/11/16 16:50, Wei Liu wrote:
> Hi
>
> Xen Project's CI system found a build failure between libvirt changes
> 06a7b1ff..478ddedc.  I don't think this is Xen specific FWIW.
>
> The build log can be found at:
>
> http://logs.test-lab.xenproject.org/osstest/logs/101868/build-amd64-libvirt/5.ts-libvirt-build.log
>
> The first error:
>
>    CC       libvirt_driver_la-libvirt-host.lo
> libvirt.c:320:15: error: variable 'virTLSThreadImpl' has initializer but incomplete type
>   static struct gcry_thread_cbs virTLSThreadImpl = {
>                 ^
> Earlier in configure:
>
>    configure:     gnutls: no
>
> >From the look of it configure doesn't work properly anymore.
>
>
> Wei.
>
> --
> libvir-list mailing list
> libvir-list@redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
I have just sent.
[PATCH] gcrypt: fix build in case we do not use gnutls and gcrypt


-- 
Best regards,
Olga


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [libvirt] Libvirt build broken

[Martin Kletzander]

[-- Attachment #1.1: Type: text/plain, Size: 1362 bytes --]

On Thu, Nov 03, 2016 at 01:50:17PM +0000, Wei Liu wrote:
>Hi
>
>Xen Project's CI system found a build failure between libvirt changes
>06a7b1ff..478ddedc.  I don't think this is Xen specific FWIW.
>

My guess is either 680d2f49dad425395de627a31006cb84848cfa65 or
0c62ccf927c60c9c248db52a23670ec2f9bce2b2 as those are the two that touch
gnutls configure stuff.

>The build log can be found at:
>
>http://logs.test-lab.xenproject.org/osstest/logs/101868/build-amd64-libvirt/5.ts-libvirt-build.log
>
>The first error:
>
>  CC       libvirt_driver_la-libvirt-host.lo
>libvirt.c:320:15: error: variable 'virTLSThreadImpl' has initializer but incomplete type
> static struct gcry_thread_cbs virTLSThreadImpl = {
>               ^
>Earlier in configure:
>
>  configure:     gnutls: no
>
>>From the look of it configure doesn't work properly anymore.
>

There are two problems here.  One is that you probably have old gnutls
(older than 2.2.0, for more info check the two commits).  That's why you
are not building with gnutls, but the real problem here (which is in the
code) is that we are not able to build without gnutls (my quick guess).
We are using struct gcry_thread_cbs even when building without gnutls
and that's what should be fixed, IMHO.

>
>Wei.
>
>--
>libvir-list mailing list
>libvir-list@redhat.com
>https://www.redhat.com/mailman/listinfo/libvir-list

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: Libvirt build broken

[Pavel Hrdina]

[-- Attachment #1.1: Type: text/plain, Size: 803 bytes --]

On Thu, Nov 03, 2016 at 01:50:17PM +0000, Wei Liu wrote:
> Hi
> 
> Xen Project's CI system found a build failure between libvirt changes
> 06a7b1ff..478ddedc.  I don't think this is Xen specific FWIW.
> 
> The build log can be found at:
> 
> http://logs.test-lab.xenproject.org/osstest/logs/101868/build-amd64-libvirt/5.ts-libvirt-build.log
> 
> The first error:
> 
>   CC       libvirt_driver_la-libvirt-host.lo
> libvirt.c:320:15: error: variable 'virTLSThreadImpl' has initializer but incomplete type
>  static struct gcry_thread_cbs virTLSThreadImpl = {
>                ^
> Earlier in configure:
> 
>   configure:     gnutls: no 

Hi

I've just pushed a patch that fixes this build issue:

<https://www.redhat.com/archives/libvir-list/2016-November/msg00206.html>

Pavel

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

[-- Attachment #2: Type: text/plain, Size: 127 bytes --]

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: Libvirt build broken

[Wei Liu]

On Thu, Nov 03, 2016 at 03:58:04PM +0100, Pavel Hrdina wrote:
> On Thu, Nov 03, 2016 at 01:50:17PM +0000, Wei Liu wrote:
> > Hi
> > 
> > Xen Project's CI system found a build failure between libvirt changes
> > 06a7b1ff..478ddedc.  I don't think this is Xen specific FWIW.
> > 
> > The build log can be found at:
> > 
> > http://logs.test-lab.xenproject.org/osstest/logs/101868/build-amd64-libvirt/5.ts-libvirt-build.log
> > 
> > The first error:
> > 
> >   CC       libvirt_driver_la-libvirt-host.lo
> > libvirt.c:320:15: error: variable 'virTLSThreadImpl' has initializer but incomplete type
> >  static struct gcry_thread_cbs virTLSThreadImpl = {
> >                ^
> > Earlier in configure:
> > 
> >   configure:     gnutls: no 
> 
> Hi
> 
> I've just pushed a patch that fixes this build issue:
> 
> <https://www.redhat.com/archives/libvir-list/2016-November/msg00206.html>
> 

Thanks!

Wei.

> Pavel



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel