* [PATCH for-4.8] xen/arm: early-printk: It should depends on CONFIG_DEBUG and not debug
@ 2016-11-03 14:36 Julien Grall
2016-11-03 14:44 ` Wei Liu
0 siblings, 1 reply; 2+ messages in thread
From: Julien Grall @ 2016-11-03 14:36 UTC (permalink / raw)
To: xen-devel; +Cc: Julien Grall, sstabellini, wei.liu2
The variable debug is used to enable debug for the tools. As
early-printk is for the hypervisor we should use CONFIG_DEBUG.
Signed-off-by: Julien Grall <julien.grall@arm.com>
---
This patch is candidate for Xen 4.8. This is a follow-up of [1].
[1] https://lists.xenproject.org/archives/html/xen-devel/2016-11/msg00082.html
---
xen/arch/arm/Rules.mk | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/xen/arch/arm/Rules.mk b/xen/arch/arm/Rules.mk
index 93304be..569a0ba 100644
--- a/xen/arch/arm/Rules.mk
+++ b/xen/arch/arm/Rules.mk
@@ -24,7 +24,7 @@ endif
EARLY_PRINTK := n
-ifeq ($(debug),y)
+ifeq ($(CONFIG_DEBUG),y)
# See docs/misc/arm/early-printk.txt for syntax
@@ -77,7 +77,7 @@ CFLAGS-$(EARLY_PRINTK) += -DEARLY_PRINTK_BAUD=$(EARLY_PRINTK_BAUD)
CFLAGS-$(EARLY_PRINTK) += -DEARLY_UART_BASE_ADDRESS=$(EARLY_UART_BASE_ADDRESS)
CFLAGS-$(EARLY_PRINTK) += -DEARLY_UART_REG_SHIFT=$(EARLY_UART_REG_SHIFT)
-else # !debug
+else # !CONFIG_DEBUG
ifneq ($(CONFIG_EARLY_PRINTK),)
# Early printk is dependant on a debug build.
--
1.9.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH for-4.8] xen/arm: early-printk: It should depends on CONFIG_DEBUG and not debug
2016-11-03 14:36 [PATCH for-4.8] xen/arm: early-printk: It should depends on CONFIG_DEBUG and not debug Julien Grall
@ 2016-11-03 14:44 ` Wei Liu
0 siblings, 0 replies; 2+ messages in thread
From: Wei Liu @ 2016-11-03 14:44 UTC (permalink / raw)
To: Julien Grall; +Cc: sstabellini, wei.liu2, xen-devel
On Thu, Nov 03, 2016 at 02:36:35PM +0000, Julien Grall wrote:
> The variable debug is used to enable debug for the tools. As
> early-printk is for the hypervisor we should use CONFIG_DEBUG.
>
> Signed-off-by: Julien Grall <julien.grall@arm.com>
>
Acked-by: Wei Liu <wei.liu2@citrix.com>
Sorry I missed this.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-03 14:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-03 14:36 [PATCH for-4.8] xen/arm: early-printk: It should depends on CONFIG_DEBUG and not debug Julien Grall
2016-11-03 14:44 ` Wei Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).