From: Wei Liu <wei.liu2@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: xen-devel <xen-devel@lists.xenproject.org>,
Wei Liu <wei.liu2@citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>
Subject: Re: [PATCH] x86/shutdown: add fall-through comment
Date: Mon, 7 Nov 2016 10:42:11 +0000 [thread overview]
Message-ID: <20161107104211.GC20651@citrix.com> (raw)
In-Reply-To: <582056C3020000780011C96B@prv-mh.provo.novell.com>
On Mon, Nov 07, 2016 at 02:26:11AM -0700, Jan Beulich wrote:
> Coverity ID: 1362037
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> --- a/xen/arch/x86/shutdown.c
> +++ b/xen/arch/x86/shutdown.c
> @@ -541,6 +541,7 @@ void machine_restart(unsigned int delay_
> {
> case BOOT_INVALID:
> ASSERT_UNREACHABLE();
> + /* fall through */
> case BOOT_KBD:
> /* Pulse the keyboard reset line. */
> for ( i = 0; i < 100; i++ )
>
>
>
> x86/shutdown: add fall-through comment
>
> Coverity ID: 1362037
>
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
Release-acked-by: Wei Liu <wei.liu2@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
prev parent reply other threads:[~2016-11-07 10:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-07 9:26 [PATCH] x86/shutdown: add fall-through comment Jan Beulich
2016-11-07 10:23 ` Andrew Cooper
2016-11-07 10:42 ` Wei Liu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161107104211.GC20651@citrix.com \
--to=wei.liu2@citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).