* [PATCH] IOMMU: release lock on new exit path
@ 2016-11-07 15:29 Jan Beulich
2016-11-07 15:58 ` Konrad Rzeszutek Wilk
0 siblings, 1 reply; 3+ messages in thread
From: Jan Beulich @ 2016-11-07 15:29 UTC (permalink / raw)
To: xen-devel; +Cc: Andrew Cooper, Wei Liu
[-- Attachment #1: Type: text/plain, Size: 543 bytes --]
This was overlooked in 7b2842a414 ("IOMMU: replace ASSERT()s checking
for NULL").
Reported-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/drivers/passthrough/io.c
+++ b/xen/drivers/passthrough/io.c
@@ -168,6 +168,7 @@ static void pt_irq_time_out(void *data)
if ( unlikely(!dpci) )
{
ASSERT_UNREACHABLE();
+ spin_unlock(&irq_map->dom->event_lock);
return;
}
list_for_each_entry ( digl, &irq_map->digl_list, list )
[-- Attachment #2: IOMMU-dpci-assert-unlock.patch --]
[-- Type: text/plain, Size: 577 bytes --]
IOMMU: release lock on new exit path
This was overlooked in 7b2842a414 ("IOMMU: replace ASSERT()s checking
for NULL").
Reported-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Signed-off-by: Jan Beulich <jbeulich@suse.com>
--- a/xen/drivers/passthrough/io.c
+++ b/xen/drivers/passthrough/io.c
@@ -168,6 +168,7 @@ static void pt_irq_time_out(void *data)
if ( unlikely(!dpci) )
{
ASSERT_UNREACHABLE();
+ spin_unlock(&irq_map->dom->event_lock);
return;
}
list_for_each_entry ( digl, &irq_map->digl_list, list )
[-- Attachment #3: Type: text/plain, Size: 127 bytes --]
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] IOMMU: release lock on new exit path
2016-11-07 15:29 [PATCH] IOMMU: release lock on new exit path Jan Beulich
@ 2016-11-07 15:58 ` Konrad Rzeszutek Wilk
2016-11-08 1:45 ` Wei Liu
0 siblings, 1 reply; 3+ messages in thread
From: Konrad Rzeszutek Wilk @ 2016-11-07 15:58 UTC (permalink / raw)
To: Jan Beulich; +Cc: xen-devel, Wei Liu, Andrew Cooper
On Mon, Nov 07, 2016 at 08:29:15AM -0700, Jan Beulich wrote:
> This was overlooked in 7b2842a414 ("IOMMU: replace ASSERT()s checking
> for NULL").
>
> Reported-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Thanks!
> Signed-off-by: Jan Beulich <jbeulich@suse.com>
>
> --- a/xen/drivers/passthrough/io.c
> +++ b/xen/drivers/passthrough/io.c
> @@ -168,6 +168,7 @@ static void pt_irq_time_out(void *data)
> if ( unlikely(!dpci) )
> {
> ASSERT_UNREACHABLE();
> + spin_unlock(&irq_map->dom->event_lock);
> return;
> }
> list_for_each_entry ( digl, &irq_map->digl_list, list )
>
>
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] IOMMU: release lock on new exit path
2016-11-07 15:58 ` Konrad Rzeszutek Wilk
@ 2016-11-08 1:45 ` Wei Liu
0 siblings, 0 replies; 3+ messages in thread
From: Wei Liu @ 2016-11-08 1:45 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk; +Cc: xen-devel, Wei Liu, Jan Beulich, Andrew Cooper
On Mon, Nov 07, 2016 at 10:58:43AM -0500, Konrad Rzeszutek Wilk wrote:
> On Mon, Nov 07, 2016 at 08:29:15AM -0700, Jan Beulich wrote:
> > This was overlooked in 7b2842a414 ("IOMMU: replace ASSERT()s checking
> > for NULL").
> >
> > Reported-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>
> Reviewed-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
>
Applied.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-11-08 1:45 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-07 15:29 [PATCH] IOMMU: release lock on new exit path Jan Beulich
2016-11-07 15:58 ` Konrad Rzeszutek Wilk
2016-11-08 1:45 ` Wei Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).