* [PATCH] Fix misleading indentation warnings
@ 2016-11-10 8:37 Cédric Bosdonnat
2016-11-10 8:42 ` Juergen Gross
0 siblings, 1 reply; 7+ messages in thread
From: Cédric Bosdonnat @ 2016-11-10 8:37 UTC (permalink / raw)
To: xen-devel; +Cc: Cédric Bosdonnat
Gcc6 build reports misleading indentation as warnings. Fix a few
warnings in stubdom.
---
stubdom/vtpmmgr/disk_read.c | 8 ++++----
stubdom/vtpmmgr/log.c | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/stubdom/vtpmmgr/disk_read.c b/stubdom/vtpmmgr/disk_read.c
index 944d3ff..48cfbfe 100644
--- a/stubdom/vtpmmgr/disk_read.c
+++ b/stubdom/vtpmmgr/disk_read.c
@@ -123,10 +123,10 @@ static int parse_root_key(struct mem_tpm_mgr *dst, struct disk_seal_entry *src)
struct disk_root_sealed_data sealed;
/*TPM 2.0 unbind | TPM 1.x unseal*/
- if (hw_is_tpm2())
- rc = TPM2_disk_unbind(&sealed, &olen, src);
- else
- rc = TPM_disk_unseal(&sealed, sizeof(sealed), src);
+ if (hw_is_tpm2())
+ rc = TPM2_disk_unbind(&sealed, &olen, src);
+ else
+ rc = TPM_disk_unseal(&sealed, sizeof(sealed), src);
if (rc)
return rc;
diff --git a/stubdom/vtpmmgr/log.c b/stubdom/vtpmmgr/log.c
index a82c913..c1bc8f3 100644
--- a/stubdom/vtpmmgr/log.c
+++ b/stubdom/vtpmmgr/log.c
@@ -147,5 +147,5 @@ const char* tpm_get_error_name (TPM_RESULT code) {
if (code == error_msgs[i].code)
return error_msgs[i].code_name;
- return("Unknown Error Code");
+ return("Unknown Error Code");
}
--
2.10.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] Fix misleading indentation warnings
2016-11-10 8:37 Cédric Bosdonnat
@ 2016-11-10 8:42 ` Juergen Gross
2016-11-10 9:25 ` Cedric Bosdonnat
0 siblings, 1 reply; 7+ messages in thread
From: Juergen Gross @ 2016-11-10 8:42 UTC (permalink / raw)
To: Cédric Bosdonnat, xen-devel; +Cc: Samuel Thibault, Wei Liu
On 10/11/16 09:37, Cédric Bosdonnat wrote:
> Gcc6 build reports misleading indentation as warnings. Fix a few
> warnings in stubdom.
You should CC: the maintainers. Calling
./scripts/get_maintainer.pl <patchfile>
will show them. Added them for now.
Juergen
> ---
> stubdom/vtpmmgr/disk_read.c | 8 ++++----
> stubdom/vtpmmgr/log.c | 2 +-
> 2 files changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/stubdom/vtpmmgr/disk_read.c b/stubdom/vtpmmgr/disk_read.c
> index 944d3ff..48cfbfe 100644
> --- a/stubdom/vtpmmgr/disk_read.c
> +++ b/stubdom/vtpmmgr/disk_read.c
> @@ -123,10 +123,10 @@ static int parse_root_key(struct mem_tpm_mgr *dst, struct disk_seal_entry *src)
> struct disk_root_sealed_data sealed;
>
> /*TPM 2.0 unbind | TPM 1.x unseal*/
> - if (hw_is_tpm2())
> - rc = TPM2_disk_unbind(&sealed, &olen, src);
> - else
> - rc = TPM_disk_unseal(&sealed, sizeof(sealed), src);
> + if (hw_is_tpm2())
> + rc = TPM2_disk_unbind(&sealed, &olen, src);
> + else
> + rc = TPM_disk_unseal(&sealed, sizeof(sealed), src);
>
> if (rc)
> return rc;
> diff --git a/stubdom/vtpmmgr/log.c b/stubdom/vtpmmgr/log.c
> index a82c913..c1bc8f3 100644
> --- a/stubdom/vtpmmgr/log.c
> +++ b/stubdom/vtpmmgr/log.c
> @@ -147,5 +147,5 @@ const char* tpm_get_error_name (TPM_RESULT code) {
> if (code == error_msgs[i].code)
> return error_msgs[i].code_name;
>
> - return("Unknown Error Code");
> + return("Unknown Error Code");
> }
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH] Fix misleading indentation warnings
@ 2016-11-10 9:23 Cédric Bosdonnat
2016-11-10 15:25 ` Daniel De Graaf
2016-11-11 2:05 ` Wei Liu
0 siblings, 2 replies; 7+ messages in thread
From: Cédric Bosdonnat @ 2016-11-10 9:23 UTC (permalink / raw)
To: xen-devel
Cc: Samuel Thibault, Daniel De Graaf, Cédric Bosdonnat, Quan Xu
Gcc6 build reports misleading indentation as warnings. Fix a few
warnings in stubdom.
Signed-off-by: Cédric Bosdonnat <cbosdonnat@suse.com>
---
stubdom/vtpmmgr/disk_read.c | 8 ++++----
stubdom/vtpmmgr/log.c | 2 +-
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/stubdom/vtpmmgr/disk_read.c b/stubdom/vtpmmgr/disk_read.c
index 944d3ff..48cfbfe 100644
--- a/stubdom/vtpmmgr/disk_read.c
+++ b/stubdom/vtpmmgr/disk_read.c
@@ -123,10 +123,10 @@ static int parse_root_key(struct mem_tpm_mgr *dst, struct disk_seal_entry *src)
struct disk_root_sealed_data sealed;
/*TPM 2.0 unbind | TPM 1.x unseal*/
- if (hw_is_tpm2())
- rc = TPM2_disk_unbind(&sealed, &olen, src);
- else
- rc = TPM_disk_unseal(&sealed, sizeof(sealed), src);
+ if (hw_is_tpm2())
+ rc = TPM2_disk_unbind(&sealed, &olen, src);
+ else
+ rc = TPM_disk_unseal(&sealed, sizeof(sealed), src);
if (rc)
return rc;
diff --git a/stubdom/vtpmmgr/log.c b/stubdom/vtpmmgr/log.c
index a82c913..c1bc8f3 100644
--- a/stubdom/vtpmmgr/log.c
+++ b/stubdom/vtpmmgr/log.c
@@ -147,5 +147,5 @@ const char* tpm_get_error_name (TPM_RESULT code) {
if (code == error_msgs[i].code)
return error_msgs[i].code_name;
- return("Unknown Error Code");
+ return("Unknown Error Code");
}
--
2.10.1
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] Fix misleading indentation warnings
2016-11-10 8:42 ` Juergen Gross
@ 2016-11-10 9:25 ` Cedric Bosdonnat
0 siblings, 0 replies; 7+ messages in thread
From: Cedric Bosdonnat @ 2016-11-10 9:25 UTC (permalink / raw)
To: Juergen Gross, xen-devel; +Cc: Samuel Thibault, Wei Liu
Hi Juergen,
Just resent the patch with the missing Signed-off-By and --cc-cmd './scripts/get_maintainers.pl'
--
Cedric
On Thu, 2016-11-10 at 09:42 +0100, Juergen Gross wrote:
> On 10/11/16 09:37, Cédric Bosdonnat wrote:
> > Gcc6 build reports misleading indentation as warnings. Fix a few
> > warnings in stubdom.
>
> You should CC: the maintainers. Calling
>
> ./scripts/get_maintainer.pl <patchfile>
>
> will show them. Added them for now.
>
>
> Juergen
>
> > ---
> > stubdom/vtpmmgr/disk_read.c | 8 ++++----
> > stubdom/vtpmmgr/log.c | 2 +-
> > 2 files changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/stubdom/vtpmmgr/disk_read.c b/stubdom/vtpmmgr/disk_read.c
> > index 944d3ff..48cfbfe 100644
> > --- a/stubdom/vtpmmgr/disk_read.c
> > +++ b/stubdom/vtpmmgr/disk_read.c
> > @@ -123,10 +123,10 @@ static int parse_root_key(struct mem_tpm_mgr *dst, struct disk_seal_entry *src)
> > struct disk_root_sealed_data sealed;
> >
> > /*TPM 2.0 unbind | TPM 1.x unseal*/
> > - if (hw_is_tpm2())
> > - rc = TPM2_disk_unbind(&sealed, &olen, src);
> > - else
> > - rc = TPM_disk_unseal(&sealed, sizeof(sealed), src);
> > + if (hw_is_tpm2())
> > + rc = TPM2_disk_unbind(&sealed, &olen, src);
> > + else
> > + rc = TPM_disk_unseal(&sealed, sizeof(sealed), src);
> >
> > if (rc)
> > return rc;
> > diff --git a/stubdom/vtpmmgr/log.c b/stubdom/vtpmmgr/log.c
> > index a82c913..c1bc8f3 100644
> > --- a/stubdom/vtpmmgr/log.c
> > +++ b/stubdom/vtpmmgr/log.c
> > @@ -147,5 +147,5 @@ const char* tpm_get_error_name (TPM_RESULT code) {
> > if (code == error_msgs[i].code)
> > return error_msgs[i].code_name;
> >
> > - return("Unknown Error Code");
> > + return("Unknown Error Code");
> > }
> >
>
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Fix misleading indentation warnings
2016-11-10 9:23 [PATCH] Fix misleading indentation warnings Cédric Bosdonnat
@ 2016-11-10 15:25 ` Daniel De Graaf
2016-11-11 0:16 ` Xuquan (Quan Xu)
2016-11-11 2:05 ` Wei Liu
1 sibling, 1 reply; 7+ messages in thread
From: Daniel De Graaf @ 2016-11-10 15:25 UTC (permalink / raw)
To: Cédric Bosdonnat, xen-devel; +Cc: Samuel Thibault, Quan Xu
On 11/10/2016 04:23 AM, Cédric Bosdonnat wrote:
> Gcc6 build reports misleading indentation as warnings. Fix a few
> warnings in stubdom.
>
> Signed-off-by: Cédric Bosdonnat <cbosdonnat@suse.com>
Acked-by: Daniel De Graaf <dgdegra@tycho.nsa.gov>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Fix misleading indentation warnings
2016-11-10 15:25 ` Daniel De Graaf
@ 2016-11-11 0:16 ` Xuquan (Quan Xu)
0 siblings, 0 replies; 7+ messages in thread
From: Xuquan (Quan Xu) @ 2016-11-11 0:16 UTC (permalink / raw)
To: Daniel De Graaf, Cédric Bosdonnat, xen-devel@lists.xen.org
Cc: Samuel Thibault
On November 10, 2016 11:25 PM, Daniel De Graaf wrote:
>On 11/10/2016 04:23 AM, Cédric Bosdonnat wrote:
>> Gcc6 build reports misleading indentation as warnings. Fix a few
>> warnings in stubdom.
>>
>> Signed-off-by: Cédric Bosdonnat <cbosdonnat@suse.com>
>
>Acked-by: Daniel De Graaf <dgdegra@tycho.nsa.gov>
Acked-by: Quan Xu <xuquan8@huawei.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] Fix misleading indentation warnings
2016-11-10 9:23 [PATCH] Fix misleading indentation warnings Cédric Bosdonnat
2016-11-10 15:25 ` Daniel De Graaf
@ 2016-11-11 2:05 ` Wei Liu
1 sibling, 0 replies; 7+ messages in thread
From: Wei Liu @ 2016-11-11 2:05 UTC (permalink / raw)
To: Cédric Bosdonnat
Cc: Samuel Thibault, Daniel De Graaf, Wei Liu, Quan Xu, xen-devel
On Thu, Nov 10, 2016 at 10:23:31AM +0100, Cédric Bosdonnat wrote:
> Gcc6 build reports misleading indentation as warnings. Fix a few
> warnings in stubdom.
>
> Signed-off-by: Cédric Bosdonnat <cbosdonnat@suse.com>
Applied.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2016-11-11 2:05 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-10 9:23 [PATCH] Fix misleading indentation warnings Cédric Bosdonnat
2016-11-10 15:25 ` Daniel De Graaf
2016-11-11 0:16 ` Xuquan (Quan Xu)
2016-11-11 2:05 ` Wei Liu
-- strict thread matches above, loose matches on Subject: below --
2016-11-10 8:37 Cédric Bosdonnat
2016-11-10 8:42 ` Juergen Gross
2016-11-10 9:25 ` Cedric Bosdonnat
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).