From: Ingo Molnar <mingo@kernel.org>
To: Alex Thorlton <athorlton@sgi.com>
Cc: Russ Anderson <rja@sgi.com>, Juergen Gross <jgross@suse.com>,
x86@kernel.org, Ingo Molnar <mingo@redhat.com>,
David Vrabel <david.vrabel@citrix.com>,
"H. Peter Anvin" <hpa@zytor.com>,
xen-devel@lists.xenproject.org,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] xen/x86: Increase xen_e820_map to E820_X_MAX possible entries
Date: Tue, 15 Nov 2016 07:30:35 +0100 [thread overview]
Message-ID: <20161115063035.GA27089@gmail.com> (raw)
In-Reply-To: <1479168677-23633-2-git-send-email-athorlton@sgi.com>
* Alex Thorlton <athorlton@sgi.com> wrote:
> On systems with sufficiently large e820 tables, and several IOAPICs, it
> is possible for the XENMEM_machine_memory_map callback (and its
> counterpart, XENMEM_memory_map) to attempt to return an e820 table with
> more than 128 entries. This callback adds entries to the BIOS-provided
> e820 table to account for IOAPIC registers, which, on sufficiently large
> systems, can result in an e820 table that is too large to copy back into
> xen_e820_map.
>
> This change simply increases the size of xen_e820_map to E820_X_MAX to
> ensure that there is enough room to store the entire e820 map returned
> from this callback.
This means:
#ifdef CONFIG_EFI
#include <linux/numa.h>
#define E820_X_MAX (E820MAX + 3 * MAX_NUMNODES)
#else /* ! CONFIG_EFI */
#define E820_X_MAX E820MAX
#endif
It's a bit weird to key it off of CONFIG_EFI - why isn't it unconditional?
But I have no objections to the principle if it fixes a crash.
Thanks,
Ingo
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-11-15 6:30 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1479168677-23633-1-git-send-email-athorlton@sgi.com>
2016-11-15 0:11 ` [PATCH] xen/x86: Increase xen_e820_map to E820_X_MAX possible entries Alex Thorlton
2016-11-15 6:30 ` Ingo Molnar [this message]
2016-11-16 17:16 ` Alex Thorlton
2016-11-16 6:09 ` Juergen Gross
2016-11-16 17:16 ` Alex Thorlton
2016-11-15 6:33 ` [RFC PATCH] " Juergen Gross
[not found] ` <a03b2e71-cc6a-7f62-6c09-877c576fab80@suse.com>
2016-11-15 7:15 ` Jan Beulich
[not found] ` <582AC427020000780011EA7E@suse.com>
2016-11-15 7:36 ` Juergen Gross
[not found] ` <a02052dd-83f8-2e6f-2dd3-e7165708225d@suse.com>
2016-11-15 8:01 ` Jan Beulich
[not found] ` <582ACEDE020000780011EAC9@suse.com>
2016-11-15 8:42 ` Juergen Gross
[not found] ` <478e5d05-ccf6-093e-8301-0eece00ca243@suse.com>
2016-11-15 9:45 ` Jan Beulich
[not found] ` <582AE72D020000780011EBB2@suse.com>
2016-11-15 9:55 ` Juergen Gross
[not found] ` <4bac3691-f157-4acc-7b29-7c49be6d35d6@suse.com>
2016-11-15 10:44 ` Jan Beulich
[not found] ` <582AF51F020000780011ECB4@suse.com>
2016-11-15 11:07 ` Juergen Gross
[not found] ` <dcaf32d2-9d26-b966-bf94-1ea3e888403c@suse.com>
2016-11-15 11:12 ` Jan Beulich
2016-11-15 15:22 ` Alex Thorlton
[not found] ` <20161115152209.GA67776@stormcage.americas.sgi.com>
2016-11-16 6:06 ` Juergen Gross
2016-11-16 16:42 ` Juergen Gross
2016-11-16 16:53 ` Alex Thorlton
2016-11-18 0:04 ` Alex Thorlton
2016-11-30 3:24 ` [RFC PATCH v2] " Alex Thorlton
[not found] ` <1480476287-232878-1-git-send-email-athorlton@sgi.com>
2016-11-30 3:24 ` [PATCH 1/2] x86: Make E820_X_MAX unconditionally larger than E820MAX Alex Thorlton
2016-11-30 6:21 ` Ingo Molnar
[not found] ` <20161130062148.GA11684@gmail.com>
2016-12-01 18:37 ` Alex Thorlton
2016-11-30 3:24 ` [PATCH 2/2] xen/x86: Increase xen_e820_map to E820_X_MAX possible entries Alex Thorlton
[not found] ` <1480476287-232878-3-git-send-email-athorlton@sgi.com>
2016-11-30 5:18 ` Juergen Gross
2016-12-05 17:49 ` [RFC PATCH v3] " Alex Thorlton
[not found] ` <1480960154-211541-1-git-send-email-athorlton@sgi.com>
2016-12-05 17:49 ` [PATCH 1/2] x86: Make E820_X_MAX unconditionally larger than E820MAX Alex Thorlton
2016-12-05 17:49 ` [PATCH 2/2] xen/x86: Increase xen_e820_map to E820_X_MAX possible entries Alex Thorlton
2016-12-08 5:50 ` [RFC PATCH v3] " Juergen Gross
[not found] ` <ed498aea-127a-246c-79e8-67ade61ba0ce@suse.com>
2016-12-09 3:46 ` Ingo Molnar
[not found] ` <1480960154-211541-2-git-send-email-athorlton@sgi.com>
2016-12-09 10:12 ` [PATCH 1/2] x86: Make E820_X_MAX unconditionally larger than E820MAX Juergen Gross
[not found] ` <1480960154-211541-3-git-send-email-athorlton@sgi.com>
2016-12-09 10:12 ` [PATCH 2/2] xen/x86: Increase xen_e820_map to E820_X_MAX possible entries Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161115063035.GA27089@gmail.com \
--to=mingo@kernel.org \
--cc=athorlton@sgi.com \
--cc=david.vrabel@citrix.com \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=mingo@redhat.com \
--cc=rja@sgi.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).