OSSTest, standalone, weird end of invocation.

OSSTest, standalone, weird end of invocation.

[Konrad Rzeszutek Wilk]

Hey Ian,

I've my test machine, and I can run some of the standalone
tests. But everytime I run any of the jobs I get:

.. snip..
2016-11-16 00:07:55 Z setting xtfbuildjob=build-amd64-xtf
2016-11-16 00:07:55 Z log capturing not enabled
+ rc=0
+ date -u +%Y-%m-%d %H:%M:%S Z exit status 0
2016-11-16 00:07:55 Z exit status 0
+ exit 0
2016-11-16 00:07:55 Z standalone.test-xtf-amd64-amd64-1 13 status status pass
2016-11-16 00:07:55 Z finished standalone.test-xtf-amd64-amd64-1 ts-logs-capture host pass
expected boolean value but got ""
    while executing
"if {[jobdb::job-check-escaped-steps $flight $job]} {
            set ok 0
        }"
    (procedure "run-job" line 54)
    invoked from within
"run-job $job"
    (file "./sg-run-job" line 537)
konrad@osstest:~/osstest$ echo $?
1


Any clue what I amissing? I have been ignoring it and been focusing on
other things.

My .config is:

konrad@osstest:~/osstest$ more ~/.xen-osstest/config 
NetNameservers 192.168.106.1
DnsDomain dumpdata.com

DebianMirrorProxy http://osstest.dumpdata.com:3142/
WebspaceUrl http://osstest.dumpdata.com/~konrad/
WebspaceLog /var/log/apache2/access.log
WebspaceFile /home/konrad/public_html/

TestHost tst060
HostProp_tst060_Ether 00:25:90:7c:28:c8
HostProp_tst060_DIFrontend newt
HostProp_tst060_PowerMethod lab
HostProp_tst060_Build_Make_Flags -j32
HostFlags_tst060 need-firmware-deb-firmware-bnx2
HostProp_DhcpWatchMethod leases dhcp3 /var/lib/dhcp/dhcpd.leases

DebianSuite jessie

TftpPath /srv/tftp/
TftpTmpDir tmp/
TftpPxeDir pxelinux.cfg/
TftpPxeGroup konrad

and I am on top of:
commit 5d88d6299618f6bce204d82579392a76028fb8cd
Author: Ian Jackson <ian.jackson@eu.citrix.com>
Date:   Fri Nov 4 19:00:02 2016 +0000


(Well to be honest there are also some of my patches in there
but they don't influence this error).



_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: OSSTest, standalone, weird end of invocation.

[Anthony PERARD]

On Tue, Nov 15, 2016 at 04:07:03PM -0500, Konrad Rzeszutek Wilk wrote:
> Hey Ian,
> 
> I've my test machine, and I can run some of the standalone
> tests. But everytime I run any of the jobs I get:
> 
> .. snip..
> 2016-11-16 00:07:55 Z setting xtfbuildjob=build-amd64-xtf
> 2016-11-16 00:07:55 Z log capturing not enabled
> + rc=0
> + date -u +%Y-%m-%d %H:%M:%S Z exit status 0
> 2016-11-16 00:07:55 Z exit status 0
> + exit 0
> 2016-11-16 00:07:55 Z standalone.test-xtf-amd64-amd64-1 13 status status pass
> 2016-11-16 00:07:55 Z finished standalone.test-xtf-amd64-amd64-1 ts-logs-capture host pass
> expected boolean value but got ""
>     while executing
> "if {[jobdb::job-check-escaped-steps $flight $job]} {
>             set ok 0
>         }"
>     (procedure "run-job" line 54)
>     invoked from within
> "run-job $job"
>     (file "./sg-run-job" line 537)
> konrad@osstest:~/osstest$ echo $?
> 1
> 
> Any clue what I amissing? I have been ignoring it and been focusing on
> other things.
> 

Nothing. It's a missing implementation of job-check-escaped-steps for
standalone.

I have this patch/hack:

diff --git a/tcl/JobDB-Standalone.tcl b/tcl/JobDB-Standalone.tcl
index 375e6ba..09eac6e 100644
--- a/tcl/JobDB-Standalone.tcl
+++ b/tcl/JobDB-Standalone.tcl
@@ -57,7 +57,7 @@ proc read-runvar {flight job name {val {}}} {
     return $val
 }
 
-proc job-check-escaped-steps {flight job} { }
+proc job-check-escaped-steps {flight job} { return 0 }
 
 proc ensure-db-open {} {
     global c


-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: OSSTest, standalone, weird end of invocation.

[Ian Jackson]

Konrad Rzeszutek Wilk writes ("OSSTest, standalone, weird end of invocation."):
> I've my test machine, and I can run some of the standalone
> tests. But everytime I run any of the jobs I get:

Erk.  Try this.

Ian.

diff --git a/tcl/JobDB-Standalone.tcl b/tcl/JobDB-Standalone.tcl
index 375e6ba..09eac6e 100644
--- a/tcl/JobDB-Standalone.tcl
+++ b/tcl/JobDB-Standalone.tcl
@@ -57,7 +57,7 @@ proc read-runvar {flight job name {val {}}} {
     return $val
 }
 
-proc job-check-escaped-steps {flight job} { }
+proc job-check-escaped-steps {flight job} { return 0 }
 
 proc ensure-db-open {} {
     global c

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel