xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: Ross Lagerwall <ross.lagerwall@citrix.com>, xen-devel@lists.xen.org
Subject: Re: [XTF PATCH v2] Add a Live Patch privilege check test
Date: Fri, 18 Nov 2016 12:51:34 -0500	[thread overview]
Message-ID: <20161118175134.GN4028@x230.dumpdata.com> (raw)
In-Reply-To: <c68000f6-2e74-eddd-a151-8d143b8d0c97@citrix.com>

> > +    xen_sysctl_t op =
> > +    {
> > +        .cmd = XEN_SYSCTL_livepatch_op,
> > +        .interface_version = interface_version,
> > +        .u.livepatch = {
> > +            .cmd = XEN_SYSCTL_LIVEPATCH_UPLOAD,
> > +            .u.upload = {
> > +                .name = {
> > +                    .name.p = TEST_NAME,
> > +                    .size = sizeof(TEST_NAME),
> 
> Do we seriously send the number of characters in the name, rather than
> treating it like a NULL terminated string within the reasonable bound?

We do have an upper-limit at which it will fail (128 characters).

But the user is welcome to use a lower limit.
> 
> ~Andrew
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> https://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

      reply	other threads:[~2016-11-18 17:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-18  9:36 [XTF PATCH v2] Add a Live Patch privilege check test Ross Lagerwall
2016-11-18 15:25 ` Konrad Rzeszutek Wilk
2016-11-18 17:33 ` Andrew Cooper
2016-11-18 17:51   ` Konrad Rzeszutek Wilk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161118175134.GN4028@x230.dumpdata.com \
    --to=konrad.wilk@oracle.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=ross.lagerwall@citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).