xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: edk2-devel-01 <edk2-devel@ml01.01.org>, xen-devel@lists.xenproject.org
Subject: Re: [edk2] [PATCH RESEND] OvmfPkg/build.sh: Use GCC49 toolchain with GCC 6.*
Date: Mon, 21 Nov 2016 11:39:25 -0500	[thread overview]
Message-ID: <20161121163925.GB29818@localhost.localdomain> (raw)
In-Reply-To: <CAKv+Gu8+p-fKbaDMJPs4KqQkZTErJT3bXVo3dZ9RDsPhGwEvsQ@mail.gmail.com>

On Mon, Nov 21, 2016 at 04:20:04PM +0000, Ard Biesheuvel wrote:
> On 21 November 2016 at 15:56, Konrad Rzeszutek Wilk <konrad@kernel.org> wrote:
> > Without this I cannot build it under Fedora Core 25.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Signed-off-by: Konrad Rzeszutek Wilk <konrad@kernel.org>
> > ---
> >  OvmfPkg/build.sh | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
> > index eb5eb73..759ade3 100755
> > --- a/OvmfPkg/build.sh
> > +++ b/OvmfPkg/build.sh
> > @@ -95,7 +95,7 @@ case `uname` in
> >        4.8.*)
> >          TARGET_TOOLS=GCC48
> >          ;;
> > -      4.9.*|4.1[0-9].*|5.*.*)
> > +      4.9.*|4.1[0-9].*|5.*.*|6.*.*)
> >          TARGET_TOOLS=GCC49
> >          ;;
> >        *)
> 
> I think it may be time to start using GCC5 for 5.x and later

This did the trick as well.

I don't have GCC 5.*.* so I could not confirm.

diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
index 759ade3..4d0d0d4 100755
--- a/OvmfPkg/build.sh
+++ b/OvmfPkg/build.sh
@@ -95,9 +95,12 @@ case `uname` in
       4.8.*)
         TARGET_TOOLS=GCC48
         ;;
-      4.9.*|4.1[0-9].*|5.*.*|6.*.*)
+      4.9.*|4.1[0-9].*|5.*.*)
         TARGET_TOOLS=GCC49
         ;;
+      6.*.*)
+        TARGET_TOOLS=GCC5
+        ;;
       *)
         TARGET_TOOLS=GCC44
         ;;


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  parent reply	other threads:[~2016-11-21 16:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20161121155651.4781-1-konrad@kernel.org>
2016-11-21 15:56 ` [PATCH RESEND] OvmfPkg/build.sh: Use GCC49 toolchain with GCC 6.* Konrad Rzeszutek Wilk
     [not found] ` <20161121155651.4781-2-konrad@kernel.org>
2016-11-21 16:20   ` [edk2] " Ard Biesheuvel
     [not found]   ` <CAKv+Gu8+p-fKbaDMJPs4KqQkZTErJT3bXVo3dZ9RDsPhGwEvsQ@mail.gmail.com>
2016-11-21 16:39     ` Konrad Rzeszutek Wilk [this message]
2016-11-21 20:07     ` Laszlo Ersek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161121163925.GB29818@localhost.localdomain \
    --to=konrad.wilk@oracle.com \
    --cc=ard.biesheuvel@linaro.org \
    --cc=edk2-devel@ml01.01.org \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).