* Re: [edk2] [PATCH RESEND] OvmfPkg/build.sh: Use GCC49 toolchain with GCC 6.*
[not found] ` <CAKv+Gu8+p-fKbaDMJPs4KqQkZTErJT3bXVo3dZ9RDsPhGwEvsQ@mail.gmail.com>
@ 2016-11-21 16:39 ` Konrad Rzeszutek Wilk
2016-11-21 20:07 ` Laszlo Ersek
1 sibling, 0 replies; 4+ messages in thread
From: Konrad Rzeszutek Wilk @ 2016-11-21 16:39 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: edk2-devel-01, xen-devel
On Mon, Nov 21, 2016 at 04:20:04PM +0000, Ard Biesheuvel wrote:
> On 21 November 2016 at 15:56, Konrad Rzeszutek Wilk <konrad@kernel.org> wrote:
> > Without this I cannot build it under Fedora Core 25.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Signed-off-by: Konrad Rzeszutek Wilk <konrad@kernel.org>
> > ---
> > OvmfPkg/build.sh | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
> > index eb5eb73..759ade3 100755
> > --- a/OvmfPkg/build.sh
> > +++ b/OvmfPkg/build.sh
> > @@ -95,7 +95,7 @@ case `uname` in
> > 4.8.*)
> > TARGET_TOOLS=GCC48
> > ;;
> > - 4.9.*|4.1[0-9].*|5.*.*)
> > + 4.9.*|4.1[0-9].*|5.*.*|6.*.*)
> > TARGET_TOOLS=GCC49
> > ;;
> > *)
>
> I think it may be time to start using GCC5 for 5.x and later
This did the trick as well.
I don't have GCC 5.*.* so I could not confirm.
diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
index 759ade3..4d0d0d4 100755
--- a/OvmfPkg/build.sh
+++ b/OvmfPkg/build.sh
@@ -95,9 +95,12 @@ case `uname` in
4.8.*)
TARGET_TOOLS=GCC48
;;
- 4.9.*|4.1[0-9].*|5.*.*|6.*.*)
+ 4.9.*|4.1[0-9].*|5.*.*)
TARGET_TOOLS=GCC49
;;
+ 6.*.*)
+ TARGET_TOOLS=GCC5
+ ;;
*)
TARGET_TOOLS=GCC44
;;
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [edk2] [PATCH RESEND] OvmfPkg/build.sh: Use GCC49 toolchain with GCC 6.*
[not found] ` <CAKv+Gu8+p-fKbaDMJPs4KqQkZTErJT3bXVo3dZ9RDsPhGwEvsQ@mail.gmail.com>
2016-11-21 16:39 ` Konrad Rzeszutek Wilk
@ 2016-11-21 20:07 ` Laszlo Ersek
1 sibling, 0 replies; 4+ messages in thread
From: Laszlo Ersek @ 2016-11-21 20:07 UTC (permalink / raw)
To: Konrad Rzeszutek Wilk
Cc: xen-devel, edk2-devel-01, Olaf Hering,
Jordan Justen (Intel address), Ard Biesheuvel
On 11/21/16 17:20, Ard Biesheuvel wrote:
> On 21 November 2016 at 15:56, Konrad Rzeszutek Wilk <konrad@kernel.org> wrote:
>> Without this I cannot build it under Fedora Core 25.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.0
>> Signed-off-by: Konrad Rzeszutek Wilk <konrad@kernel.org>
>> ---
>> OvmfPkg/build.sh | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/OvmfPkg/build.sh b/OvmfPkg/build.sh
>> index eb5eb73..759ade3 100755
>> --- a/OvmfPkg/build.sh
>> +++ b/OvmfPkg/build.sh
>> @@ -95,7 +95,7 @@ case `uname` in
>> 4.8.*)
>> TARGET_TOOLS=GCC48
>> ;;
>> - 4.9.*|4.1[0-9].*|5.*.*)
>> + 4.9.*|4.1[0-9].*|5.*.*|6.*.*)
>> TARGET_TOOLS=GCC49
>> ;;
>> *)
>
> I think it may be time to start using GCC5 for 5.x and later
I agree.
We have an open BZ for this:
https://bugzilla.tianocore.org/show_bug.cgi?id=62
Olaf Hering submitted a patch around June, but the formalities on those
patches weren't right, and Olaf decided not to submit further versions
of the patch.
Here's the idea:
- change the catch-all (*) to GCC5, from GCC44
- remove the (5.*.*) pattern from GCC49
- add a branch (with multiple patterns if necessary) for gcc-4.3 and
earlier to exit with an error message / failure (those compiler
versions are unsupported)
Konrad, can you please submit a v2 with this? If so, please add the tag
Bugzilla: https://bugzilla.tianocore.org/show_bug.cgi?id=62
as well, just before the "Contributed-under:" tag.
(Side note: we haven't been ignoring BZ#62. It's just that after
reviewing Olaf's original patch, implementing the change -- which is
very simple and cannot really be done in different ways -- in his stead
would have practically consisted of replacing Olaf's signoff with
someone elses, and we couldn't do that.)
Thank you,
Laszlo
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 4+ messages in thread