xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: ian.jackson@eu.citrix.com, xen-devel@lists.xenproject.org
Subject: Re: [PATCH 1/2] build system: Include SeaBIOS and TianoCore directory
Date: Tue, 22 Nov 2016 23:02:04 -0500	[thread overview]
Message-ID: <20161123040204.GA10301@localhost.localdomain> (raw)
In-Reply-To: <20161123023935.GV23528@citrix.com>

On Wed, Nov 23, 2016 at 02:39:35AM +0000, Wei Liu wrote:
> On Sun, Nov 20, 2016 at 10:27:21PM -0500, Konrad Rzeszutek Wilk wrote:
> > The release source did not include those two directories.
> > 
> > Signed-off-by: Konrad Rzeszutek Wilk <konrad@kernel.org>
> > ---
> >  tools/misc/mktarball | 5 +++++
> >  1 file changed, 5 insertions(+)
> > 
> > diff --git a/tools/misc/mktarball b/tools/misc/mktarball
> > index 73282b5..7942846 100755
> > --- a/tools/misc/mktarball
> > +++ b/tools/misc/mktarball
> > @@ -35,6 +35,11 @@ git_archive_into $xen_root/tools/qemu-xen-traditional-dir-remote $tdir/xen-$desc
> >  
> >  git_archive_into $xen_root/extras/mini-os-remote $tdir/xen-$desc/extras/mini-os
> >  
> > +git_archive_into $xen_root/tools/firmware/seabios-dir-remote $tdir/xen-$desc/tools/firmware/seabios-dir
> > +
> > +if [ -d $xen_root/tools/firmware/ovmf-dir-remote ]; then
> 
> Is this test really needed? I think subtree-force-update-all will clone
> ovmf anyway.

I think it only does that if CONFIG_OVMF is in your local .config -
which is only the case if you run ./configure --enable-ovmf


> 
> > +    git_archive_into $xen_root/tools/firmware/ovmf-dir-remote $tdir/xen-$desc/tools/firmware/ovmf-dir
> > +fi
> >  GZIP=-9v tar cz -f $xen_root/dist/xen-$desc.tar.gz -C $tdir xen-$desc
> >  
> >  echo "Source tarball in $xen_root/dist/xen-$desc.tar.gz"
> > -- 
> > 2.9.3
> > 
> 
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> https://lists.xen.org/xen-devel

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2016-11-23  4:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-21  3:27 [PATCH] Fixes to build-system (make src-tarball-release) Konrad Rzeszutek Wilk
2016-11-21  3:27 ` [PATCH 1/2] build system: Include SeaBIOS and TianoCore directory Konrad Rzeszutek Wilk
2016-11-23  2:39   ` Wei Liu
2016-11-23  4:02     ` Konrad Rzeszutek Wilk [this message]
2016-11-23 10:14       ` Wei Liu
2016-11-23 12:25         ` Konrad Rzeszutek Wilk
2016-11-21  3:27 ` [PATCH 2/2] build system: Also include the TianoCore custom Makefile Konrad Rzeszutek Wilk
2016-11-21 14:43 ` [PATCH 3/3] build system: Also copy ipxe.tar.gz Konrad Rzeszutek Wilk
2016-11-22 10:29 ` [PATCH] Fixes to build-system (make src-tarball-release) Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161123040204.GA10301@localhost.localdomain \
    --to=konrad.wilk@oracle.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).