From: Wei Liu <wei.liu2@citrix.com>
To: "Cédric Bosdonnat" <cbosdonnat@suse.com>
Cc: Juergen Gross <jgross@suse.com>, Wei Liu <wei.liu2@citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
xen-devel@lists.xen.org, Jan Beulich <JBeulich@suse.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>
Subject: Re: [PATCH] libxl: invert xc and domain model resume calls in xc_domain_resume()
Date: Tue, 29 Nov 2016 07:34:38 +0000 [thread overview]
Message-ID: <20161129073438.GM11640@citrix.com> (raw)
In-Reply-To: <20161128135357.5543-1-cbosdonnat@suse.com>
On Mon, Nov 28, 2016 at 02:53:57PM +0100, Cédric Bosdonnat wrote:
> Resume is sometimes silently failing for HVM guests. Getting the
> xc_domain_resume() and libxl__domain_resume_device_model() in the
> reverse order than what is in the suspend code fixes the problem.
>
> Signed-off-by: Cédric Bosdonnat <cbosdonnat@suse.com>
I think it would be nice to explain why reversing the order fixes the
problem for you. My guess is because device model needs to be ready when
the guest runs, but I'm not fully convinced by this explanation --
guests should just be trapped in the hypervisor waiting for device model
to come up.
I also CC'ed other people who are more familiar with this area so that
they can provide insight.
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-11-29 7:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-28 13:53 [PATCH] libxl: invert xc and domain model resume calls in xc_domain_resume() Cédric Bosdonnat
2016-11-29 7:34 ` Wei Liu [this message]
2016-11-29 8:47 ` Juergen Gross
2016-11-29 19:15 ` Stefano Stabellini
2016-12-01 13:29 ` Wei Liu
2016-12-07 11:14 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161129073438.GM11640@citrix.com \
--to=wei.liu2@citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=cbosdonnat@suse.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jgross@suse.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).