* [PATCH] xen/arm: Fix misplaced parentheses for PSCI version check
@ 2016-11-30 13:53 Artem Mygaiev
2016-11-30 15:55 ` Julien Grall
0 siblings, 1 reply; 6+ messages in thread
From: Artem Mygaiev @ 2016-11-30 13:53 UTC (permalink / raw)
To: xen-devel@lists.xenproject.org; +Cc: Julien Grall, Stefano Stabellini
Fix misplaced parentheses for PSCI version check
Signed-off-by: Artem Mygaiev <artem_mygaiev@epam.com>
---
xen/arch/arm/psci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xen/arch/arm/psci.c b/xen/arch/arm/psci.c
index 7966b5e..34ee97e 100644
--- a/xen/arch/arm/psci.c
+++ b/xen/arch/arm/psci.c
@@ -147,7 +147,7 @@ int __init psci_init_0_2(void)
psci_ver = call_smc(PSCI_0_2_FN_PSCI_VERSION, 0, 0, 0);
/* For the moment, we only support PSCI 0.2 and PSCI 1.x */
- if ( psci_ver != PSCI_VERSION(0, 2) && PSCI_VERSION_MAJOR(psci_ver != 1) )
+ if ( psci_ver != PSCI_VERSION(0, 2) && PSCI_VERSION_MAJOR(psci_ver) != 1 )
{
printk("Error: Unrecognized PSCI version %u.%u\n",
PSCI_VERSION_MAJOR(psci_ver), PSCI_VERSION_MINOR(psci_ver));
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] xen/arm: Fix misplaced parentheses for PSCI version check
2016-11-30 13:53 [PATCH] xen/arm: Fix misplaced parentheses for PSCI version check Artem Mygaiev
@ 2016-11-30 15:55 ` Julien Grall
2016-11-30 19:16 ` Stefano Stabellini
2016-12-06 13:57 ` Artem Mygaiev
0 siblings, 2 replies; 6+ messages in thread
From: Julien Grall @ 2016-11-30 15:55 UTC (permalink / raw)
To: Artem Mygaiev, xen-devel@lists.xenproject.org; +Cc: Stefano Stabellini
Hi Artem,
On 30/11/16 13:53, Artem Mygaiev wrote:
> Fix misplaced parentheses for PSCI version check
>
> Signed-off-by: Artem Mygaiev <artem_mygaiev@epam.com>
Can you please include the coverity ID:
Coverity-ID: 1381830
With that:
Reviewed-by: Julien Grall <julien.grall@arm.com>
This has been introduced by me in commit 2831f20 "xen/arm: Add support
of PSCI v1.0 for the host" in Xen 4.7. I am not sure whether we should
backport it.
Cheers,
--
Julien Grall
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xen/arm: Fix misplaced parentheses for PSCI version check
2016-11-30 15:55 ` Julien Grall
@ 2016-11-30 19:16 ` Stefano Stabellini
2016-12-01 2:06 ` Wei Liu
2016-12-06 13:57 ` Artem Mygaiev
1 sibling, 1 reply; 6+ messages in thread
From: Stefano Stabellini @ 2016-11-30 19:16 UTC (permalink / raw)
To: Julien Grall
Cc: Artem Mygaiev, xen-devel@lists.xenproject.org, Stefano Stabellini,
wei.liu2
On Wed, 30 Nov 2016, Julien Grall wrote:
> Hi Artem,
>
> On 30/11/16 13:53, Artem Mygaiev wrote:
> > Fix misplaced parentheses for PSCI version check
> >
> > Signed-off-by: Artem Mygaiev <artem_mygaiev@epam.com>
>
> Can you please include the coverity ID:
>
> Coverity-ID: 1381830
>
> With that:
>
> Reviewed-by: Julien Grall <julien.grall@arm.com>
>
> This has been introduced by me in commit 2831f20 "xen/arm: Add support of PSCI
> v1.0 for the host" in Xen 4.7. I am not sure whether we should backport it.
I think we should backport it.
Wei, can I have a release-ack or do you want to wait until after the
release?
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xen/arm: Fix misplaced parentheses for PSCI version check
2016-11-30 19:16 ` Stefano Stabellini
@ 2016-12-01 2:06 ` Wei Liu
2016-12-03 1:01 ` Stefano Stabellini
0 siblings, 1 reply; 6+ messages in thread
From: Wei Liu @ 2016-12-01 2:06 UTC (permalink / raw)
To: Stefano Stabellini
Cc: Artem Mygaiev, xen-devel@lists.xenproject.org, Julien Grall,
wei.liu2
On Wed, Nov 30, 2016 at 11:16:49AM -0800, Stefano Stabellini wrote:
> On Wed, 30 Nov 2016, Julien Grall wrote:
> > Hi Artem,
> >
> > On 30/11/16 13:53, Artem Mygaiev wrote:
> > > Fix misplaced parentheses for PSCI version check
> > >
> > > Signed-off-by: Artem Mygaiev <artem_mygaiev@epam.com>
> >
> > Can you please include the coverity ID:
> >
> > Coverity-ID: 1381830
> >
> > With that:
> >
> > Reviewed-by: Julien Grall <julien.grall@arm.com>
> >
> > This has been introduced by me in commit 2831f20 "xen/arm: Add support of PSCI
> > v1.0 for the host" in Xen 4.7. I am not sure whether we should backport it.
>
> I think we should backport it.
>
> Wei, can I have a release-ack or do you want to wait until after the
> release?
Please wait until after the release.
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xen/arm: Fix misplaced parentheses for PSCI version check
2016-12-01 2:06 ` Wei Liu
@ 2016-12-03 1:01 ` Stefano Stabellini
0 siblings, 0 replies; 6+ messages in thread
From: Stefano Stabellini @ 2016-12-03 1:01 UTC (permalink / raw)
To: Wei Liu
Cc: Artem Mygaiev, xen-devel@lists.xenproject.org, Julien Grall,
Stefano Stabellini
On Thu, 1 Dec 2016, Wei Liu wrote:
> On Wed, Nov 30, 2016 at 11:16:49AM -0800, Stefano Stabellini wrote:
> > On Wed, 30 Nov 2016, Julien Grall wrote:
> > > Hi Artem,
> > >
> > > On 30/11/16 13:53, Artem Mygaiev wrote:
> > > > Fix misplaced parentheses for PSCI version check
> > > >
> > > > Signed-off-by: Artem Mygaiev <artem_mygaiev@epam.com>
> > >
> > > Can you please include the coverity ID:
> > >
> > > Coverity-ID: 1381830
> > >
> > > With that:
> > >
> > > Reviewed-by: Julien Grall <julien.grall@arm.com>
> > >
> > > This has been introduced by me in commit 2831f20 "xen/arm: Add support of PSCI
> > > v1.0 for the host" in Xen 4.7. I am not sure whether we should backport it.
> >
> > I think we should backport it.
> >
> > Wei, can I have a release-ack or do you want to wait until after the
> > release?
>
> Please wait until after the release.
In the meantime, I applied to xen-arm-next.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] xen/arm: Fix misplaced parentheses for PSCI version check
2016-11-30 15:55 ` Julien Grall
2016-11-30 19:16 ` Stefano Stabellini
@ 2016-12-06 13:57 ` Artem Mygaiev
1 sibling, 0 replies; 6+ messages in thread
From: Artem Mygaiev @ 2016-12-06 13:57 UTC (permalink / raw)
To: Julien Grall, xen-devel@lists.xenproject.org; +Cc: Stefano Stabellini
Thanks, resent
On 30.11.16 17:55, Julien Grall wrote:
> Hi Artem,
>
> On 30/11/16 13:53, Artem Mygaiev wrote:
>> Fix misplaced parentheses for PSCI version check
>>
>> Signed-off-by: Artem Mygaiev <artem_mygaiev@epam.com>
>
> Can you please include the coverity ID:
>
> Coverity-ID: 1381830
>
> With that:
>
> Reviewed-by: Julien Grall <julien.grall@arm.com>
>
> This has been introduced by me in commit 2831f20 "xen/arm: Add support of PSCI v1.0 for the host" in Xen 4.7. I am not sure whether we should backport it.
>
> Cheers,
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-12-06 13:57 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-30 13:53 [PATCH] xen/arm: Fix misplaced parentheses for PSCI version check Artem Mygaiev
2016-11-30 15:55 ` Julien Grall
2016-11-30 19:16 ` Stefano Stabellini
2016-12-01 2:06 ` Wei Liu
2016-12-03 1:01 ` Stefano Stabellini
2016-12-06 13:57 ` Artem Mygaiev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).