From: Wei Liu <wei.liu2@citrix.com>
To: Juergen Gross <jgross@suse.com>
Cc: sstabellini@kernel.org, Wei Liu <wei.liu2@citrix.com>,
George.Dunlap@eu.citrix.com, andrew.cooper3@citrix.com,
ian.jackson@eu.citrix.com, tim@xen.org, jbeulich@suse.com,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v4 12/12] xenstore: handle memory allocation failures in xenstored
Date: Mon, 5 Dec 2016 10:45:45 +0000 [thread overview]
Message-ID: <20161205104545.GF3522@citrix.com> (raw)
In-Reply-To: <20161205101639.GE3522@citrix.com>
On Mon, Dec 05, 2016 at 10:16:39AM +0000, Wei Liu wrote:
> On Mon, Dec 05, 2016 at 11:15:03AM +0100, Juergen Gross wrote:
> > On 05/12/16 11:03, Wei Liu wrote:
> > > On Mon, Dec 05, 2016 at 08:48:53AM +0100, Juergen Gross wrote:
> > >> Check for failures when allocating new memory in xenstored.
> > >>
> > >> Signed-off-by: Juergen Gross <jgross@suse.com>
> > >
> > > I acked v3 of this patch already.
> > >
> > > Assuming only the stale paragraph in commit message is deleted:
> >
> > Hmm, nearly. Did you miss:
> >
> > V4: add alloc failure check in delete_node() and add_change_node()
> > clean_store() only if no failure in check_store_()
>
> Urgh, -ENOCOFFEE and jetlag!
>
> >
> > > Acked-by: Wei Liu <wei.liu2@citrix.com>
> >
> > Does this still stand then?
> >
>
> I will have a look later. Sorry!
After a second look:
Acked-by: Wei Liu <wei.liu2@citrix.com>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-12-05 10:45 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-05 7:48 [PATCH v4 00/12] xenstore: support reading directory with many children Juergen Gross
2016-12-05 7:48 ` [PATCH v4 01/12] xenstore: modify add_change_node() parameter types Juergen Gross
2016-12-05 7:48 ` [PATCH v4 02/12] xenstore: call add_change_node() directly when writing node Juergen Gross
2016-12-05 10:01 ` Wei Liu
2016-12-05 7:48 ` [PATCH v4 03/12] xenstore: use common tdb record header in xenstore Juergen Gross
2016-12-05 7:48 ` [PATCH v4 04/12] xenstore: add per-node generation counter Juergen Gross
2017-01-09 14:38 ` Jan Beulich
[not found] ` <5873AE81020000780012E350@suse.com>
2017-01-09 16:02 ` Juergen Gross
2017-01-09 16:10 ` Jan Beulich
[not found] ` <5873C3ED020000780012E4D5@suse.com>
2017-01-09 16:20 ` Juergen Gross
2016-12-05 7:48 ` [PATCH v4 05/12] xenstore: add support for reading directory with many children Juergen Gross
2017-01-09 16:40 ` Ian Jackson
2017-01-09 18:01 ` Juergen Gross
2016-12-05 7:48 ` [PATCH v4 06/12] xenstore: support XS_DIRECTORY_PART in libxenstore Juergen Gross
2016-12-05 7:48 ` [PATCH v4 07/12] xenstore: use array for xenstore wire command handling Juergen Gross
2016-12-05 8:43 ` Jan Beulich
2016-12-05 9:41 ` Wei Liu
2016-12-05 7:48 ` [PATCH v4 08/12] xenstore: let command functions return error or success Juergen Gross
2016-12-05 7:48 ` [PATCH v4 09/12] xenstore: make functions static Juergen Gross
2016-12-05 10:02 ` Wei Liu
2016-12-05 7:48 ` [PATCH v4 10/12] xenstore: add helper functions for wire argument parsing Juergen Gross
2016-12-05 7:48 ` [PATCH v4 11/12] xenstore: add small default data buffer to internal struct Juergen Gross
2016-12-05 7:48 ` [PATCH v4 12/12] xenstore: handle memory allocation failures in xenstored Juergen Gross
2016-12-05 10:03 ` Wei Liu
2016-12-05 10:15 ` Juergen Gross
2016-12-05 10:16 ` Wei Liu
2016-12-05 10:45 ` Wei Liu [this message]
2016-12-05 12:05 ` [PATCH v4 00/12] xenstore: support reading directory with many children Wei Liu
2016-12-05 18:19 ` Andrew Cooper
2016-12-06 6:30 ` Juergen Gross
2016-12-06 11:25 ` Andrew Cooper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161205104545.GF3522@citrix.com \
--to=wei.liu2@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=jbeulich@suse.com \
--cc=jgross@suse.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).