From: Wei Liu <wei.liu2@citrix.com>
To: "Cédric Bosdonnat" <cbosdonnat@suse.com>
Cc: Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH] libxl: QED disks support
Date: Wed, 7 Dec 2016 11:25:51 +0000 [thread overview]
Message-ID: <20161207112551.GC28069@citrix.com> (raw)
In-Reply-To: <20161114145700.8975-1-cbosdonnat@suse.com>
On Mon, Nov 14, 2016 at 03:57:00PM +0100, Cédric Bosdonnat wrote:
> Qdisk supports qcow and qcow2, extend it to also support qed disk
> format.
>
> Signed-off-by: Cédric Bosdonnat <cbosdonnat@suse.com>
> ---
> tools/libxl/libxl_device.c | 1 +
> tools/libxl/libxl_dm.c | 1 +
> tools/libxl/libxl_types.idl | 1 +
> tools/libxl/libxl_utils.c | 2 +
> tools/libxl/libxlu_disk_l.c | 1018 ++++++++++++++++++++++---------------------
> tools/libxl/libxlu_disk_l.h | 53 +--
> tools/libxl/libxlu_disk_l.l | 3 +-
You would also need to patch docs/misc/xl-disk-configuration.txt and
possibly xl manpage.
You would also need to add a LIBXL_HAVE macro in libxl.h -- there are
quite a lot of examples there.
Other than the things mentioned above, most code changes look rather
mechanical to me.
But what is not very satisfying (not your fault) is that we seem to need
to add every single disk format we want to support by hand. That's
rather repetitive. I wonder if there should be some sort of notation in
libxl for "all formats that QEMU supports".
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-12-07 11:25 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-14 14:57 [PATCH] libxl: QED disks support Cédric Bosdonnat
2016-12-06 14:41 ` Cedric Bosdonnat
2016-12-06 15:42 ` Wei Liu
2016-12-07 11:25 ` Wei Liu [this message]
2016-12-07 13:04 ` Cedric Bosdonnat
2016-12-08 9:28 ` Wei Liu
2016-12-08 9:34 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161207112551.GC28069@citrix.com \
--to=wei.liu2@citrix.com \
--cc=cbosdonnat@suse.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).