From: Wei Liu <wei.liu2@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Wei Liu <wei.liu2@citrix.com>,
George Dunlap <George.Dunlap@eu.citrix.com>,
Andrew Cooper <andrew.cooper3@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
George Dunlap <george.dunlap@citrix.com>,
Tim Deegan <tim@xen.org>,
Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH VERY RFC 3/5] tools/fuzz: introduce x86 instruction emulator target
Date: Thu, 8 Dec 2016 17:25:28 +0000 [thread overview]
Message-ID: <20161208172528.GE2940@citrix.com> (raw)
In-Reply-To: <584984380200007800126D83@prv-mh.provo.novell.com>
On Thu, Dec 08, 2016 at 08:03:04AM -0700, Jan Beulich wrote:
[...]
>
> > +static int emul_read_cr(
> > + unsigned int reg,
> > + unsigned long *val,
> > + struct x86_emulate_ctxt *ctxt)
> > +{
> > + /* Fake just enough state for the emulator's _get_fpu() to be happy. */
> > + switch ( reg )
> > + {
> > + case 0:
> > + *val = 0x00000001; /* PE */
> > + return X86EMUL_OKAY;
> > +
> > + case 4:
> > + /* OSFXSR, OSXMMEXCPT, and maybe OSXSAVE */
> > + *val = 0x00000600 | (cpu_has_xsave ? 0x00040000 : 0);
> > + return X86EMUL_OKAY;
> > + }
> > +
> > + return X86EMUL_UNHANDLEABLE;
> > +}
>
> Looks suspiciously similar to existing code. We may want to share
> such stuff, to avoid having to update it in multiple places.
>
Share with what? Do you mean the real emulator code?
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-12-08 17:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-08 13:54 [PATCH VERY RFC 0/5] Fuzzing targets for oss-fuzz Wei Liu
2016-12-08 13:54 ` [PATCH VERY RFC 1/5] libelf: don't always include libxc headers Wei Liu
2016-12-08 14:44 ` Jan Beulich
2016-12-08 13:54 ` [PATCH VERY RFC 2/5] tools/fuzz: introduce libelf target Wei Liu
2016-12-08 14:47 ` Jan Beulich
2016-12-08 14:49 ` Wei Liu
2016-12-08 13:54 ` [PATCH VERY RFC 3/5] tools/fuzz: introduce x86 instruction emulator target Wei Liu
2016-12-08 15:03 ` Jan Beulich
2016-12-08 15:15 ` Wei Liu
2016-12-08 17:25 ` Wei Liu [this message]
2016-12-09 8:05 ` Jan Beulich
2016-12-09 10:51 ` Wei Liu
2016-12-08 17:57 ` Wei Liu
2016-12-09 8:09 ` Jan Beulich
2016-12-09 10:30 ` Wei Liu
2016-12-08 13:54 ` [PATCH VERY RFC 4/5] tools: hook up fuzz directory Wei Liu
2016-12-08 13:54 ` [PATCH VERY RFC 5/5] tools/fuzz: add README Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161208172528.GE2940@citrix.com \
--to=wei.liu2@citrix.com \
--cc=George.Dunlap@eu.citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=george.dunlap@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=sstabellini@kernel.org \
--cc=tim@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).