xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Tim Deegan <tim@xen.org>
To: Andrew Cooper <andrew.cooper3@citrix.com>
Cc: George Dunlap <george.dunlap@eu.citrix.com>,
	Jan Beulich <JBeulich@suse.com>,
	Xen-devel <xen-devel@lists.xen.org>
Subject: Re: [PATCH 3/5] x86/paging: Enforce PG_external == PG_translate == PG_refcounts
Date: Mon, 12 Dec 2016 11:43:59 +0000	[thread overview]
Message-ID: <20161212114359.GC83447@deinos.phlegethon.org> (raw)
In-Reply-To: <1481539425-9239-4-git-send-email-andrew.cooper3@citrix.com>

At 10:43 +0000 on 12 Dec (1481539423), Andrew Cooper wrote:
> Setting PG_refcounts but not PG_translate is not useful.
> 
> While adjusting this, make a few other improvements.
> 
>  * Have paging_enable() unilaterally reject any unknown modes.
>  * Correct the function description.  paging_enable() is also used to enable
>    logdirty during runtime.

Don't run-time log-dirty changes go through paging_log_dirty_{en,dis}able()?

Apart from that, Acked-by: Tim Deegan <tim@xen.org>.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2016-12-12 11:43 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-12 10:43 [PATCH 0/5] x86: Remove vestigal PV Autotranslate pieces Andrew Cooper
2016-12-12 10:43 ` [PATCH 1/5] x86/traps: Drop paging_mode_external() handling from the PV pagefault path Andrew Cooper
2016-12-12 11:19   ` Jan Beulich
2016-12-12 11:27   ` Tim Deegan
2016-12-12 11:45     ` Andrew Cooper
2016-12-12 11:57       ` Tim Deegan
2016-12-12 13:05         ` Andrew Cooper
2016-12-12 14:53           ` Tim Deegan
2016-12-12 10:43 ` [PATCH 2/5] x86/shadow: Tweak some initialisation in sh_page_fault() Andrew Cooper
2016-12-12 11:21   ` Jan Beulich
2016-12-12 11:31   ` Tim Deegan
2016-12-12 10:43 ` [PATCH 3/5] x86/paging: Enforce PG_external == PG_translate == PG_refcounts Andrew Cooper
2016-12-12 11:43   ` Tim Deegan [this message]
2016-12-12 11:59     ` Andrew Cooper
2016-12-12 12:48       ` Jan Beulich
2016-12-12 10:43 ` [PATCH 4/5] x86/shadow: Drop all emulation for PV vcpus Andrew Cooper
2016-12-12 11:47   ` Tim Deegan
2016-12-12 10:43 ` [PATCH 5/5] x86/shadow: Misc minor cleanup Andrew Cooper
2016-12-12 11:49   ` Tim Deegan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161212114359.GC83447@deinos.phlegethon.org \
    --to=tim@xen.org \
    --cc=JBeulich@suse.com \
    --cc=andrew.cooper3@citrix.com \
    --cc=george.dunlap@eu.citrix.com \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).