xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
* [OSSTEST PATCH v8 0/3] Have OpenStack tested on top of xen's master and libvirt's master.
@ 2016-11-24 18:14 Anthony PERARD
  2016-11-24 18:14 ` [OSSTEST PATCH v8 1/3] ts-openstack-deploy: Deploy OpenStack on a host with devstack Anthony PERARD
                   ` (4 more replies)
  0 siblings, 5 replies; 9+ messages in thread
From: Anthony PERARD @ 2016-11-24 18:14 UTC (permalink / raw)
  To: xen-devel; +Cc: Anthony PERARD, Ian Jackson

Hi,

I have looked into getting OpenStack been tested on the latest Xen via
osstest.

The ts-openstack-deploy script does prepare a bit more the host, clone
devstack and other OpenStack trees, then run ./stack.sh, which is a bit
like raisin and deploy OpenStack on the host. Once the machine is ready,
the integration test suite from OpenStack, Tempest, is started by
ts-openstack-tempest.

Thanks.

Changes in V8:
  - few coding style fixes
  - fix flight generation

Changes in V7:
  - few changes detailed in patches

Changes in V6:
  - rebased
  - fix ts-openstack-deploy script to work with newer devstach and new debian.

Change in V5:
  - on small change in patch 1, but I keeped the acked-by
  - few changes in the way the flight is created (in the last patch)

Change in V4:
  few changes listed in second and third patch, mostly cleanup.

Change in V3:
  - Track Nova tree instead of devstack.
      Nova is the service we care about from a Xen point of view.
      Also it is updated much more often than devstack.
  - Cleanups, see change log in patches.

Changes in V2:
  - no more Osstest::Toolstack::OpenStack.
  - osstest now clone every single tree that devstack is going to need.
    And ./stack.sh should fail if one tree is missing.
  - avoid build-*-xsm for an openstack flight
  - rename ts-devstack to ts-openstack-devstack
  - New test script ts-openstack-tempest
  - Add CONFIG_CRYPTO_XTS=m to the kernel build.
  - new possible runvar $dom0_mem to control dom0 memory
  - several fix to have volume tests working.
  - have OpenStack deploy from it's builddir instead of /opt/stack
  - have 4GB for dom0 instead of relying on balloning.

Run of AP_FETCH_PLACEHOLDERS=y ./standalone-generate-dump-flight-runvars on
master (5d88d6299618f6bce204d82579392a76028fb8cd) vs this patch series:

--- master ./standalone-generate-dump-flight-runvars
+++ openstack-patch-v8 ./standalone-generate-dump-flight-runvars
@@ -7742,6 +7742,118 @@
 linux-arm-xen              test-armhf-armhf-xl-rtds       xenbuildjob             build-armhf
 linux-arm-xen              test-armhf-armhf-xl-vhd        xenbuildjob             build-armhf
 linux-arm-xen              test-armhf-armhf-xl-xsm        xenbuildjob             build-armhf-xsm
+openstack-nova             build-amd64                   all_host_di_version     current
+openstack-nova             build-amd64-libvirt           all_host_di_version     current
+openstack-nova             build-amd64-pvops             all_host_di_version     current
+openstack-nova             build-amd64-xsm               all_host_di_version     current
+openstack-nova             test-amd64-amd64-devstack     all_host_di_version     current
+openstack-nova             test-amd64-amd64-devstack-xsm all_host_di_version     current
+openstack-nova             build-amd64                   all_host_suite          jessie
+openstack-nova             build-amd64-libvirt           all_host_suite          jessie
+openstack-nova             build-amd64-pvops             all_host_suite          jessie
+openstack-nova             build-amd64-xsm               all_host_suite          jessie
+openstack-nova             test-amd64-amd64-devstack     all_host_suite          jessie
+openstack-nova             test-amd64-amd64-devstack-xsm all_host_suite          jessie
+openstack-nova             test-amd64-amd64-devstack     all_hostflags           arch-amd64,arch-xen-amd64,suite-jessie,purpose-test
+openstack-nova             test-amd64-amd64-devstack-xsm all_hostflags           arch-amd64,arch-xen-amd64,suite-jessie,purpose-test
+openstack-nova             build-amd64                   arch                    amd64
+openstack-nova             build-amd64-libvirt           arch                    amd64
+openstack-nova             build-amd64-pvops             arch                    amd64
+openstack-nova             build-amd64-xsm               arch                    amd64
+openstack-nova             test-amd64-amd64-devstack     arch                    amd64
+openstack-nova             test-amd64-amd64-devstack-xsm arch                    amd64
+openstack-nova             build-amd64                   build_lvextend_max      50
+openstack-nova             build-amd64-libvirt           build_lvextend_max      50
+openstack-nova             build-amd64-pvops             build_lvextend_max      50
+openstack-nova             build-amd64-xsm               build_lvextend_max      50
+openstack-nova             build-amd64-libvirt           buildjob                build-amd64
+openstack-nova             test-amd64-amd64-devstack     buildjob                build-amd64
+openstack-nova             test-amd64-amd64-devstack-xsm buildjob                build-amd64-xsm
+openstack-nova             test-amd64-amd64-devstack     dom0_mem                4000
+openstack-nova             test-amd64-amd64-devstack-xsm dom0_mem                4000
+openstack-nova             build-amd64                   enable_ovmf             true
+openstack-nova             build-amd64-xsm               enable_ovmf             true
+openstack-nova             build-amd64                   enable_xend             false
+openstack-nova             build-amd64-xsm               enable_xend             false
+openstack-nova             build-amd64                   enable_xsm              false
+openstack-nova             build-amd64-xsm               enable_xsm              true
+openstack-nova             test-amd64-amd64-devstack     enable_xsm              false
+openstack-nova             test-amd64-amd64-devstack-xsm enable_xsm              true
+openstack-nova             build-amd64                   host_hostflags          share-build-jessie-amd64,arch-amd64,suite-jessie,purpose-build
+openstack-nova             build-amd64-libvirt           host_hostflags          share-build-jessie-amd64,arch-amd64,suite-jessie,purpose-build
+openstack-nova             build-amd64-pvops             host_hostflags          share-build-jessie-amd64,arch-amd64,suite-jessie,purpose-build
+openstack-nova             build-amd64-xsm               host_hostflags          share-build-jessie-amd64,arch-amd64,suite-jessie,purpose-build
+openstack-nova             build-amd64-pvops             kconfighow              xen-enable-xen-config
+openstack-nova             test-amd64-amd64-devstack     kernbuildjob            build-amd64-pvops
+openstack-nova             test-amd64-amd64-devstack-xsm kernbuildjob            build-amd64-pvops
+openstack-nova             test-amd64-amd64-devstack     kernkind                pvops
+openstack-nova             test-amd64-amd64-devstack-xsm kernkind                pvops
+openstack-nova             test-amd64-amd64-devstack     libvirtbuildjob         build-amd64-libvirt
+openstack-nova             test-amd64-amd64-devstack-xsm libvirtbuildjob         build-amd64-libvirt
+openstack-nova             test-amd64-amd64-devstack     revision_cinder
+openstack-nova             test-amd64-amd64-devstack-xsm revision_cinder
+openstack-nova             test-amd64-amd64-devstack     revision_devstack
+openstack-nova             test-amd64-amd64-devstack-xsm revision_devstack
+openstack-nova             test-amd64-amd64-devstack     revision_glance
+openstack-nova             test-amd64-amd64-devstack-xsm revision_glance
+openstack-nova             test-amd64-amd64-devstack     revision_keystone
+openstack-nova             test-amd64-amd64-devstack-xsm revision_keystone
+openstack-nova             build-amd64-libvirt           revision_libvirt        ap-fetch-version-baseline:libvirt
+openstack-nova             build-amd64-pvops             revision_linux          ap-fetch-version-baseline:linux
+openstack-nova             build-amd64-pvops             revision_linuxfirmware  ap-fetch-version-baseline:linuxfirmware
+openstack-nova             build-amd64                   revision_minios
+openstack-nova             build-amd64-xsm               revision_minios
+openstack-nova             test-amd64-amd64-devstack     revision_nova           ap-fetch-version:openstack-nova
+openstack-nova             test-amd64-amd64-devstack-xsm revision_nova           ap-fetch-version:openstack-nova
+openstack-nova             build-amd64                   revision_ovmf
+openstack-nova             build-amd64-xsm               revision_ovmf
+openstack-nova             build-amd64                   revision_qemu
+openstack-nova             build-amd64-xsm               revision_qemu
+openstack-nova             build-amd64                   revision_qemuu          ap-fetch-version-baseline:qemu-upstream-unstable
+openstack-nova             build-amd64-xsm               revision_qemuu          ap-fetch-version-baseline:qemu-upstream-unstable
+openstack-nova             test-amd64-amd64-devstack     revision_requirements
+openstack-nova             test-amd64-amd64-devstack-xsm revision_requirements
+openstack-nova             build-amd64                   revision_seabios
+openstack-nova             build-amd64-xsm               revision_seabios
+openstack-nova             test-amd64-amd64-devstack     revision_tempest
+openstack-nova             test-amd64-amd64-devstack-xsm revision_tempest
+openstack-nova             build-amd64                   revision_xen            ap-fetch-version-baseline:xen-unstable
+openstack-nova             build-amd64-xsm               revision_xen            ap-fetch-version-baseline:xen-unstable
+openstack-nova             test-amd64-amd64-devstack     toolstack               libvirt
+openstack-nova             test-amd64-amd64-devstack-xsm toolstack               libvirt
+openstack-nova             test-amd64-amd64-devstack     tree_cinder             git://git.openstack.org/openstack/cinder.git
+openstack-nova             test-amd64-amd64-devstack-xsm tree_cinder             git://git.openstack.org/openstack/cinder.git
+openstack-nova             test-amd64-amd64-devstack     tree_devstack           git://git.openstack.org/openstack-dev/devstack.git
+openstack-nova             test-amd64-amd64-devstack-xsm tree_devstack           git://git.openstack.org/openstack-dev/devstack.git
+openstack-nova             test-amd64-amd64-devstack     tree_glance             git://git.openstack.org/openstack/glance.git
+openstack-nova             test-amd64-amd64-devstack-xsm tree_glance             git://git.openstack.org/openstack/glance.git
+openstack-nova             test-amd64-amd64-devstack     tree_keystone           git://git.openstack.org/openstack/keystone.git
+openstack-nova             test-amd64-amd64-devstack-xsm tree_keystone           git://git.openstack.org/openstack/keystone.git
+openstack-nova             build-amd64-libvirt           tree_libvirt            git://xenbits.xen.org/libvirt.git
+openstack-nova             build-amd64-pvops             tree_linux              git://xenbits.xen.org/linux-pvops.git
+openstack-nova             build-amd64-pvops             tree_linuxfirmware      git://xenbits.xen.org/osstest/linux-firmware.git
+openstack-nova             build-amd64                   tree_minios
+openstack-nova             build-amd64-xsm               tree_minios
+openstack-nova             test-amd64-amd64-devstack     tree_nova               git://git.openstack.org/openstack/nova.git
+openstack-nova             test-amd64-amd64-devstack-xsm tree_nova               git://git.openstack.org/openstack/nova.git
+openstack-nova             build-amd64                   tree_ovmf
+openstack-nova             build-amd64-xsm               tree_ovmf
+openstack-nova             build-amd64                   tree_qemu               git://xenbits.xen.org/qemu-xen-traditional.git
+openstack-nova             build-amd64-xsm               tree_qemu               git://xenbits.xen.org/qemu-xen-traditional.git
+openstack-nova             build-amd64                   tree_qemuu              git://xenbits.xen.org/qemu-xen.git
+openstack-nova             build-amd64-xsm               tree_qemuu              git://xenbits.xen.org/qemu-xen.git
+openstack-nova             test-amd64-amd64-devstack     tree_requirements       git://git.openstack.org/openstack/requirements.git
+openstack-nova             test-amd64-amd64-devstack-xsm tree_requirements       git://git.openstack.org/openstack/requirements.git
+openstack-nova             build-amd64                   tree_seabios
+openstack-nova             build-amd64-xsm               tree_seabios
+openstack-nova             test-amd64-amd64-devstack     tree_tempest            git://git.openstack.org/openstack/tempest.git
+openstack-nova             test-amd64-amd64-devstack-xsm tree_tempest            git://git.openstack.org/openstack/tempest.git
+openstack-nova             build-amd64                   tree_xen                git://xenbits.xen.org/xen.git
+openstack-nova             build-amd64-libvirt           tree_xen                git://xenbits.xen.org/xen.git
+openstack-nova             build-amd64-xsm               tree_xen                git://xenbits.xen.org/xen.git
+openstack-nova             build-amd64-pvops             treevcs_linux           git
+openstack-nova             test-amd64-amd64-devstack     xenbuildjob             build-amd64
+openstack-nova             test-amd64-amd64-devstack-xsm xenbuildjob             build-amd64-xsm
 osstest                    build-amd64                                           all_host_di_version     current
 osstest                    build-amd64-libvirt                                   all_host_di_version     current
 osstest                    build-amd64-pvops                                     all_host_di_version     current

Anthony PERARD (3):
  ts-openstack-deploy: Deploy OpenStack on a host with devstack
  ts-openstack-tempest: Run Tempest to check OpenStack
  Create a flight to test OpenStack with xen-unstable and libvirt

 ap-common            |  18 +++++++
 ap-fetch-version     |   4 ++
 ap-fetch-version-old |   5 ++
 ap-print-url         |   3 ++
 ap-push              |   5 ++
 cr-daily-branch      |   8 +++
 cr-for-branches      |   2 +-
 cri-common           |   1 +
 make-flight          |  51 ++++++++++++++++++-
 sg-run-job           |   6 +++
 ts-openstack-deploy  | 137 +++++++++++++++++++++++++++++++++++++++++++++++++++
 ts-openstack-tempest |  64 ++++++++++++++++++++++++
 12 files changed, 302 insertions(+), 2 deletions(-)
 create mode 100755 ts-openstack-deploy
 create mode 100755 ts-openstack-tempest

-- 
Anthony PERARD


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* [OSSTEST PATCH v8 1/3] ts-openstack-deploy: Deploy OpenStack on a host with devstack
  2016-11-24 18:14 [OSSTEST PATCH v8 0/3] Have OpenStack tested on top of xen's master and libvirt's master Anthony PERARD
@ 2016-11-24 18:14 ` Anthony PERARD
  2016-12-12 16:35   ` Ian Jackson
  2016-11-24 18:14 ` [OSSTEST PATCH v8 2/3] ts-openstack-tempest: Run Tempest to check OpenStack Anthony PERARD
                   ` (3 subsequent siblings)
  4 siblings, 1 reply; 9+ messages in thread
From: Anthony PERARD @ 2016-11-24 18:14 UTC (permalink / raw)
  To: xen-devel; +Cc: Anthony PERARD, Ian Jackson

This script installs any necessary packages and clones all of the OpenStack
trees which are used by devstack to deploy OpenStack.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

---
Changes in V8:
- fix job name in sg-run-job
- fix copyright year
- fix too long lines

Changes in V7:
- reindent
- fix style
- remove many workaround, there are not needed anymore.
- create bug report upstream

Changes in V6:
- rebased
- fix issues due to new debian and newer devstack:
  - add missing libvirt group
  - switch back to old nova-network instead of neutron
  - have devstack use 'service' instead of 'systemctl' to restart
    services

Only change in V5:
- edit stackrc from devstack file to change the hardcoded path DEST

No change in V4:
- acked

Change in V3:
- Use host as argument to run the job.
- Use selectjob() and get rid of the unused $gho.
- Use target_jobdir() instead of builddirsprops().
- Remove GIT_BASE from devstack config.
- Rename the script to ts-openstack-deploy (from ts-openstack-devstack).
---
 sg-run-job          |   5 ++
 ts-openstack-deploy | 137 ++++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 142 insertions(+)
 create mode 100755 ts-openstack-deploy

diff --git a/sg-run-job b/sg-run-job
index 9c3e0ce..0d65c8a 100755
--- a/sg-run-job
+++ b/sg-run-job
@@ -474,6 +474,11 @@ proc run-job/test-rumprun {} {
                  ts-guest-destroy-hard        host   $g   +
 }
 
+proc need-hosts/test-devstack {} { return host }
+proc run-job/test-devstack {} {
+    run-ts . = ts-openstack-deploy + host
+}
+
 if {[file exists sg-run-job-adhoc]} {
     source sg-run-job-adhoc
 }
diff --git a/ts-openstack-deploy b/ts-openstack-deploy
new file mode 100755
index 0000000..36d7866
--- /dev/null
+++ b/ts-openstack-deploy
@@ -0,0 +1,137 @@
+#!/usr/bin/perl
+# This is part of "osstest", an automated testing framework for Xen.
+# Copyright (C) 2016 Citrix Inc.
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU Affero General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+use strict qw(vars);
+use Osstest;
+use Osstest::TestSupport;
+use Osstest::BuildSupport;
+
+tsreadconfig();
+our ($whhost) = @ARGV;
+$whhost ||= 'host';
+our $ho = selecthost($whhost);
+our $builddir = target_jobdir($ho);
+
+sub packages () {
+    target_install_packages($ho, qw(git sudo));
+}
+sub checkout () {
+    prepbuilddirs();
+    build_clone($ho, 'cinder',       $builddir, 'cinder');
+    build_clone($ho, 'devstack',     $builddir, 'devstack');
+    build_clone($ho, 'glance',       $builddir, 'glance');
+    build_clone($ho, 'keystone',     $builddir, 'keystone');
+    build_clone($ho, 'nova',         $builddir, 'nova');
+    build_clone($ho, 'requirements', $builddir, 'requirements');
+    build_clone($ho, 'tempest',      $builddir, 'tempest');
+
+    my $vg = target_choose_vg($ho, 10*1024); # 10GB
+    target_putfilecontents_stash($ho, 60,
+        <<END, $builddir.'/devstack/local.conf');
+[[local|localrc]]
+# Everything should be cloned by osstest, so devstack don't have to do it
+ERROR_ON_CLONE=True
+USE_SCREEN=False
+ADMIN_PASSWORD=secretadmin
+DATABASE_PASSWORD=secretdatabase
+RABBIT_PASSWORD=secretrabbit
+SERVICE_PASSWORD=secretservice
+SERVICE_TOKEN=atokenserviced
+# make it small because there is no way to not have this lvm volume created
+VOLUME_BACKING_FILE_SIZE=50M
+CINDER_LVM_TYPE=default
+DEST=$builddir
+DATA_DIR=\$DEST/data
+SERVICE_DIR=\$DEST/status
+SUBUNIT_OUTPUT=\$DEST/devstack.subunit
+LOGFILE=\$DEST/logs/stack.sh.log
+LOG_COLOR=False
+LIBVIRT_TYPE=xen
+disable_service horizon
+disable_service n-novnc
+disable_service dstat
+enable_service n-obj
+# Disable neutron and switch back to nova-network
+disable_service q-svc
+disable_service q-dhcp
+disable_service q-meta
+disable_service q-agt
+disable_service q-l3
+enable_service n-net
+[[post-config|\$CINDER_CONF]]
+[lvmdriver-1]
+volume_group = $vg
+END
+
+    # libvirt is already installed, but not as a package, so avoid installation
+    # of the libvirt package with devstack
+    # https://bugs.launchpad.net/devstack/+bug/1641144
+    target_editfile($ho, "$builddir/devstack/files/debs/nova", sub {
+        while (<EI>) {
+            next if m/.*libvirt.*/;
+            print EO or die $!;
+        }
+    });
+    target_editfile($ho,
+        "$builddir/devstack/lib/nova_plugins/functions-libvirt",
+        sub {
+            while (<EI>) {
+                next if m/install_package.*libvirt.*/;
+                print EO or die $!;
+            }
+        }
+    );
+
+    # devstack blindly assume that systemd is used if systemctl is present
+    # https://bugs.launchpad.net/devstack/+bug/1641112
+    target_editfile($ho, "$builddir/devstack/functions-common", sub {
+        while (<EI>) {
+            if (m#\[ -x /bin/systemctl#) {
+                s#\[ -x /bin/systemctl \]#false#
+            }
+            print EO or die $!;
+        }
+    });
+
+    # OpenStack needs access to libvirt from a user.
+    target_cmd_root($ho, <<END);
+        addgroup --system libvirt
+        cat >> /etc/libvirt/libvirtd.conf <<EOF
+unix_sock_group = "libvirt"
+unix_sock_ro_perms = "0777"
+unix_sock_rw_perms = "0770"
+EOF
+        service libvirtd restart
+END
+
+    # devstack is going to setup the host, install some dependency.
+    target_putfilecontents_root_stash($ho, 100,
+        <<END, "/etc/sudoers.d/devstack");
+osstest ALL=(ALL) NOPASSWD:ALL
+END
+}
+
+sub deploy() {
+    target_cmd($ho, <<END, 1800);
+        cd $builddir/devstack
+        ./stack.sh
+END
+}
+
+packages();
+checkout();
+deploy();
-- 
Anthony PERARD


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [OSSTEST PATCH v8 2/3] ts-openstack-tempest: Run Tempest to check OpenStack
  2016-11-24 18:14 [OSSTEST PATCH v8 0/3] Have OpenStack tested on top of xen's master and libvirt's master Anthony PERARD
  2016-11-24 18:14 ` [OSSTEST PATCH v8 1/3] ts-openstack-deploy: Deploy OpenStack on a host with devstack Anthony PERARD
@ 2016-11-24 18:14 ` Anthony PERARD
  2016-11-24 18:14 ` [OSSTEST PATCH v8 3/3] Create a flight to test OpenStack with xen-unstable and libvirt Anthony PERARD
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 9+ messages in thread
From: Anthony PERARD @ 2016-11-24 18:14 UTC (permalink / raw)
  To: xen-devel; +Cc: Anthony PERARD, Ian Jackson

This script runs the OpenStack integration test suite, Tempest.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
Acked-by: Ian Campbell <ian.campbell@citrix.com>
Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

---
Changes in V8:
- fix copyright year
- fix job name in sg-run-job
- fix too long lines

Changes in V7:
- reindent
- acked

No change in V5

Change in V4:
- use \Q\E for tests names
- write the full name of the tests to skip
- use push @ignored_test then join()
- use variables to store common prefix
- rewrite comments

Change in V3:
- Use host as argument of the script.
- Use selecthost() and get rid of $gho.
- Use target_jobdir() instead of builddirsprops().
- Put the ignored Tempest tests into a var and try to explain why there are
  skip.
---
 sg-run-job           |  1 +
 ts-openstack-tempest | 64 ++++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 65 insertions(+)
 create mode 100755 ts-openstack-tempest

diff --git a/sg-run-job b/sg-run-job
index 0d65c8a..13011c0 100755
--- a/sg-run-job
+++ b/sg-run-job
@@ -477,6 +477,7 @@ proc run-job/test-rumprun {} {
 proc need-hosts/test-devstack {} { return host }
 proc run-job/test-devstack {} {
     run-ts . = ts-openstack-deploy + host
+    run-ts . = ts-openstack-tempest + host
 }
 
 if {[file exists sg-run-job-adhoc]} {
diff --git a/ts-openstack-tempest b/ts-openstack-tempest
new file mode 100755
index 0000000..b51eaf1
--- /dev/null
+++ b/ts-openstack-tempest
@@ -0,0 +1,64 @@
+#!/usr/bin/perl
+# This is part of "osstest", an automated testing framework for Xen.
+# Copyright (C) 2016 Citrix Inc.
+#
+# This program is free software: you can redistribute it and/or modify
+# it under the terms of the GNU Affero General Public License as published by
+# the Free Software Foundation, either version 3 of the License, or
+# (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU Affero General Public License for more details.
+#
+# You should have received a copy of the GNU Affero General Public License
+# along with this program.  If not, see <http://www.gnu.org/licenses/>.
+
+use strict qw(vars);
+use Osstest;
+use Osstest::TestSupport;
+use Osstest::BuildSupport;
+
+tsreadconfig();
+our ($whhost) = @ARGV;
+$whhost ||= 'host';
+our $ho = selecthost($whhost);
+our $builddir = target_jobdir($ho);
+
+sub tempest() {
+    my @ignored_tests;
+    my $scenario = 'tempest.scenario';
+    my $volume_boot_pattern =
+        "$scenario.test_volume_boot_pattern.TestVolumeBootPattern";
+    my $shelve_instance = "$scenario.test_shelve_instance.TestShelveInstance";
+
+    # Ignore tests which try to boot a guest with /dev/vda as boot device name.
+    push @ignored_tests,
+        "^\Q$volume_boot_pattern.test_volume_boot_pattern\E";
+    push @ignored_tests,
+        "^\Q$volume_boot_pattern.test_create_ebs_image_and_check_boot\E";
+    push @ignored_tests,
+        "^\Q$shelve_instance.test_shelve_volume_backed_instance\E";
+
+    # Those tests access a volume through iSCSI. This does not work when both
+    # the server and client of iSCSI are on the same Xen host (both in dom0),
+    # Linux 4.0 is the first Linux to have a fix.
+    push @ignored_tests,
+        "^\Q${volume_boot_pattern}V2.test_volume_boot_pattern\E";
+    push @ignored_tests,
+        "^\Q${volume_boot_pattern}V2.test_create_ebs_image_and_check_boot\E";
+
+    # This regex below select the tests to run and exclude the ones marked as
+    # slow as well as the explicit tests listed above.  It is based on the one
+    # that can be found in tempest.git/tox.ini in the section [testenv:full].
+    my $ignored_tests = join("|", @ignored_tests);
+    my $regex = "(?!.*\\[.*\\bslow\\b.*\\]|$ignored_tests)".
+        "(^tempest\\.(api|scenario|thirdparty))";
+
+    target_cmd($ho, <<END, 7200);
+$builddir/tempest/run_tempest.sh --virtual-env -- --concurrency=2 '$regex'
+END
+}
+
+tempest();
-- 
Anthony PERARD


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* [OSSTEST PATCH v8 3/3] Create a flight to test OpenStack with xen-unstable and libvirt
  2016-11-24 18:14 [OSSTEST PATCH v8 0/3] Have OpenStack tested on top of xen's master and libvirt's master Anthony PERARD
  2016-11-24 18:14 ` [OSSTEST PATCH v8 1/3] ts-openstack-deploy: Deploy OpenStack on a host with devstack Anthony PERARD
  2016-11-24 18:14 ` [OSSTEST PATCH v8 2/3] ts-openstack-tempest: Run Tempest to check OpenStack Anthony PERARD
@ 2016-11-24 18:14 ` Anthony PERARD
  2016-12-12 12:20 ` [OSSTEST PATCH v8 0/3] Have OpenStack tested on top of xen's master and libvirt's master Anthony PERARD
  2016-12-12 16:51 ` Ian Jackson
  4 siblings, 0 replies; 9+ messages in thread
From: Anthony PERARD @ 2016-11-24 18:14 UTC (permalink / raw)
  To: xen-devel; +Cc: Anthony PERARD, Ian Jackson

This patch should create a flight "openstack-nova", with those jobs:
  build-amd64
  build-amd64-xsm
  build-amd64-pvops
  build-amd64-libvirt
  test-amd64-amd64-devstack
  test-amd64-amd64-devstack-xsm

About the runvars revision_* of test-*-*-devstack:
  only REVISION_OPENSTACK_NOVA is set, the others are unset.
  Empty revision_* runvar would clone the default branch, which should
  be master for every openstack repos.

Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

---
Changes in V8:
- fix shell style
- fix arch_branch_filter_callback
    (linux-arm-xen was not properly filtered anymore for i386)

Changes in V7:
- metaprograming
- reindent

Change in V6:
- rebased

Change in V5:
- rename flight openstack to openstack-nova
- add -xsm variant of the test
- run test-devstack only on openstack-nova flight

Change in V4:
- also skip build-*-oldkern in make flight
- fix select_xenbranch
- set revision_*=$REVISION_OPENSTACK_* in make-flight
  (was revision_*=master before)
  only REVISION_OPENSTACK_NOVA is set, the others are unset.
  empty revision_* runvar would clone the default branch, which should
  be master for every openstack repos

Change in V3:
- Switch to "track" Nova tree instead of devstack.
    Nova is the service we care about from a Xen point of view.
    Also it is updated much more often than devstack.
- Use TREE_OPENSTACK_ as prefix for all trees variables.
- Change the filter, keep only *-devstack jobs.
- Add stuff into ./ap-push
- Add stuff into ./cr-daily-branch.
- Add 'openstack' into ./cr-for-branches.
---
 ap-common            | 18 ++++++++++++++++++
 ap-fetch-version     |  4 ++++
 ap-fetch-version-old |  5 +++++
 ap-print-url         |  3 +++
 ap-push              |  5 +++++
 cr-daily-branch      |  8 ++++++++
 cr-for-branches      |  2 +-
 cri-common           |  1 +
 make-flight          | 51 ++++++++++++++++++++++++++++++++++++++++++++++++++-
 9 files changed, 95 insertions(+), 2 deletions(-)

diff --git a/ap-common b/ap-common
index cbb815c..7e84f15 100644
--- a/ap-common
+++ b/ap-common
@@ -54,6 +54,23 @@
 : ${PUSH_TREE_OVMF:=$XENBITS:/home/xen/git/osstest/ovmf.git}
 : ${BASE_TREE_OVMF:=git://xenbits.xen.org/osstest/ovmf.git}
 
+define_openstack_trees() {
+    local openstack_trees=(cinder glance keystone nova requirements tempest)
+    local tree
+    local url
+
+    : ${GIT_OPENSTACK_ORG:=git://git.openstack.org}
+    : ${TREE_OPENSTACK_DEVSTACK:=$GIT_OPENSTACK_ORG/openstack-dev/devstack.git}
+    for tree in "${openstack_trees[@]}"; do
+        url=$GIT_OPENSTACK_ORG/openstack/$tree.git
+        eval ": \${TREE_OPENSTACK_${tree^^}:=$url}"
+    done
+}
+
+define_openstack_trees
+: ${PUSH_TREE_OPENSTACK_NOVA:=$XENBITS:/home/xen/git/osstest/openstack-nova.git}
+: ${BASE_TREE_OPENSTACK_NOVA:=git://xenbits.xen.org/osstest/openstack-nova.git}
+
 : ${TREE_LINUXFIRMWARE:=git://xenbits.xen.org/osstest/linux-firmware.git}
 : ${PUSH_TREE_LINUXFIRMWARE:=$XENBITS:/home/osstest/ext/linux-firmware.git}
 : ${UPSTREAM_TREE_LINUXFIRMWARE:=$GIT_KERNEL_ORG/pub/scm/linux/kernel/git/firmware/linux-firmware.git}
@@ -82,6 +99,7 @@ fi
 : ${LOCALREV_SEABIOS:=daily-cron.$branch}
 : ${LOCALREV_OVMF:=daily-cron.$branch}
 : ${LOCALREV_XTF:=daily-cron.$branch}
+: ${LOCALREV_OPENSTACK_NOVA:=daily-cron.$branch}
 
 : ${TREEBASE_LINUX_XCP:=http://hg.uk.xensource.com/carbon/trunk/linux-2.6.27}
 
diff --git a/ap-fetch-version b/ap-fetch-version
index a107c93..a714ee2 100755
--- a/ap-fetch-version
+++ b/ap-fetch-version
@@ -106,6 +106,10 @@ ovmf)
 	repo_tree_rev_fetch_git ovmf \
 		$TREE_OVMF_UPSTREAM master $LOCALREV_OVMF
 	;;
+openstack-nova)
+	repo_tree_rev_fetch_git openstack-nova \
+		$TREE_OPENSTACK_NOVA master $LOCALREV_OPENSTACK_NOVA
+	;;
 osstest)
         if [ "x$OSSTEST_USE_HEAD" = "xy" ] ; then
 	    git update-ref -m "Arranging to test HEAD" \
diff --git a/ap-fetch-version-old b/ap-fetch-version-old
index 3cbc176..6dddbb7 100755
--- a/ap-fetch-version-old
+++ b/ap-fetch-version-old
@@ -35,6 +35,7 @@ check_ap_fetch_placeholders
 : ${BASE_LOCALREV_XTF:=daily-cron.$branch.old}
 : ${BASE_LOCALREV_OVMF:=daily-cron.$branch.old}
 : ${BASE_TAG_LIBVIRT:=xen-tested-master}
+: ${BASE_LOCALREV_OPENSTACK_NOVA:=daily-cron.$branch.old}
 
 if info_linux_tree "$branch"; then
 	repo_tree_rev_fetch_git linux \
@@ -114,6 +115,10 @@ ovmf)
 	repo_tree_rev_fetch_git ovmf \
 		$BASE_TREE_OVMF xen-tested-master $BASE_LOCALREV_OVMF
 	;;
+openstack-nova)
+	repo_tree_rev_fetch_git openstack-nova \
+		$BASE_TREE_OPENSTACK_NOVA xen-tested-master $BASE_LOCALREV_OPENSTACK_NOVA
+	;;
 osstest)
 	if [ "x$OSSTEST_USE_HEAD" != "xy" ] ; then
 	    git fetch -f $HOME/testing.git production:ap-fetch
diff --git a/ap-print-url b/ap-print-url
index 93c14b3..6f4e6b1 100755
--- a/ap-print-url
+++ b/ap-print-url
@@ -67,6 +67,9 @@ ovmf)
 osstest)
 	echo none:;
 	;;
+openstack-nova)
+	echo $TREE_OPENSTACK_NOVA
+	;;
 *)
 	echo >&2 "branch $branch ?"
 	exit 1
diff --git a/ap-push b/ap-push
index a27ccc2..136d1b6 100755
--- a/ap-push
+++ b/ap-push
@@ -41,6 +41,7 @@ TREE_RUMPRUN=$PUSH_TREE_RUMPRUN
 TREE_SEABIOS=$PUSH_TREE_SEABIOS
 TREE_OVMF=$PUSH_TREE_OVMF
 TREE_XTF=$PUSH_TREE_XTF
+TREE_OPENSTACK_NOVA=$PUSH_TREE_OPENSTACK_NOVA
 
 if info_linux_tree "$branch"; then
 	cd $repos/linux
@@ -129,6 +130,10 @@ ovmf)
 	cd $repos/ovmf
 	git push $TREE_OVMF $revision:refs/heads/xen-tested-master
 	;;
+openstack-nova)
+	cd $repos/openstack-nova
+	git push $TREE_OPENSTACK_NOVA $revision:refs/heads/xen-tested-master
+	;;
 osstest)
 	git push $HOME/testing.git $revision:production
 	if [ x"$TREEBRANCH_OSSTEST_UPSTREAM" != x ] ; then
diff --git a/cr-daily-branch b/cr-daily-branch
index 158554d..45a2f69 100755
--- a/cr-daily-branch
+++ b/cr-daily-branch
@@ -207,6 +207,10 @@ if [ "x$REVISION_LINUXFIRMWARE" = x ]; then
 	determine_version REVISION_LINUXFIRMWARE linuxfirmware LINUXFIRMWARE
         export REVISION_LINUXFIRMWARE
 fi
+if [ "x$REVISION_OPENSTACK_NOVA" = x ]; then
+        determine_version REVISION_OPENSTACK_NOVA openstack-nova OPENSTACK_NOVA
+        export REVISION_OPENSTACK_NOVA
+fi
 
 if [ "x$branch" != "xxen-unstable" ]; then
         export REVISION_LINUX_OLD=disable
@@ -260,6 +264,10 @@ ovmf)
 	realtree=ovmf
 	NEW_REVISION=$REVISION_OVMF
 	;;
+openstack-nova)
+	realtree=openstack-nova
+	NEW_REVISION=$REVISION_OPENSTACK_NOVA
+	;;
 *)
 	NEW_REVISION=''
 	wantpush=false
diff --git a/cr-for-branches b/cr-for-branches
index 5e8b1a4..ebe8986 100755
--- a/cr-for-branches
+++ b/cr-for-branches
@@ -31,7 +31,7 @@ scriptoptions="$1"; shift
 LOGFILE=tmp/cr-for-branches.log
 export LOGFILE
 
-: ${BRANCHES:=osstest xen-4.0-testing xen-4.1-testing xen-4.2-testing xen-4.3-testing xen-4.4-testing xen-4.5-testing xen-4.6-testing xen-4.7-testing xen-unstable qemu-mainline qemu-upstream-unstable qemu-upstream-4.2-testing qemu-upstream-4.3-testing qemu-upstream-4.4-testing qemu-upstream-4.5-testing qemu-upstream-4.6-testing qemu-upstream-4.7-testing linux-4.1 linux-3.18 linux-3.16 linux-3.14 linux-3.10 linux-3.4 linux-arm-xen seabios ovmf xtf ${EXTRA_BRANCHES}}
+: ${BRANCHES:=osstest xen-4.0-testing xen-4.1-testing xen-4.2-testing xen-4.3-testing xen-4.4-testing xen-4.5-testing xen-4.6-testing xen-4.7-testing xen-unstable qemu-mainline qemu-upstream-unstable qemu-upstream-4.2-testing qemu-upstream-4.3-testing qemu-upstream-4.4-testing qemu-upstream-4.5-testing qemu-upstream-4.6-testing qemu-upstream-4.7-testing linux-4.1 linux-3.18 linux-3.16 linux-3.14 linux-3.10 linux-3.4 linux-arm-xen seabios ovmf xtf openstack-nova ${EXTRA_BRANCHES}}
 export BRANCHES
 
 fetchwlem=$wlem
diff --git a/cri-common b/cri-common
index ac360de..f48dfa5 100644
--- a/cri-common
+++ b/cri-common
@@ -82,6 +82,7 @@ select_xenbranch () {
 	ovmf)			tree=ovmf;	xenbranch=xen-unstable ;;
 	distros-*)		tree=none;	xenbranch=xen-unstable ;;
 	osstest)		tree=osstest;	xenbranch=xen-unstable ;;
+	openstack-nova)	   tree=openstack-nova;	xenbranch=xen-unstable ;;
 	esac
 	if [ "x$tree" = xlinux ]; then
 		linuxbranch=$branch
diff --git a/make-flight b/make-flight
index a374884..b6a5176 100755
--- a/make-flight
+++ b/make-flight
@@ -167,6 +167,17 @@ job_create_test_filter_callback () {
         *) return 1;;
       esac
       ;;
+    openstack-nova)
+      case "$job" in
+        *-devstack) ;;
+        *-devstack-xsm) ;;
+        *) return 1;;
+      esac
+      case $dom0arch in
+          amd64) ;;
+          *) return 1;;
+      esac
+      ;;
     *)
       case "$job" in
         *-qemuu-*)
@@ -198,9 +209,16 @@ arch_branch_filter_callback () {
         rumprun) return 1;;
         seabios) return 1;;
         ovmf) return 1;;
+        openstack-nova) return 1;;
         esac
         ;;
-  i386|amd64)
+  i386)
+        case "$branch" in
+        linux-arm-xen) return 1;;
+        openstack-nova) return 1;;
+        esac
+        ;;
+  amd64)
         case "$branch" in
         linux-arm-xen) return 1;;
         esac
@@ -606,6 +624,35 @@ do_pv_debian_tests () {
   $endfmt$dom0arch
 }
 
+do_openstack_tests () {
+    local xsms=$(xenbranch_xsm_variants)
+    local openstack_trees=(cinder devstack glance keystone nova
+        requirements tempest)
+
+
+    if [ $dom0arch != amd64 ]; then
+        return
+    fi
+    if [ $branch != openstack-nova ]; then
+        return
+    fi
+
+    local os_runvars=""
+    for tree in "${openstack_trees[@]}"; do
+        eval "os_runvars+=\" tree_$tree=\${TREE_OPENSTACK_${tree^^}}\""
+        eval "os_runvars+=\" revision_$tree=\${REVISION_OPENSTACK_${tree^^}}\""
+    done
+
+    for xsm in $xsms ; do
+        job_create_test test-$xenarch$kern-$dom0arch-devstack \
+            test-devstack libvirt $xenarch $dom0arch \
+            $os_runvars \
+            dom0_mem=4000 \
+            enable_xsm=$xsm \
+            all_hostflags=$most_hostflags
+    done
+}
+
 test_matrix_do_one () {
 
   do_pv_debian_tests
@@ -753,6 +800,8 @@ test_matrix_do_one () {
   do_pvgrub_tests
 
   do_xtf_tests
+
+  do_openstack_tests
 }
 
 if [ x$buildflight = x ]; then
-- 
Anthony PERARD


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [OSSTEST PATCH v8 0/3] Have OpenStack tested on top of xen's master and libvirt's master.
  2016-11-24 18:14 [OSSTEST PATCH v8 0/3] Have OpenStack tested on top of xen's master and libvirt's master Anthony PERARD
                   ` (2 preceding siblings ...)
  2016-11-24 18:14 ` [OSSTEST PATCH v8 3/3] Create a flight to test OpenStack with xen-unstable and libvirt Anthony PERARD
@ 2016-12-12 12:20 ` Anthony PERARD
  2016-12-12 16:51 ` Ian Jackson
  4 siblings, 0 replies; 9+ messages in thread
From: Anthony PERARD @ 2016-12-12 12:20 UTC (permalink / raw)
  To: xen-devel; +Cc: Ian Jackson

ping?

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [OSSTEST PATCH v8 1/3] ts-openstack-deploy: Deploy OpenStack on a host with devstack
  2016-11-24 18:14 ` [OSSTEST PATCH v8 1/3] ts-openstack-deploy: Deploy OpenStack on a host with devstack Anthony PERARD
@ 2016-12-12 16:35   ` Ian Jackson
  0 siblings, 0 replies; 9+ messages in thread
From: Ian Jackson @ 2016-12-12 16:35 UTC (permalink / raw)
  To: Anthony PERARD; +Cc: xen-devel

Anthony PERARD writes ("[OSSTEST PATCH v8 1/3] ts-openstack-deploy: Deploy OpenStack on a host with devstack"):
> This script installs any necessary packages and clones all of the OpenStack
> trees which are used by devstack to deploy OpenStack.
> 
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>

Acked-by: Ian Jackson <ian.jackson@eu.citrix.com>

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [OSSTEST PATCH v8 0/3] Have OpenStack tested on top of xen's master and libvirt's master.
  2016-11-24 18:14 [OSSTEST PATCH v8 0/3] Have OpenStack tested on top of xen's master and libvirt's master Anthony PERARD
                   ` (3 preceding siblings ...)
  2016-12-12 12:20 ` [OSSTEST PATCH v8 0/3] Have OpenStack tested on top of xen's master and libvirt's master Anthony PERARD
@ 2016-12-12 16:51 ` Ian Jackson
  2016-12-12 17:25   ` Anthony PERARD
  4 siblings, 1 reply; 9+ messages in thread
From: Ian Jackson @ 2016-12-12 16:51 UTC (permalink / raw)
  To: Anthony PERARD; +Cc: xen-devel

Anthony PERARD writes ("[OSSTEST PATCH v8 0/3] Have OpenStack tested on top of xen's master and libvirt's master."):
> I have looked into getting OpenStack been tested on the latest Xen via
> osstest.
> Run of AP_FETCH_PLACEHOLDERS=y ./standalone-generate-dump-flight-runvars on
> master (5d88d6299618f6bce204d82579392a76028fb8cd) vs this patch series:

Thanks.  I'm afraid that has prompted some nontrivial questions and
comments:

The way you have done things, the test-amd64-amd64-devstack job will
run on a Xen dom0 installed by osstest.  Does this devstack test
expect to be run in such a context ?

It's quite anomalous that your test-* job is doing all the cloning and
building of things.  This is not a huge problem; there are only a
handful of places in osstest that have any "improper" knowledge of job
names, and for their purposes I think this is probably a "test" rather
than a "build".  (In particular, ts-hosts-allocate-Executive has some
different ideas about what would be a good host for a build.)

Most software, though, has a separate build and execute.  Maybe
tempest doesn't do that, in which case fine.  (Sorry if I have asked
this question before...)

+openstack-nova             test-amd64-amd64-devstack     all_host_suite          jessie
+openstack-nova             test-amd64-amd64-devstack     all_hostflags           arch-amd64,arch-xen-amd64,suite-jessie,purpose-test

This does not request a host capable of HVM.  Is that right ?
(In practice all our x86 hosts are capable of HVM so this may not
matter.)

+openstack-nova             test-amd64-amd64-devstack     revision_cinder
+openstack-nova             test-amd64-amd64-devstack     revision_devstack
+openstack-nova             test-amd64-amd64-devstack     revision_glance
+openstack-nova             test-amd64-amd64-devstack     revision_keystone
+openstack-nova             test-amd64-amd64-devstack     revision_nova           ap-fetch-version:openstack-nova
+openstack-nova             test-amd64-amd64-devstack     revision_requirements
+openstack-nova             test-amd64-amd64-devstack     revision_tempest

These openstack components ought not to live in the global namespace.
I would like you to prefix all of these runvars with `openstack'.  So,
revision_openstack_cinder etc.  Cf revison_rumprun_something.

Thinking about it, I think you should probably do the same with the
corresponding shell environment variables.

+openstack-nova             test-amd64-amd64-devstack     toolstack               libvirt
+openstack-nova             test-amd64-amd64-devstack     tree_cinder             git://git.openstack.org/openstack/cinder.git
+openstack-nova             test-amd64-amd64-devstack     tree_devstack           git://git.openstack.org/openstack-dev/devstack.git
+openstack-nova             test-amd64-amd64-devstack     tree_glance             git://git.openstack.org/openstack/glance.git
+openstack-nova             test-amd64-amd64-devstack     tree_keystone           git://git.openstack.org/openstack/keystone.git
+openstack-nova             test-amd64-amd64-devstack     tree_nova               git://git.openstack.org/openstack/nova.git
+openstack-nova             test-amd64-amd64-devstack     tree_requirements       git://git.openstack.org/openstack/requirements.git
+openstack-nova             test-amd64-amd64-devstack     tree_tempest            git://git.openstack.org/openstack/tempest.git

I notice that you have not created an openstack job in the other
branches.  Is that deliberate ?

Why no ARM jobs ?

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [OSSTEST PATCH v8 0/3] Have OpenStack tested on top of xen's master and libvirt's master.
  2016-12-12 16:51 ` Ian Jackson
@ 2016-12-12 17:25   ` Anthony PERARD
  2016-12-12 17:38     ` Ian Jackson
  0 siblings, 1 reply; 9+ messages in thread
From: Anthony PERARD @ 2016-12-12 17:25 UTC (permalink / raw)
  To: Ian Jackson; +Cc: xen-devel

On Mon, Dec 12, 2016 at 04:51:47PM +0000, Ian Jackson wrote:
> Anthony PERARD writes ("[OSSTEST PATCH v8 0/3] Have OpenStack tested on top of xen's master and libvirt's master."):
> > I have looked into getting OpenStack been tested on the latest Xen via
> > osstest.
> > Run of AP_FETCH_PLACEHOLDERS=y ./standalone-generate-dump-flight-runvars on
> > master (5d88d6299618f6bce204d82579392a76028fb8cd) vs this patch series:
> 
> Thanks.  I'm afraid that has prompted some nontrivial questions and
> comments:
> 
> The way you have done things, the test-amd64-amd64-devstack job will
> run on a Xen dom0 installed by osstest.  Does this devstack test
> expect to be run in such a context ?

In a Xen dom0? Yes.

> It's quite anomalous that your test-* job is doing all the cloning and
> building of things.  This is not a huge problem; there are only a
> handful of places in osstest that have any "improper" knowledge of job
> names, and for their purposes I think this is probably a "test" rather
> than a "build".  (In particular, ts-hosts-allocate-Executive has some
> different ideas about what would be a good host for a build.)
> 
> Most software, though, has a separate build and execute.  Maybe
> tempest doesn't do that, in which case fine.  (Sorry if I have asked
> this question before...)

Well, OpenStack been all python, there is nothing to build. So devstack
is mostly doing configuration and start services, I think.

> +openstack-nova             test-amd64-amd64-devstack     all_host_suite          jessie
> +openstack-nova             test-amd64-amd64-devstack     all_hostflags           arch-amd64,arch-xen-amd64,suite-jessie,purpose-test
> 
> This does not request a host capable of HVM.  Is that right ?
> (In practice all our x86 hosts are capable of HVM so this may not
> matter.)

I think that fine for now, this flight is only going to start PV guests.

> +openstack-nova             test-amd64-amd64-devstack     revision_cinder
> +openstack-nova             test-amd64-amd64-devstack     revision_devstack
> +openstack-nova             test-amd64-amd64-devstack     revision_glance
> +openstack-nova             test-amd64-amd64-devstack     revision_keystone
> +openstack-nova             test-amd64-amd64-devstack     revision_nova           ap-fetch-version:openstack-nova
> +openstack-nova             test-amd64-amd64-devstack     revision_requirements
> +openstack-nova             test-amd64-amd64-devstack     revision_tempest
> 
> These openstack components ought not to live in the global namespace.
> I would like you to prefix all of these runvars with `openstack'.  So,
> revision_openstack_cinder etc.  Cf revison_rumprun_something.
> 
> Thinking about it, I think you should probably do the same with the
> corresponding shell environment variables.

Will do.

> +openstack-nova             test-amd64-amd64-devstack     toolstack               libvirt
> +openstack-nova             test-amd64-amd64-devstack     tree_cinder             git://git.openstack.org/openstack/cinder.git
> +openstack-nova             test-amd64-amd64-devstack     tree_devstack           git://git.openstack.org/openstack-dev/devstack.git
> +openstack-nova             test-amd64-amd64-devstack     tree_glance             git://git.openstack.org/openstack/glance.git
> +openstack-nova             test-amd64-amd64-devstack     tree_keystone           git://git.openstack.org/openstack/keystone.git
> +openstack-nova             test-amd64-amd64-devstack     tree_nova               git://git.openstack.org/openstack/nova.git
> +openstack-nova             test-amd64-amd64-devstack     tree_requirements       git://git.openstack.org/openstack/requirements.git
> +openstack-nova             test-amd64-amd64-devstack     tree_tempest            git://git.openstack.org/openstack/tempest.git
> 
> I notice that you have not created an openstack job in the other
> branches.  Is that deliberate ?

Yes.

> Why no ARM jobs ?

I don't know if it is going to work, probably not. There probably going
to be missing packages (dependencies) and it maybe not going to be able
to start a guest, if devstart does not get the right guest image.

-- 
Anthony PERARD

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [OSSTEST PATCH v8 0/3] Have OpenStack tested on top of xen's master and libvirt's master.
  2016-12-12 17:25   ` Anthony PERARD
@ 2016-12-12 17:38     ` Ian Jackson
  0 siblings, 0 replies; 9+ messages in thread
From: Ian Jackson @ 2016-12-12 17:38 UTC (permalink / raw)
  To: Anthony PERARD; +Cc: xen-devel

Anthony PERARD writes ("Re: [OSSTEST PATCH v8 0/3] Have OpenStack tested on top of xen's master and libvirt's master."):
> On Mon, Dec 12, 2016 at 04:51:47PM +0000, Ian Jackson wrote:
> > The way you have done things, the test-amd64-amd64-devstack job will
> > run on a Xen dom0 installed by osstest.  Does this devstack test
> > expect to be run in such a context ?
> 
> In a Xen dom0? Yes.

Right, OK, good.

> Well, OpenStack been all python, there is nothing to build. So devstack
> is mostly doing configuration and start services, I think.

Ah.  OK.

> > These openstack components ought not to live in the global namespace.
> > I would like you to prefix all of these runvars with `openstack'.  So,
> > revision_openstack_cinder etc.  Cf revison_rumprun_something.
> > 
> > Thinking about it, I think you should probably do the same with the
> > corresponding shell environment variables.
> 
> Will do.

Thanks.  Sorry for not noticing this sooner.

> > I notice that you have not created an openstack job in the other
> > branches.  Is that deliberate ?
> 
> Yes.

OK, fine.

> > Why no ARM jobs ?
> 
> I don't know if it is going to work, probably not. There probably going
> to be missing packages (dependencies) and it maybe not going to be able
> to start a guest, if devstart does not get the right guest image.

I'm not sure these are good reasons not to try to support ARM.

A failing test, with a promise that the system would detect
regressions if the test were made to pass, is a good incentive :-).

Ian.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2016-12-12 17:38 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-24 18:14 [OSSTEST PATCH v8 0/3] Have OpenStack tested on top of xen's master and libvirt's master Anthony PERARD
2016-11-24 18:14 ` [OSSTEST PATCH v8 1/3] ts-openstack-deploy: Deploy OpenStack on a host with devstack Anthony PERARD
2016-12-12 16:35   ` Ian Jackson
2016-11-24 18:14 ` [OSSTEST PATCH v8 2/3] ts-openstack-tempest: Run Tempest to check OpenStack Anthony PERARD
2016-11-24 18:14 ` [OSSTEST PATCH v8 3/3] Create a flight to test OpenStack with xen-unstable and libvirt Anthony PERARD
2016-12-12 12:20 ` [OSSTEST PATCH v8 0/3] Have OpenStack tested on top of xen's master and libvirt's master Anthony PERARD
2016-12-12 16:51 ` Ian Jackson
2016-12-12 17:25   ` Anthony PERARD
2016-12-12 17:38     ` Ian Jackson

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).