From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Wei Liu <wei.liu2@citrix.com>
Cc: Ross Lagerwall <ross.lagerwall@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
xen-devel@lists.xen.org
Subject: Re: [PATCH v1 3/7] tools/livepatch: Improve output
Date: Mon, 12 Dec 2016 12:11:00 -0500 [thread overview]
Message-ID: <20161212171100.GB6050@char.us.oracle.com> (raw)
In-Reply-To: <20161212170252.GI25175@citrix.com>
On Mon, Dec 12, 2016 at 05:02:52PM +0000, Wei Liu wrote:
> On Mon, Dec 12, 2016 at 04:18:06PM +0000, Ross Lagerwall wrote:
> > Improving the output of xen-livepatch, which is currently hard to read,
> > especially when an error occurs.
> >
> > Some examples of the changes:
> > Before:
> > $ xen-livepatch apply test
> > Performing apply:. completed
> > After:
> > $ xen-livepatch apply test
> > Applying test:. completed
> >
> > Before:
> > $ xen-livepatch apply test2
> > test2 failed with 22(Invalid argument)
> > Performing apply: (no newline)
> > After:
> > $ xen-livepatch apply test2
> > Applying test2: failed
> > Error 22: Invalid argument
> >
> > Signed-off-by: Ross Lagerwall <ross.lagerwall@citrix.com>
>
> Acked-by: Wei Liu <wei.liu2@citrix.com>
>
> I will let Konrad quibble about the actual text.
No quibbles from me.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-12-12 17:11 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-12 16:18 [PATCH v1 0/7] xen-livepatch misc fixes/changes Ross Lagerwall
2016-12-12 16:18 ` [PATCH v1 1/7] tools/livepatch: Show the correct expected state before action Ross Lagerwall
2016-12-12 17:02 ` Wei Liu
2016-12-12 16:18 ` [PATCH v1 2/7] tools/livepatch: Set stdout and stderr unbuffered Ross Lagerwall
2016-12-12 17:02 ` Wei Liu
2016-12-14 6:44 ` Ross Lagerwall
2016-12-14 7:43 ` Wei Liu
2016-12-12 16:18 ` [PATCH v1 3/7] tools/livepatch: Improve output Ross Lagerwall
2016-12-12 17:02 ` Wei Liu
2016-12-12 17:11 ` Konrad Rzeszutek Wilk [this message]
2016-12-12 16:18 ` [PATCH v1 4/7] livepatch: Set timeout unit to nanoseconds Ross Lagerwall
2016-12-12 17:02 ` Wei Liu
2016-12-12 17:13 ` Konrad Rzeszutek Wilk
2016-12-12 16:18 ` [PATCH v1 5/7] tools/livepatch: Remove pointless retry loop Ross Lagerwall
2016-12-12 17:03 ` Wei Liu
2016-12-12 16:18 ` [PATCH v1 6/7] tools/livepatch: Remove unused struct member Ross Lagerwall
2016-12-12 17:03 ` Wei Liu
2016-12-12 17:13 ` Konrad Rzeszutek Wilk
2016-12-12 16:18 ` [PATCH v1 7/7] tools/livepatch: Exit with 2 if a timeout occurs Ross Lagerwall
2016-12-12 17:02 ` Wei Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161212171100.GB6050@char.us.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=ian.jackson@eu.citrix.com \
--cc=ross.lagerwall@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).