* [PATCH] firmware/rombios: fix after update to libacpi
@ 2016-12-13 17:15 Roger Pau Monne
2016-12-13 17:47 ` Wei Liu
0 siblings, 1 reply; 2+ messages in thread
From: Roger Pau Monne @ 2016-12-13 17:15 UTC (permalink / raw)
To: xen-devel
Cc: Wei Liu, Ian Jackson, Jan Beulich, Razvan Cojocaru,
Roger Pau Monne
Fix a build breakage after the libacpi changes, this is due to rombios using the
libacpi headers in order to parse the ACPI tables.
Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
Reported-by: Razvan Cojocaru <rcojocaru@bitdefender.com>
---
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>
Cc: Razvan Cojocaru <rcojocaru@bitdefender.com>
Cc: Jan Beulich <JBeulich@suse.com>
---
The usage of ACPI tables in rombios seems quite simplistic, for example it
doesn't check the version of the table at all, which could led to errors (not
now, because the field it is accessing is always there for all the ACPI versions
that we support). I guess this doesn't matter much since no more development is
going to happen in rombios in any case.
---
tools/firmware/rombios/32bit/util.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/firmware/rombios/32bit/util.c b/tools/firmware/rombios/32bit/util.c
index e473e89..6c1c480 100644
--- a/tools/firmware/rombios/32bit/util.c
+++ b/tools/firmware/rombios/32bit/util.c
@@ -438,7 +438,7 @@ uint32_t get_s3_waking_vector(void)
{
struct acpi_20_rsdp *rsdp = find_rsdp();
struct acpi_20_xsdt *xsdt;
- struct acpi_20_fadt *fadt;
+ struct acpi_fadt *fadt;
struct acpi_20_facs *facs;
uint32_t vector;
@@ -449,8 +449,8 @@ uint32_t get_s3_waking_vector(void)
if (!xsdt)
return 0;
- fadt = (struct acpi_20_fadt *)(long)xsdt->entry[0];
- if (!fadt || (fadt->header.signature != ACPI_2_0_FADT_SIGNATURE))
+ fadt = (struct acpi_fadt *)(long)xsdt->entry[0];
+ if (!fadt || (fadt->header.signature != ACPI_FADT_SIGNATURE))
return 0;
facs = (struct acpi_20_facs *)(long)fadt->x_firmware_ctrl;
--
2.9.3 (Apple Git-75)
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-12-13 17:47 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-13 17:15 [PATCH] firmware/rombios: fix after update to libacpi Roger Pau Monne
2016-12-13 17:47 ` Wei Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).