From: Wei Liu <wei.liu2@citrix.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: Andrew Cooper <andrew.cooper3@citrix.com>,
Wei Liu <wei.liu2@citrix.com>,
Ian Jackson <ian.jackson@eu.citrix.com>,
Xen-devel <xen-devel@lists.xenproject.org>
Subject: Re: [PATCH] libxl: init_acpi_config should return rc in exit path
Date: Fri, 16 Dec 2016 15:20:35 +0000 [thread overview]
Message-ID: <20161216152035.GB11932@citrix.com> (raw)
In-Reply-To: <4873a70a-d835-446f-2fe1-eac24b7b78b1@oracle.com>
On Fri, Dec 16, 2016 at 10:21:07AM -0500, Boris Ostrovsky wrote:
> On 12/16/2016 10:16 AM, Wei Liu wrote:
> >
> > I see, I think we also need to set rc=0 in the success path.
>
> Or 'return rc < 0 ? rc : 0;'
>
I don't think so, because there could be functions that only return >0
values to indicate error.
Wei.
> -boris
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-12-16 15:20 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-14 11:44 [PATCH] libxl: init_acpi_config should return rc in exit path Wei Liu
2016-12-14 11:49 ` Andrew Cooper
2016-12-14 12:28 ` Wei Liu
2016-12-16 15:10 ` Boris Ostrovsky
2016-12-16 15:16 ` Wei Liu
2016-12-16 15:21 ` Boris Ostrovsky
2016-12-16 15:20 ` Wei Liu [this message]
2016-12-16 15:42 ` Ian Jackson
2016-12-16 11:05 ` Ian Jackson
2016-12-16 11:09 ` Wei Liu
2016-12-16 16:23 ` Wei Liu
2016-12-16 16:25 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161216152035.GB11932@citrix.com \
--to=wei.liu2@citrix.com \
--cc=andrew.cooper3@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=ian.jackson@eu.citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).