xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Roger Pau Monne <roger.pau@citrix.com>
To: xen-devel@lists.xenproject.org
Cc: Wei Liu <wei.liu2@citrix.com>,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	Roger Pau Monne <roger.pau@citrix.com>
Subject: [PATCH 3/4] init/FreeBSD: fix xencommons so it can only be launched by Dom0
Date: Mon, 19 Dec 2016 15:02:03 +0000	[thread overview]
Message-ID: <20161219150204.4481-4-roger.pau@citrix.com> (raw)
In-Reply-To: <20161219150204.4481-1-roger.pau@citrix.com>

At the moment the execution of xencommons is gated on the presence of the
privcmd device, but that's not correct, since privcmd is available to all Xen
domains (privileged or unprivileged). Instead of using privcmd use the
xenstored device, which will only be available to the domain that's in charge
of running xenstored, and thus xencommons.

Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
---
Cc: Ian Jackson <ian.jackson@eu.citrix.com>
Cc: Wei Liu <wei.liu2@citrix.com>
---
 tools/hotplug/FreeBSD/rc.d/xencommons.in | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/hotplug/FreeBSD/rc.d/xencommons.in b/tools/hotplug/FreeBSD/rc.d/xencommons.in
index efa8801..81f69f3 100644
--- a/tools/hotplug/FreeBSD/rc.d/xencommons.in
+++ b/tools/hotplug/FreeBSD/rc.d/xencommons.in
@@ -16,7 +16,7 @@ start_cmd="xen_startcmd"
 stop_cmd="xen_stop"
 status_cmd="xen_status"
 extra_commands="status"
-required_files="/dev/xen/privcmd"
+required_files="/dev/xen/xenstored"
 
 XENSTORED_PIDFILE="@XEN_RUN_DIR@/xenstored.pid"
 XENCONSOLED_PIDFILE="@XEN_RUN_DIR@/xenconsoled.pid"
-- 
2.10.1 (Apple Git-78)


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  parent reply	other threads:[~2016-12-19 15:03 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-19 15:02 [PATCH 0/4] init/FreeBSD: Minor fixes for FreeBSD init scripts Roger Pau Monne
2016-12-19 15:02 ` [PATCH 1/4] init/FreeBSD: set correct PATH for xl devd Roger Pau Monne
2016-12-21 11:48   ` Wei Liu
2016-12-19 15:02 ` [PATCH 2/4] init/FreeBSD: remove xendriverdomain_precmd Roger Pau Monne
2016-12-21 11:48   ` Wei Liu
2016-12-21 12:13     ` Roger Pau Monne
2016-12-19 15:02 ` Roger Pau Monne [this message]
2016-12-21 11:48   ` [PATCH 3/4] init/FreeBSD: fix xencommons so it can only be launched by Dom0 Wei Liu
2016-12-19 15:02 ` [PATCH 4/4] init/FreeBSD: add rc control variables Roger Pau Monne
2016-12-21 11:49   ` Wei Liu
2016-12-21 12:12     ` Roger Pau Monne
2016-12-21 16:38       ` Wei Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161219150204.4481-4-roger.pau@citrix.com \
    --to=roger.pau@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=wei.liu2@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).