From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Doug Goldstein <cardoe@cardoe.com>
Cc: wei.liu2@citrix.com, ian.jackson@eu.citrix.com,
Alistair Francis <alistair.francis@xilinx.com>,
imhy.yang@gmail.com, xen-devel@lists.xenproject.org,
rshriram@cs.ubc.ca, alistair23@gmail.com
Subject: Re: [PATCH 1/7] Remove hardcoded strict -Werror checking
Date: Tue, 20 Dec 2016 12:21:57 -0500 [thread overview]
Message-ID: <20161220172157.GP10069@char.us.oracle.com> (raw)
In-Reply-To: <19e85205-06d2-1186-482f-8fd07a682387@cardoe.com>
On Tue, Dec 20, 2016 at 11:02:15AM -0600, Doug Goldstein wrote:
> On 12/20/16 10:05 AM, Konrad Rzeszutek Wilk wrote:
> > On Mon, Dec 19, 2016 at 09:53:02PM -0600, Doug Goldstein wrote:
> >> On 12/17/16 9:51 AM, Konrad Rzeszutek Wilk wrote:
> >>> On Fri, Dec 16, 2016 at 02:56:01PM -0800, Alistair Francis wrote:
> >>>> Signed-off-by: Alistair Francis <alistair.francis@xilinx.com>
> >>>
> >>>
> >>> Why?
> >>
> >> *adjusts his distro maintainer hat* It's considered really bad form for
> >> upstreams to push -Werror in their projects. However I know there's
> >> upstream interest to keep it. The compromise would probably be to get my
> >> rear in gear and get a wider range of distros testing with Travis CI /
> >> GitLab CI.
> >
> > So.. why not do something like this:
> >
> >
> > diff --git a/config/StdGNU.mk b/config/StdGNU.mk
> > index 6be8233..fd2d5b9 100644
> > --- a/config/StdGNU.mk
> > +++ b/config/StdGNU.mk
> > @@ -39,3 +39,5 @@ ifeq ($(lto),y)
> > CFLAGS += -flto
> > LDFLAGS-$(clang) += -plugin LLVMgold.so
> > endif
> > +
> > +CFLAGS += $(EXTRA_CFLAGS)
> >
> > And have the BuildRoot script do something like:
> >
> >
> > EXTRA_CFLAGS=$(CFLAGS)
> > unset CFLAGS
> >
> > make -C xen
> >
> > ?
> >
>
> This was really to replace patch 3/7 right? Cause I think this would be
> an ok change. It'd certainly help me with Yocto where I have to pass in
> CFLAGS (need to pass in the sysroot of the target compiler).
Yes sorry.
>
> --
> Doug Goldstein
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-12-20 17:22 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-16 22:56 [PATCH 0/7] General Build Fixes Alistair Francis
2016-12-16 22:56 ` [PATCH 1/7] Remove hardcoded strict -Werror checking Alistair Francis
2016-12-17 15:51 ` Konrad Rzeszutek Wilk
2016-12-19 17:58 ` Alistair Francis
2016-12-20 3:53 ` Doug Goldstein
2016-12-20 16:05 ` Konrad Rzeszutek Wilk
2016-12-20 17:02 ` Doug Goldstein
2016-12-20 17:21 ` Konrad Rzeszutek Wilk [this message]
2016-12-20 17:57 ` Alistair Francis
2016-12-20 17:58 ` Alistair Francis
2016-12-16 22:56 ` [PATCH 2/7] tools/libxl: " Alistair Francis
2016-12-17 15:52 ` Konrad Rzeszutek Wilk
2016-12-16 22:56 ` [PATCH 3/7] xen/Rules.mk: fix build with CFLAGS from environment Alistair Francis
2016-12-17 15:54 ` Konrad Rzeszutek Wilk
2016-12-19 8:32 ` Jan Beulich
2016-12-16 22:56 ` [PATCH 4/7] tools: Update sys/poll.h to poll.h Alistair Francis
2016-12-17 15:55 ` Konrad Rzeszutek Wilk
2016-12-19 18:01 ` Alistair Francis
2016-12-20 4:00 ` Doug Goldstein
2016-12-20 17:44 ` Alistair Francis
2016-12-16 22:56 ` [PATCH 5/7] tools/blktap2: Update sys/signal.h to signal.h Alistair Francis
2016-12-17 15:56 ` Konrad Rzeszutek Wilk
2016-12-19 18:02 ` Alistair Francis
2016-12-20 4:01 ` Doug Goldstein
2016-12-16 22:56 ` [PATCH 6/7] tools/blktap2/vhd: Remove unused struct stat stats Alistair Francis
2016-12-17 15:57 ` Konrad Rzeszutek Wilk
2016-12-16 22:56 ` [PATCH 7/7] tools/blktap2: Fix missing header file Alistair Francis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161220172157.GP10069@char.us.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=alistair.francis@xilinx.com \
--cc=alistair23@gmail.com \
--cc=cardoe@cardoe.com \
--cc=ian.jackson@eu.citrix.com \
--cc=imhy.yang@gmail.com \
--cc=rshriram@cs.ubc.ca \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).