xen-devel.lists.xenproject.org archive mirror
 help / color / mirror / Atom feed
From: Wei Liu <wei.liu2@citrix.com>
To: Roger Pau Monne <roger.pau@citrix.com>
Cc: xen-devel@lists.xenproject.org,
	Ian Jackson <ian.jackson@eu.citrix.com>,
	Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH] init/FreeBSD: fix incorrect usage of $rc_pids in xendriverdomain
Date: Wed, 21 Dec 2016 16:53:52 +0000	[thread overview]
Message-ID: <20161221165352.GJ28690@citrix.com> (raw)
In-Reply-To: <20161221164726.7914-1-roger.pau@citrix.com>

On Wed, Dec 21, 2016 at 04:47:26PM +0000, Roger Pau Monne wrote:
> It should be rc_pid.
> 
> Signed-off-by: Roger Pau Monné <roger.pau@citrix.com>
> Reported-by: Nathan Friess <nathan.friess@gmail.com>

Acked + applied.

I suspect all the patches to fix FreeBSD init script should be
backported?

> ---
> Cc: Ian Jackson <ian.jackson@eu.citrix.com>
> Cc: Wei Liu <wei.liu2@citrix.com>
> ---
>  tools/hotplug/FreeBSD/rc.d/xendriverdomain.in | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/tools/hotplug/FreeBSD/rc.d/xendriverdomain.in b/tools/hotplug/FreeBSD/rc.d/xendriverdomain.in
> index b01a470..a032822 100644
> --- a/tools/hotplug/FreeBSD/rc.d/xendriverdomain.in
> +++ b/tools/hotplug/FreeBSD/rc.d/xendriverdomain.in
> @@ -38,8 +38,8 @@ xendriverdomain_stop()
>  
>  	rc_pid=$(check_pidfile ${XLDEVD_PIDFILE} ${sbindir}/xl)
>  
> -	kill -${sig_stop:-TERM} $rc_pids
> -	wait_for_pids $rc_pids
> +	kill -${sig_stop:-TERM} $rc_pid
> +	wait_for_pids $rc_pid
>  }
>  
>  run_rc_command "$1"
> -- 
> 2.10.1 (Apple Git-78)
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

  reply	other threads:[~2016-12-21 16:54 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-21 16:47 [PATCH] init/FreeBSD: fix incorrect usage of $rc_pids in xendriverdomain Roger Pau Monne
2016-12-21 16:53 ` Wei Liu [this message]
2016-12-22 10:51   ` Roger Pau Monne
2016-12-22 10:57     ` Ian Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161221165352.GJ28690@citrix.com \
    --to=wei.liu2@citrix.com \
    --cc=ian.jackson@eu.citrix.com \
    --cc=roger.pau@citrix.com \
    --cc=xen-devel@lists.xenproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).