From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCH] libxl/libxl_qmp.c: Fix code style in qmp_next() Date: Thu, 22 Dec 2016 10:47:35 +0000 Message-ID: <20161222104734.GL28690@citrix.com> References: <1482400387-18231-1-git-send-email-zhangchen.fnst@cn.fujitsu.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta6.messagelabs.com ([193.109.254.103]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cK0uQ-0003mr-Ns for xen-devel@lists.xenproject.org; Thu, 22 Dec 2016 10:47:38 +0000 Content-Disposition: inline In-Reply-To: <1482400387-18231-1-git-send-email-zhangchen.fnst@cn.fujitsu.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Zhang Chen Cc: Anthony PERARD , Xen devel , Ian Jackson , Wei Liu List-Id: xen-devel@lists.xenproject.org QWxzbyBDQyBBbnRob255LCB3aG8gd3JvdGUgdGhlIG9yaWdpbmFsIGNvZGUuCgpPbiBUaHUsIERl YyAyMiwgMjAxNiBhdCAwNTo1MzowN1BNICswODAwLCBaaGFuZyBDaGVuIHdyb3RlOgo+IE1ha2Ug c2VsZWN0IGxvb3AgbW9yZSByZWFkYWJsZS4KClRoZSBiZWhhdmlvdXIgb2YgdGhpcyBmdW5jdGlv biBpcyBjaGFuZ2VkLiBUaGUgY2hhbmdlcyBhcmUgbm90Cm5lY2Vzc2FyaWx5IHdyb25nLCBidXQg d2UgbmVlZCB0byBoYXZlIGNsZWFyIGNvbW1pdCBtZXNzYWdlIGZvciB3aHkgdGhlCmNoYW5nZSBv ZiBiZWhhdmlvdXIgaXMgZGVzaXJhYmxlLgoKQmFzaWNhbGx5IHlvdSBicmVhayBhIGJpZyBsb29w IGludG8gdHdvIGRpc2pvaW50IG9uZXMuIEkgdGhpbmsgdGhlCm9yaWdpbmFsIGNvZGUgaGFuZGxl cyBzaG9ydC1yZWFkIGNvcnJlY3RseSB3aGlsZSB0aGlzIHBhdGNoIGRvZXNuJ3QuCgpTZWUgYmVs b3cuCgo+IAo+IFNpZ25lZC1vZmYtYnk6IFpoYW5nIENoZW4gPHpoYW5nY2hlbi5mbnN0QGNuLmZ1 aml0c3UuY29tPgo+IC0tLQo+ICB0b29scy9saWJ4bC9saWJ4bF9xbXAuYyB8IDEyMyArKysrKysr KysrKysrKysrKysrKysrKystLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KPiAgMSBmaWxlIGNoYW5n ZWQsIDYxIGluc2VydGlvbnMoKyksIDYyIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS90 b29scy9saWJ4bC9saWJ4bF9xbXAuYyBiL3Rvb2xzL2xpYnhsL2xpYnhsX3FtcC5jCj4gaW5kZXgg YWQyMmFkNC4uMTIzYTZiZiAxMDA2NDQKPiAtLS0gYS90b29scy9saWJ4bC9saWJ4bF9xbXAuYwo+ ICsrKyBiL3Rvb2xzL2xpYnhsL2xpYnhsX3FtcC5jCj4gQEAgLTQyNyw3OSArNDI3LDc4IEBAIHN0 YXRpYyBpbnQgcW1wX25leHQobGlieGxfX2djICpnYywgbGlieGxfX3FtcF9oYW5kbGVyICpxbXAp Cj4gICAgICBzaXplX3QgaW5jb21wbGV0ZV9zaXplID0gMDsKPiAgICAgIGludCByYyA9IDA7Cj4g IAo+IC0gICAgZG8gewo+IC0gICAgICAgIGZkX3NldCByZmRzOwo+IC0gICAgICAgIGludCByZXQg PSAwOwo+IC0gICAgICAgIHN0cnVjdCB0aW1ldmFsIHRpbWVvdXQgPSB7Cj4gLSAgICAgICAgICAg IC50dl9zZWMgPSBxbXAtPnRpbWVvdXQsCj4gLSAgICAgICAgICAgIC50dl91c2VjID0gMCwKPiAt ICAgICAgICB9Owo+ICsgICAgZmRfc2V0IHJmZHM7Cj4gKyAgICBpbnQgcmV0ID0gMDsKPiArICAg IHN0cnVjdCB0aW1ldmFsIHRpbWVvdXQgPSB7Cj4gKyAgICAgICAgLnR2X3NlYyA9IHFtcC0+dGlt ZW91dCwKPiArICAgICAgICAudHZfdXNlYyA9IDAsCj4gKyAgICB9Owo+ICAKPiAtICAgICAgICBG RF9aRVJPKCZyZmRzKTsKPiAtICAgICAgICBGRF9TRVQocW1wLT5xbXBfZmQsICZyZmRzKTsKPiAr ICAgIEZEX1pFUk8oJnJmZHMpOwo+ICsgICAgRkRfU0VUKHFtcC0+cW1wX2ZkLCAmcmZkcyk7Cj4g IAo+ICsgICAgZG8gewo+ICAgICAgICAgIHJldCA9IHNlbGVjdChxbXAtPnFtcF9mZCArIDEsICZy ZmRzLCBOVUxMLCBOVUxMLCAmdGltZW91dCk7Cj4gLSAgICAgICAgaWYgKHJldCA9PSAwKSB7Cj4g LSAgICAgICAgICAgIExPR0QoRVJST1IsIHFtcC0+ZG9taWQsICJ0aW1lb3V0Iik7Cj4gLSAgICAg ICAgICAgIHJldHVybiAtMTsKPiAtICAgICAgICB9IGVsc2UgaWYgKHJldCA8IDApIHsKPiAtICAg ICAgICAgICAgaWYgKGVycm5vID09IEVJTlRSKQo+IC0gICAgICAgICAgICAgICAgY29udGludWU7 Cj4gLSAgICAgICAgICAgIExPR0VEKEVSUk9SLCBxbXAtPmRvbWlkLCAiU2VsZWN0IGVycm9yIik7 Cj4gLSAgICAgICAgICAgIHJldHVybiAtMTsKPiAtICAgICAgICB9Cj4gKyAgICB9IHdoaWxlIChy ZXQgPT0gLTEgJiYgZXJybm8gPT0gRUlOVFIpOwo+ICAKCkEgc2lkZSBub3RlLgoKU2VsZWN0IG1h eSBtb2RpZnkgdGltZW91dCwgc28gSSB0aGluayB3ZSBuZWVkIHRvIHJlc2V0IHRpbWVvdXQgYXQg dGhlCmJlZ2lubmluZyBvZiB0aGUgbG9vcC4KCj4gLSAgICAgICAgcmQgPSByZWFkKHFtcC0+cW1w X2ZkLCBxbXAtPmJ1ZmZlciwgUU1QX1JFQ0VJVkVfQlVGRkVSX1NJWkUpOwo+IC0gICAgICAgIGlm IChyZCA9PSAwKSB7Cj4gLSAgICAgICAgICAgIExPR0QoRVJST1IsIHFtcC0+ZG9taWQsICJVbmV4 cGVjdGVkIGVuZCBvZiBzb2NrZXQiKTsKPiAtICAgICAgICAgICAgcmV0dXJuIC0xOwo+IC0gICAg ICAgIH0gZWxzZSBpZiAocmQgPCAwKSB7Cj4gLSAgICAgICAgICAgIExPR0VEKEVSUk9SLCBxbXAt PmRvbWlkLCAiU29ja2V0IHJlYWQgZXJyb3IiKTsKPiAtICAgICAgICAgICAgcmV0dXJuIHJkOwo+ IC0gICAgICAgIH0KPiAtICAgICAgICBxbXAtPmJ1ZmZlcltyZF0gPSAnXDAnOwo+IC0KPiAtICAg ICAgICBERUJVR19SRVBPUlRfUkVDRUlWRUQocW1wLT5kb21pZCwgcW1wLT5idWZmZXIsIHJkKTsK PiAtCj4gLSAgICAgICAgZG8gewo+IC0gICAgICAgICAgICBjaGFyICplbmQgPSBOVUxMOwo+IC0g ICAgICAgICAgICBpZiAoaW5jb21wbGV0ZSkgewo+IC0gICAgICAgICAgICAgICAgc2l6ZV90IGN1 cnJlbnRfcG9zID0gcyAtIGluY29tcGxldGU7Cj4gLSAgICAgICAgICAgICAgICBpbmNvbXBsZXRl ID0gbGlieGxfX3JlYWxsb2MoZ2MsIGluY29tcGxldGUsCj4gLSAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgaW5jb21wbGV0ZV9zaXplICsgcmQgKyAxKTsKPiAtICAg ICAgICAgICAgICAgIHN0cm5jYXQoaW5jb21wbGV0ZSArIGluY29tcGxldGVfc2l6ZSwgcW1wLT5i dWZmZXIsIHJkKTsKPiAtICAgICAgICAgICAgICAgIHMgPSBpbmNvbXBsZXRlICsgY3VycmVudF9w b3M7Cj4gLSAgICAgICAgICAgICAgICBpbmNvbXBsZXRlX3NpemUgKz0gcmQ7Cj4gLSAgICAgICAg ICAgICAgICBzX2VuZCA9IGluY29tcGxldGUgKyBpbmNvbXBsZXRlX3NpemU7Cj4gLSAgICAgICAg ICAgIH0gZWxzZSB7Cj4gLSAgICAgICAgICAgICAgICBpbmNvbXBsZXRlID0gbGlieGxfX3N0cm5k dXAoZ2MsIHFtcC0+YnVmZmVyLCByZCk7Cj4gLSAgICAgICAgICAgICAgICBpbmNvbXBsZXRlX3Np emUgPSByZDsKPiAtICAgICAgICAgICAgICAgIHMgPSBpbmNvbXBsZXRlOwo+IC0gICAgICAgICAg ICAgICAgc19lbmQgPSBzICsgcmQ7Cj4gLSAgICAgICAgICAgICAgICByZCA9IDA7Cj4gLSAgICAg ICAgICAgIH0KPiArICAgIGlmIChyZXQgPT0gMCkgewo+ICsgICAgICAgIExPR0QoRVJST1IsIHFt cC0+ZG9taWQsICJ0aW1lb3V0Iik7Cj4gKyAgICAgICAgcmV0dXJuIC0xOwo+ICsgICAgfSBlbHNl IGlmIChyZXQgPCAwKSB7Cj4gKyAgICAgICAgTE9HRUQoRVJST1IsIHFtcC0+ZG9taWQsICJTZWxl Y3QgZXJyb3IiKTsKPiArICAgICAgICByZXR1cm4gLTE7Cj4gKyAgICB9Cj4gIAo+IC0gICAgICAg ICAgICBlbmQgPSBzdHJzdHIocywgIlxyXG4iKTsKPiAtICAgICAgICAgICAgaWYgKGVuZCkgewo+ IC0gICAgICAgICAgICAgICAgbGlieGxfX2pzb25fb2JqZWN0ICpvID0gTlVMTDsKPiArICAgIHJk ID0gcmVhZChxbXAtPnFtcF9mZCwgcW1wLT5idWZmZXIsIFFNUF9SRUNFSVZFX0JVRkZFUl9TSVpF KTsKPiArICAgIGlmIChyZCA9PSAwKSB7Cj4gKyAgICAgICAgTE9HRChFUlJPUiwgcW1wLT5kb21p ZCwgIlVuZXhwZWN0ZWQgZW5kIG9mIHNvY2tldCIpOwo+ICsgICAgICAgIHJldHVybiAtMTsKPiAr ICAgIH0gZWxzZSBpZiAocmQgPCAwKSB7Cj4gKyAgICAgICAgTE9HRUQoRVJST1IsIHFtcC0+ZG9t aWQsICJTb2NrZXQgcmVhZCBlcnJvciIpOwo+ICsgICAgICAgIHJldHVybiByZDsKPiArICAgIH0K PiArICAgIHFtcC0+YnVmZmVyW3JkXSA9ICdcMCc7Cj4gKwoKSGVyZSwgYXMgSSB1bmRlcnN0YW5k IGl0LCByZWFkIGNhbiByZXR1cm4gaW5jb21wbGV0ZSBtZXNzYWdlLiBGb3IKZXhhbXBsZSwgd2hl biB0aGUgYnVmZmVyIGlzIG5vdCBiaWcgZW5vdWdoLgoKQW5kIHRoZSBpbm5lciBsb29wIGluIG9y aWdpbmFsIGNvZGUgaGFuZGxlcyB0aGF0IGJ5IGNoZWNraW5nIGlmIHRoZXJlIGlzCiJcclxuIi4g SWYgbm90LCBpdCB3aWxsIHJlYWQgZnJvbSB0aGUgc29ja2V0IGFnYWluLgoKU28gSSdtIGFmcmFp ZCB0aGlzIHBhdGNoIGlzIG5vdCBjb3JyZWN0LiBQbGVhc2UgcG9pbnQgb3V0IGlmIHRoZXJlIGlz CmFueXRoaW5nIEkgbWlzc2VkLgoKV2VpLgoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMu eGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCg==