From: Wei Liu <wei.liu2@citrix.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Yi Sun <yi.y.sun@linux.intel.com>,
xen-devel@lists.xenproject.org, he.chen@linux.intel.com,
andrew.cooper3@citrix.com, dario.faggioli@citrix.com,
ian.jackson@eu.citrix.com, mengxu@cis.upenn.edu,
chao.p.peng@linux.intel.com, Wei Liu <wei.liu2@citrix.com>
Subject: Re: [PATCH v4 21/24] tools: L2 CAT: support get HW info for L2 CAT.
Date: Mon, 9 Jan 2017 09:26:17 +0000 [thread overview]
Message-ID: <20170109092616.GD1100@citrix.com> (raw)
In-Reply-To: <58735877020000780012E093@prv-mh.provo.novell.com>
On Mon, Jan 09, 2017 at 01:31:35AM -0700, Jan Beulich wrote:
> >>> On 09.01.17 at 02:19, <yi.y.sun@linux.intel.com> wrote:
> > On 17-01-06 12:04:36, Wei Liu wrote:
> >> On Wed, Dec 14, 2016 at 12:08:01PM +0800, Yi Sun wrote:
> >> > This patch implements xl/xc changes to support get HW info
> >> > for L2 CAT.
> >> >
> >> > 'xl psr-hwinfo' is updated to show both L3 CAT and L2 CAT
> >> > info.
> >> >
> >> > Example(on machine which only supports L2 CAT):
> >> > Cache Monitoring Technology (CMT):
> >> > Enabled : 0
> >> > Cache Allocation Technology (CAT): L3
> >> > libxl: error: libxl_psr.c:100:libxl__psr_cat_log_err_msg: CAT is not enabled on the socket: No such file or directory
> >> > Failed to get l3 cat info
> >>
> >> What is this?
> >>
> > The psr-hwinfo prints all features out by design. This test was executed on a
> > machine which only supports L2 CAT. So, the L3 CAT not supported info will be
> > printed out.
>
> But there is an indication of error(s), which shouldn't be the case just
> because of non-present hardware. The hypercall may return failure
> in such a case of course, but this shouldn't propagate to error/failure
> messages being printed (but at the same time you need to make sure
> you don't hide actual errors). Perhaps there's a call missing querying
> host capabilities (based on the result of which further info queries
> would be issued)?
>
This is what I thought as well.
> Jan
>
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-01-09 9:26 UTC|newest]
Thread overview: 79+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-14 4:07 [PATCH v4 00/24] Enable L2 Cache Allocation Technology & Refactor psr.c Yi Sun
2016-12-14 4:07 ` [PATCH v4 01/24] docs: create L2 Cache Allocation Technology (CAT) feature document Yi Sun
2016-12-14 4:07 ` [PATCH v4 02/24] x86: refactor psr: remove L3 CAT/CDP codes Yi Sun
2016-12-22 16:03 ` Jan Beulich
2016-12-26 2:28 ` Yi Sun
2016-12-14 4:07 ` [PATCH v4 03/24] x86: refactor psr: implement main data structures Yi Sun
2016-12-22 16:13 ` Jan Beulich
2016-12-26 6:56 ` Yi Sun
2017-01-03 8:00 ` Jan Beulich
2017-01-03 8:49 ` Yi Sun
2017-01-03 9:12 ` Jan Beulich
2017-01-03 10:28 ` Yi Sun
2017-01-03 11:23 ` Jan Beulich
2016-12-14 4:07 ` [PATCH v4 04/24] x86: refactor psr: implement CPU init and free flow Yi Sun
2017-01-10 11:45 ` Jan Beulich
2017-01-11 3:14 ` Yi Sun
2017-01-11 13:48 ` Jan Beulich
2017-01-12 1:07 ` Yi Sun
2016-12-14 4:07 ` [PATCH v4 05/24] x86: refactor psr: implement Domain init/free and schedule flows Yi Sun
2017-01-10 13:34 ` Jan Beulich
2017-01-11 3:17 ` Yi Sun
2016-12-14 4:07 ` [PATCH v4 06/24] x86: refactor psr: implement get hw info flow Yi Sun
2017-01-10 13:46 ` Jan Beulich
2017-01-11 5:13 ` Yi Sun
2017-01-11 13:53 ` Jan Beulich
2017-01-12 1:08 ` Yi Sun
2016-12-14 4:07 ` [PATCH v4 07/24] x86: refactor psr: implement get value flow Yi Sun
2017-01-10 13:50 ` Jan Beulich
2017-01-11 5:16 ` Yi Sun
2017-01-11 13:54 ` Jan Beulich
2017-01-12 1:09 ` Yi Sun
2016-12-14 4:07 ` [PATCH v4 08/24] x86: refactor psr: set value: implement framework Yi Sun
2017-01-10 14:17 ` Jan Beulich
2017-01-11 5:57 ` Yi Sun
2016-12-14 4:07 ` [PATCH v4 09/24] x86: refactor psr: set value: assemble features value array Yi Sun
2017-01-10 14:34 ` Jan Beulich
2017-01-11 6:07 ` Yi Sun
2017-01-11 13:57 ` Jan Beulich
2017-01-12 1:17 ` Yi Sun
2016-12-14 4:07 ` [PATCH v4 10/24] x86: refactor psr: set value: implement cos finding flow Yi Sun
2017-01-10 14:53 ` Jan Beulich
2017-01-11 6:10 ` Yi Sun
2016-12-14 4:07 ` [PATCH v4 11/24] x86: refactor psr: set value: implement cos id allocation flow Yi Sun
2017-01-10 15:08 ` Jan Beulich
2017-01-11 6:16 ` Yi Sun
2016-12-14 4:07 ` [PATCH v4 12/24] x86: refactor psr: set value: implement write msr flow Yi Sun
2017-01-10 15:15 ` Jan Beulich
2017-01-11 6:22 ` Yi Sun
2017-01-11 14:01 ` Jan Beulich
2017-01-12 1:22 ` Yi Sun
2017-01-12 9:40 ` Jan Beulich
2017-01-12 10:22 ` Yi Sun
2016-12-14 4:07 ` [PATCH v4 13/24] x86: refactor psr: implement CPU init and free flow for CDP Yi Sun
2016-12-14 4:07 ` [PATCH v4 14/24] x86: refactor psr: implement get hw info " Yi Sun
2016-12-14 4:07 ` [PATCH v4 15/24] x86: refactor psr: implement get value " Yi Sun
2016-12-14 4:07 ` [PATCH v4 16/24] x86: refactor psr: implement set value callback functions " Yi Sun
2016-12-14 4:07 ` [PATCH v4 17/24] x86: L2 CAT: implement CPU init and free flow Yi Sun
2016-12-14 4:07 ` [PATCH v4 18/24] x86: L2 CAT: implement get hw info flow Yi Sun
2016-12-14 4:07 ` [PATCH v4 19/24] x86: L2 CAT: implement get value flow Yi Sun
2016-12-14 4:08 ` [PATCH v4 20/24] x86: L2 CAT: implement set " Yi Sun
2016-12-14 4:08 ` [PATCH v4 21/24] tools: L2 CAT: support get HW info for L2 CAT Yi Sun
2017-01-06 12:04 ` Wei Liu
2017-01-09 1:19 ` Yi Sun
2017-01-09 8:31 ` Jan Beulich
2017-01-09 9:26 ` Wei Liu [this message]
2017-01-10 8:00 ` Yi Sun
2017-01-10 8:46 ` Jan Beulich
2017-01-10 9:01 ` Yi Sun
2016-12-14 4:08 ` [PATCH v4 22/24] tools: L2 CAT: support show cbm " Yi Sun
2017-01-06 12:04 ` Wei Liu
2017-01-09 1:24 ` Yi Sun
2017-01-09 10:08 ` Wei Liu
2017-01-10 7:47 ` Yi Sun
2016-12-14 4:08 ` [PATCH v4 23/24] tools: L2 CAT: support set " Yi Sun
2017-01-06 12:04 ` Wei Liu
2017-01-09 1:14 ` Yi Sun
2016-12-14 4:08 ` [PATCH v4 24/24] docs: add L2 CAT description in docs Yi Sun
2017-01-06 12:04 ` Wei Liu
2017-01-09 1:25 ` Yi Sun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170109092616.GD1100@citrix.com \
--to=wei.liu2@citrix.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=chao.p.peng@linux.intel.com \
--cc=dario.faggioli@citrix.com \
--cc=he.chen@linux.intel.com \
--cc=ian.jackson@eu.citrix.com \
--cc=mengxu@cis.upenn.edu \
--cc=xen-devel@lists.xenproject.org \
--cc=yi.y.sun@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).