Re: [PATCH v4 22/24] tools: L2 CAT: support show cbm for L2 CAT.

[Wei Liu <wei.liu2@citrix.com>]

On Mon, Jan 09, 2017 at 09:24:54AM +0800, Yi Sun wrote:
> On 17-01-06 12:04:43, Wei Liu wrote:
> > On Wed, Dec 14, 2016 at 12:08:02PM +0800, Yi Sun wrote:
> > > - 'xl psr-cat-show' is updated to show CBM of a domain
> > >   according to input cache level.
> > > 
> > > Examples:
> > > root@:~$ xl psr-cat-show -l2 1
> > > Socket ID       : 0
> > > Default CBM     : 0xff
> > >    ID                     NAME             CBM
> > >     1                 ubuntu14            0x7f
> > > 
> > > Signed-off-by: He Chen <he.chen@linux.intel.com>
> > > Signed-off-by: Yi Sun <yi.y.sun@linux.intel.com>
> > > ---
> > >  tools/libxc/include/xenctrl.h |  1 +
> > >  tools/libxc/xc_psr.c          |  3 ++
> > >  tools/libxl/libxl_types.idl   |  1 +
> > >  tools/libxl/xl_cmdimpl.c      | 81 ++++++++++++++++++++++++++++---------------
> > >  tools/libxl/xl_cmdtable.c     |  3 +-
> > >  5 files changed, 60 insertions(+), 29 deletions(-)
> > > 
> > > diff --git a/tools/libxl/libxl_types.idl b/tools/libxl/libxl_types.idl
> > > index a32c751..944b7d4 100644
> > > --- a/tools/libxl/libxl_types.idl
> > > +++ b/tools/libxl/libxl_types.idl
> > > @@ -898,6 +898,7 @@ libxl_psr_cbm_type = Enumeration("psr_cbm_type", [
> > >      (1, "L3_CBM"),
> > >      (2, "L3_CBM_CODE"),
> > >      (3, "L3_CBM_DATA"),
> > > +    (4, "L2_CBM"),
> > 
> > Need a LIBXL_HAVE macro.
> > 
> It has been defined in pathc 21, like below.
> tools/libxl/libxl.h
> #define LIBXL_HAVE_PSR_L2_CAT 1
> 

In that case please move this to patch #21.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel