[PATCH] tools/tests: add xenstore testing framework

[PATCH] tools/tests: add xenstore testing framework

[Juergen Gross]

Add tools/tests/xenstore for a framework to do tests of xenstore.
The aim is to test for correctness and performance.

Add a test program containing some tests meant to be run against any
xenstore implementation (xenstored, oxenstored, xenstore-stubdom).

It is using libxenstore for access to xenstore and supports multiple
tests to be either selected all or individually. All tests are using
/local/domain/<own-domid>/xenstore-test/<pid> as base for doing the
tests. This allows multiple instances of the program to run in
parallel.

Signed-off-by: Juergen Gross <jgross@suse.com>
---
 .gitignore                     |   1 +
 tools/tests/Makefile           |   1 +
 tools/tests/xenstore/Makefile  |  27 +++
 tools/tests/xenstore/xs-test.c | 512 +++++++++++++++++++++++++++++++++++++++++
 4 files changed, 541 insertions(+)
 create mode 100644 tools/tests/xenstore/Makefile
 create mode 100644 tools/tests/xenstore/xs-test.c

diff --git a/.gitignore b/.gitignore
index 7689596..d9982f6 100644
--- a/.gitignore
+++ b/.gitignore
@@ -212,6 +212,7 @@ tools/tests/x86_emulator/blowfish.h
 tools/tests/x86_emulator/test_x86_emulator
 tools/tests/x86_emulator/x86_emulate
 tools/tests/xen-access/xen-access
+tools/tests/xenstore/xs-test
 tools/tests/regression/installed/*
 tools/tests/regression/build/*
 tools/tests/regression/downloads/*
diff --git a/tools/tests/Makefile b/tools/tests/Makefile
index adeb120..6397761 100644
--- a/tools/tests/Makefile
+++ b/tools/tests/Makefile
@@ -12,6 +12,7 @@ SUBDIRS-y += regression
 endif
 SUBDIRS-$(CONFIG_X86) += x86_emulator
 SUBDIRS-y += xen-access
+SUBDIRS-y += xenstore
 
 .PHONY: all clean install distclean
 all clean distclean: %: subdirs-%
diff --git a/tools/tests/xenstore/Makefile b/tools/tests/xenstore/Makefile
new file mode 100644
index 0000000..6c85f98
--- /dev/null
+++ b/tools/tests/xenstore/Makefile
@@ -0,0 +1,27 @@
+XEN_ROOT=$(CURDIR)/../../..
+include $(XEN_ROOT)/tools/Rules.mk
+
+CFLAGS += -Werror
+
+CFLAGS += $(CFLAGS_libxenstore)
+
+TARGETS-y := xs-test
+TARGETS := $(TARGETS-y)
+
+.PHONY: all
+all: build
+
+.PHONY: build
+build: $(TARGETS)
+
+.PHONY: clean
+clean:
+	$(RM) *.o $(TARGETS) *~ $(DEPS)
+
+.PHONY: distclean
+distclean: clean
+
+xs-test: xs-test.o Makefile
+	$(CC) -o $@ $< $(LDFLAGS) $(LDLIBS_libxenstore)
+
+-include $(DEPS)
diff --git a/tools/tests/xenstore/xs-test.c b/tools/tests/xenstore/xs-test.c
new file mode 100644
index 0000000..980afb6
--- /dev/null
+++ b/tools/tests/xenstore/xs-test.c
@@ -0,0 +1,512 @@
+/*
+ * xs-test.c
+ *
+ * Do Xenstore tests.
+ *
+ * Copyright (C) 2016  Juergen Gross <jgross@suse.com>,
+ *                     SUSE Linux GmbH
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms and conditions of the GNU General Public
+ * License, version 2, as published by the Free Software Foundation.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the GNU
+ * General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public
+ * License along with this program; If not, see <http://www.gnu.org/licenses/>.
+ */
+
+#define _GNU_SOURCE
+#include <getopt.h>
+#include <inttypes.h>
+#include <stdbool.h>
+#include <stdio.h>
+#include <stdlib.h>
+#include <string.h>
+#include <unistd.h>
+#include <time.h>
+#include <xenstore.h>
+
+#define TEST_PATH "xenstore-test"
+#define ARRAY_SIZE(a) (sizeof(a) / sizeof(a[0]))
+#define WRITE_BUFFERS_N    10
+#define WRITE_BUFFERS_SIZE 4000
+#define MAX_TA_LOOPS       100
+
+struct test {
+    char *name;
+    int (*func_init)(uintptr_t par);
+    int (*func)(uintptr_t par);
+    int (*func_deinit)(uintptr_t par);
+    uintptr_t par;
+    char *descr;
+};
+
+static struct xs_handle *xsh;
+static char *path;
+static char *paths[WRITE_BUFFERS_N];
+static char write_buffers[WRITE_BUFFERS_N][WRITE_BUFFERS_SIZE];
+static int ta_loops;
+
+static struct option options[] = {
+    { "list-tests", 0, NULL, 'l' },
+    { "test", 1, NULL, 't' },
+    { "random", 1, NULL, 'r' },
+    { "help", 0, NULL, 'h' },
+    { "iterations", 1, NULL, 'i' },
+    { NULL, 0, NULL, 0 }
+};
+
+static int call_test(struct test *tst, int iters, bool no_clock)
+{
+    char *stage = "?";
+    struct timespec tp1, tp2;
+    uint64_t nsec, nsec_min, nsec_max, nsec_sum;
+    int i, ret;
+
+    nsec_min = -1;
+    nsec_max = 0;
+    nsec_sum = 0;
+
+    for ( i = 0; i < iters; i++ )
+    {
+        stage = "pre-init";
+        xs_rm(xsh, XBT_NULL, path);
+        if ( !xs_write(xsh, XBT_NULL, path, "", 0) )
+        {
+            ret = errno;
+            break;
+        }
+        stage = "init";
+        ret = tst->func_init(tst->par);
+        if ( ret )
+            break;
+        if ( clock_gettime(CLOCK_REALTIME, &tp1) )
+            no_clock = true;
+        stage = "run";
+        ret = tst->func(tst->par);
+        if ( ret )
+            break;
+        if ( clock_gettime(CLOCK_REALTIME, &tp2) )
+            no_clock = true;
+        if ( !no_clock )
+        {
+            nsec = tp2.tv_sec * 1000000000 + tp2.tv_nsec -
+                   tp1.tv_sec * 1000000000 - tp1.tv_nsec;
+            if ( nsec < nsec_min )
+                nsec_min = nsec;
+            if ( nsec > nsec_max )
+                nsec_max = nsec;
+            nsec_sum += nsec;
+        }
+        stage = "deinit";
+        ret = tst->func_deinit(tst->par);
+        if ( ret )
+            break;
+    }
+
+    if ( ret )
+        printf("%-10s: failed (ret = %d, stage %s)\n", tst->name, ret, stage);
+    else if ( !no_clock )
+    {
+        printf("%-10s:", tst->name);
+        if ( iters > 1 )
+            printf(" avg: %"PRIu64" ns (%"PRIu64" ns .. %"PRIu64" ns)",
+                   nsec_sum / iters, nsec_min, nsec_max);
+        else
+            printf(" %"PRIu64" ns", nsec_sum);
+        printf("\n");
+    }
+
+    return ret;
+}
+
+static void usage(int ret)
+{
+    FILE *out;
+
+    out = ret ? stderr : stdout;
+
+    fprintf(out, "usage: xs-test [<options>]\n");
+    fprintf(out, "  <options> are:\n");
+    fprintf(out, "  -i|--iterations <i>  perform each test <i> times (default 1)\n");
+    fprintf(out, "  -l|--list-tests      list available tests\n");
+    fprintf(out, "  -r|--random <time>   perform random tests for <time> seconds\n");
+    fprintf(out, "  -t|--test <test>     run <test> (default is all tests)\n");
+    fprintf(out, "  -h|--help            print this usage information\n");
+    exit(ret);
+}
+
+static int ret0(uintptr_t par)
+{
+    return 0;
+}
+
+static int verify_node(char *node, char *data, unsigned int size)
+{
+    char *buf;
+    unsigned int len;
+    int ret;
+
+    buf = xs_read(xsh, XBT_NULL, node, &len);
+    if ( !buf )
+        return errno;
+
+    ret = (len == size && !memcmp(buf, data, len)) ? 0 : ENODATA;
+    free(buf);
+
+    return ret;
+}
+
+static int test_read_init(uintptr_t par)
+{
+    if ( par > WRITE_BUFFERS_SIZE )
+        return EFBIG;
+    return xs_write(xsh, XBT_NULL, paths[0], write_buffers[0], par) ? 0 : errno;
+}
+
+static int test_read(uintptr_t par)
+{
+    char *buf;
+    unsigned int len;
+
+    buf = xs_read(xsh, XBT_NULL, paths[0], &len);
+    if ( !buf )
+        return errno;
+    free(buf);
+    return 0;
+}
+
+#define test_read_deinit ret0
+
+static int test_write_init(uintptr_t par)
+{
+    return (par > WRITE_BUFFERS_SIZE) ? EFBIG : 0;
+}
+
+static int test_write(uintptr_t par)
+{
+    return xs_write(xsh, XBT_NULL, paths[0], write_buffers[0], par) ? 0 : errno;
+}
+
+static int test_write_deinit(uintptr_t par)
+{
+    return verify_node(paths[0], write_buffers[0], par);
+}
+
+static int test_dir_init(uintptr_t par)
+{
+    unsigned int i;
+
+    for (i = 0; i < WRITE_BUFFERS_N; i++)
+        if ( !xs_write(xsh, XBT_NULL, paths[i], write_buffers[i], 1) )
+            return errno;
+
+    return 0;
+}
+
+static int test_dir(uintptr_t par)
+{
+    char **dir;
+    unsigned int num;
+
+    dir = xs_directory(xsh, XBT_NULL, path, &num);
+    if ( !dir )
+        return errno;
+
+    free(dir);
+    return 0;
+}
+
+static int test_dir_deinit(uintptr_t par)
+{
+    char **dir;
+    unsigned int i, j, num;
+    int rc = 0;
+
+    dir = xs_directory(xsh, XBT_NULL, path, &num);
+    if ( !dir )
+        return errno;
+
+    for (j = 0; j < WRITE_BUFFERS_N; j++)
+    {
+        for (i = 0; i < num; i++)
+            if ( dir[i][0] == 'a' + j && dir[i][1] == 0 )
+                break;
+        if ( i == num )
+            rc = ENODATA;
+    }
+    if ( num != WRITE_BUFFERS_N )
+            rc = ENODATA;
+    free(dir);
+    return rc;
+}
+
+static int test_rm_init(uintptr_t par)
+{
+    unsigned int i;
+
+    if ( par > WRITE_BUFFERS_N )
+        return EFBIG;
+
+    for (i = 0; i < par; i++)
+        if ( xs_write(xsh, XBT_NULL, paths[i], write_buffers[i], 1) )
+            return errno;
+
+    return 0;
+}
+
+static int test_rm(uintptr_t par)
+{
+    if ( !xs_rm(xsh, XBT_NULL, path) )
+        return errno;
+
+    return 0;
+}
+
+#define test_rm_deinit ret0
+
+#define test_ta1_init ret0
+
+static int test_ta1(uintptr_t par)
+{
+    xs_transaction_t t;
+    int l;
+
+    for (l= 0; l < MAX_TA_LOOPS; l++)
+    {
+        t = xs_transaction_start(xsh);
+        if ( t == XBT_NULL )
+            return errno;
+        if ( xs_transaction_end(xsh, t, par ? true : false) )
+            return 0;
+        if ( errno != EAGAIN )
+            return errno;
+    }
+
+    ta_loops++;
+    return 0;
+}
+
+#define test_ta1_deinit ret0
+
+static int test_ta2_init(uintptr_t par)
+{
+    return xs_write(xsh, XBT_NULL, paths[0], write_buffers[0], 1) ? 0 : errno;
+}
+
+static int test_ta2(uintptr_t par)
+{
+    xs_transaction_t t;
+    char *buf;
+    unsigned int len;
+    int ret;
+    int l;
+
+    for (l= 0; l < MAX_TA_LOOPS; l++)
+    {
+        t = xs_transaction_start(xsh);
+        if ( t == XBT_NULL )
+            return errno;
+        buf = xs_read(xsh, t, paths[0], &len);
+        if ( !buf )
+            goto out;
+        free(buf);
+        if ( !xs_write(xsh, t, paths[0], "b", 1) )
+            goto out;
+        buf = xs_read(xsh, t, paths[0], &len);
+        if ( !buf )
+            goto out;
+        errno = (len == 1 && buf[0] == 'b') ? 0 : ENODATA;
+        free(buf);
+        if ( errno )
+            goto out;
+        buf = xs_read(xsh, XBT_NULL, paths[0], &len);
+        if ( !buf )
+            goto out;
+        errno = (len == 1 && buf[0] == 'a') ? 0 : ENODATA;
+        free(buf);
+        if ( errno )
+            goto out;
+        if ( xs_transaction_end(xsh, t, par ? true : false) )
+            return 0;
+        if ( errno != EAGAIN )
+            return errno;
+    }
+
+    ta_loops++;
+    return 0;
+
+ out:
+    ret = errno;
+    xs_transaction_end(xsh, t, true);
+    return ret;
+}
+
+static int test_ta2_deinit(uintptr_t par)
+{
+    return verify_node(paths[0], par ? "a" : "b", 1);
+}
+
+static int test_ta3_init(uintptr_t par)
+{
+    return xs_write(xsh, XBT_NULL, paths[0], write_buffers[0], 1) ? 0 : errno;
+}
+
+static int test_ta3(uintptr_t par)
+{
+    xs_transaction_t t;
+    char *buf;
+    unsigned int len;
+    int ret;
+
+    t = xs_transaction_start(xsh);
+    if ( t == XBT_NULL )
+        return errno;
+    buf = xs_read(xsh, t, paths[0], &len);
+    if ( !buf )
+        goto out;
+    free(buf);
+    if ( !xs_write(xsh, XBT_NULL, paths[0], "b", 1) )
+        goto out;
+    buf = xs_read(xsh, t, paths[0], &len);
+    if ( !buf )
+        goto out;
+    errno = (len == 1 && buf[0] == 'a') ? 0 : ENODATA;
+    free(buf);
+    if ( errno )
+        goto out;
+    if ( !xs_write(xsh, t, paths[0], "c", 1) )
+        goto out;
+    buf = xs_read(xsh, t, paths[0], &len);
+    if ( !buf )
+        goto out;
+    errno = (len == 1 && buf[0] == 'c') ? 0 : ENODATA;
+    free(buf);
+    if ( errno )
+        goto out;
+    if ( xs_transaction_end(xsh, t, false) || errno != EAGAIN )
+        return ENODATA;
+    return 0;
+
+ out:
+    ret = errno;
+    xs_transaction_end(xsh, t, true);
+    return ret;
+}
+
+static int test_ta3_deinit(uintptr_t par)
+{
+    return verify_node(paths[0], "b", 1);
+}
+
+#define TEST(s, f, p, l) { s, f ## _init, f, f ## _deinit, (uintptr_t)(p), l }
+struct test tests[] = {
+TEST("read 1", test_read, 1, "Read node with 1 byte data"),
+TEST("read 3000", test_write, 3000, "Write node with 3000 bytes data"),
+TEST("write 1", test_write, 1, "Write node with 1 byte data"),
+TEST("write 3000", test_read, 3000, "Read node with 3000 bytes data"),
+TEST("dir", test_dir, 0, "List directory"),
+TEST("rm node", test_rm, 0, "Remove single node"),
+TEST("rm dir", test_rm, WRITE_BUFFERS_N, "Remove node with sub-nodes"),
+TEST("ta empty", test_ta1, 0, "Empty transaction"),
+TEST("ta empty x", test_ta1, 1, "Empty transaction abort"),
+TEST("ta rmw", test_ta2, 0, "Read-modify-write transaction"),
+TEST("ta rmw x", test_ta2, 1, "Read-modify-write transaction abort"),
+TEST("ta err", test_ta3, 0, "Transaction with conflict"),
+};
+
+int main(int argc, char *argv[])
+{
+    int opt, t, iters = 1, ret = 0, randtime = 0;
+    char *test = NULL;
+    bool list = false;
+    time_t stop;
+
+    while ( (opt = getopt_long(argc, argv, "lr:t:hi:", options,
+                               NULL)) != -1 )
+    {
+        switch (opt)
+        {
+        case 'i':
+            iters = atoi(optarg);
+            break;
+        case 'l':
+            list = true;
+            break;
+        case 'r':
+            randtime = atoi(optarg);
+            break;
+        case 't':
+            test = optarg;
+            break;
+        case 'h':
+            usage(0);
+            break;
+        }
+    }
+    if ( optind != argc )
+        usage(1);
+
+    if ( list )
+    {
+        for ( t = 0; t < ARRAY_SIZE(tests); t++ )
+            printf("%-10s: %s\n", tests[t].name, tests[t].descr);
+        return 0;
+    }
+
+    asprintf(&path, "%s/%u", TEST_PATH, getpid());
+    for ( t = 0; t < WRITE_BUFFERS_N; t++ )
+    {
+        memset(write_buffers[t], 'a' + t, WRITE_BUFFERS_SIZE);
+        asprintf(&paths[t], "%s/%c", path, 'a' + t);
+    }
+
+    xsh = xs_open(0);
+    if ( !xsh )
+    {
+        fprintf(stderr, "could not connect to xenstore\n");
+        exit(2);
+    }
+
+    if ( randtime )
+    {
+        stop = time(NULL) + randtime;
+        srandom((unsigned int)stop);
+
+        while ( time(NULL) < stop )
+        {
+            t = random() % ARRAY_SIZE(tests);
+            ret = call_test(tests + t, iters, true);
+        }
+    }
+    else
+        for ( t = 0; t < ARRAY_SIZE(tests); t++ )
+        {
+            if ( !test || !strcmp(test, tests[t].name) )
+                ret = call_test(tests + t, iters, false);
+        }
+
+    if ( !ret )
+        xs_rm(xsh, XBT_NULL, path);
+
+    xs_close(xsh);
+
+    if ( ta_loops )
+        printf("Exhaustive transaction retries (%d) occurrred %d times.\n",
+               MAX_TA_LOOPS, ta_loops);
+
+    return 0;
+}
+
+/*
+ * Local variables:
+ * mode: C
+ * c-file-style: "BSD"
+ * c-basic-offset: 4
+ * indent-tabs-mode: nil
+ * End:
+ */
-- 
2.10.2


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] tools/tests: add xenstore testing framework

[Wei Liu]

On Wed, Jan 18, 2017 at 01:33:48PM +0100, Juergen Gross wrote:
> Add tools/tests/xenstore for a framework to do tests of xenstore.
> The aim is to test for correctness and performance.
> 
> Add a test program containing some tests meant to be run against any
> xenstore implementation (xenstored, oxenstored, xenstore-stubdom).
> 
> It is using libxenstore for access to xenstore and supports multiple
> tests to be either selected all or individually. All tests are using
> /local/domain/<own-domid>/xenstore-test/<pid> as base for doing the
> tests. This allows multiple instances of the program to run in
> parallel.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

Thank you for doing this work!

The only complaint I have is the code seems to be mixing hypervisor and
toolstack coding style.

Wei.

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] tools/tests: add xenstore testing framework

[Juergen Gross]

On 18/01/17 13:41, Wei Liu wrote:
> On Wed, Jan 18, 2017 at 01:33:48PM +0100, Juergen Gross wrote:
>> Add tools/tests/xenstore for a framework to do tests of xenstore.
>> The aim is to test for correctness and performance.
>>
>> Add a test program containing some tests meant to be run against any
>> xenstore implementation (xenstored, oxenstored, xenstore-stubdom).
>>
>> It is using libxenstore for access to xenstore and supports multiple
>> tests to be either selected all or individually. All tests are using
>> /local/domain/<own-domid>/xenstore-test/<pid> as base for doing the
>> tests. This allows multiple instances of the program to run in
>> parallel.
>>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
> 
> Thank you for doing this work!
> 
> The only complaint I have is the code seems to be mixing hypervisor and
> toolstack coding style.

Sorry, I don't see it. Where do I use coding style not compliant to
./CODING_STYLE ?

Juergen


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] tools/tests: add xenstore testing framework

[Juergen Gross]

On 18/01/17 13:33, Juergen Gross wrote:
> Add tools/tests/xenstore for a framework to do tests of xenstore.
> The aim is to test for correctness and performance.
> 
> Add a test program containing some tests meant to be run against any
> xenstore implementation (xenstored, oxenstored, xenstore-stubdom).
> 
> It is using libxenstore for access to xenstore and supports multiple
> tests to be either selected all or individually. All tests are using
> /local/domain/<own-domid>/xenstore-test/<pid> as base for doing the
> tests. This allows multiple instances of the program to run in
> parallel.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>
> ---

> +TEST("read 1", test_read, 1, "Read node with 1 byte data"),
> +TEST("read 3000", test_write, 3000, "Write node with 3000 bytes data"),
> +TEST("write 1", test_write, 1, "Write node with 1 byte data"),
> +TEST("write 3000", test_read, 3000, "Read node with 3000 bytes data"),

No idea how it happened, but there is some confusion with read/write
3000 tests.

I will send V2 after waiting for comments a little bit longer...


Juergen


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] tools/tests: add xenstore testing framework

[Wei Liu]

On Wed, Jan 18, 2017 at 01:47:17PM +0100, Juergen Gross wrote:
> On 18/01/17 13:41, Wei Liu wrote:
> > On Wed, Jan 18, 2017 at 01:33:48PM +0100, Juergen Gross wrote:
> >> Add tools/tests/xenstore for a framework to do tests of xenstore.
> >> The aim is to test for correctness and performance.
> >>
> >> Add a test program containing some tests meant to be run against any
> >> xenstore implementation (xenstored, oxenstored, xenstore-stubdom).
> >>
> >> It is using libxenstore for access to xenstore and supports multiple
> >> tests to be either selected all or individually. All tests are using
> >> /local/domain/<own-domid>/xenstore-test/<pid> as base for doing the
> >> tests. This allows multiple instances of the program to run in
> >> parallel.
> >>
> >> Signed-off-by: Juergen Gross <jgross@suse.com>
> > 
> > Thank you for doing this work!
> > 
> > The only complaint I have is the code seems to be mixing hypervisor and
> > toolstack coding style.
> 
> Sorry, I don't see it. Where do I use coding style not compliant to
> ./CODING_STYLE ?
> 

+static int test_dir_init(uintptr_t par)
+{
+    unsigned int i;
+
+    for (i = 0; i < WRITE_BUFFERS_N; i++)

Here and a bunch of other places.

There are places where there is space after '('. It looks to me you
wished to follow hypervisor side coding style.

Wei.


> Juergen
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] tools/tests: add xenstore testing framework

[Juergen Gross]

On 18/01/17 15:47, Wei Liu wrote:
> On Wed, Jan 18, 2017 at 01:47:17PM +0100, Juergen Gross wrote:
>> On 18/01/17 13:41, Wei Liu wrote:
>>> On Wed, Jan 18, 2017 at 01:33:48PM +0100, Juergen Gross wrote:
>>>> Add tools/tests/xenstore for a framework to do tests of xenstore.
>>>> The aim is to test for correctness and performance.
>>>>
>>>> Add a test program containing some tests meant to be run against any
>>>> xenstore implementation (xenstored, oxenstored, xenstore-stubdom).
>>>>
>>>> It is using libxenstore for access to xenstore and supports multiple
>>>> tests to be either selected all or individually. All tests are using
>>>> /local/domain/<own-domid>/xenstore-test/<pid> as base for doing the
>>>> tests. This allows multiple instances of the program to run in
>>>> parallel.
>>>>
>>>> Signed-off-by: Juergen Gross <jgross@suse.com>
>>>
>>> Thank you for doing this work!
>>>
>>> The only complaint I have is the code seems to be mixing hypervisor and
>>> toolstack coding style.
>>
>> Sorry, I don't see it. Where do I use coding style not compliant to
>> ./CODING_STYLE ?
>>
> 
> +static int test_dir_init(uintptr_t par)
> +{
> +    unsigned int i;
> +
> +    for (i = 0; i < WRITE_BUFFERS_N; i++)
> 
> Here and a bunch of other places.

Aah, okay. Missed those, yes.

> There are places where there is space after '('. It looks to me you
> wished to follow hypervisor side coding style.

Yep. That was the plan.

I'll update those with V2.


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] tools/tests: add xenstore testing framework

[Juergen Gross]

On 18/01/17 13:33, Juergen Gross wrote:
> Add tools/tests/xenstore for a framework to do tests of xenstore.
> The aim is to test for correctness and performance.
> 
> Add a test program containing some tests meant to be run against any
> xenstore implementation (xenstored, oxenstored, xenstore-stubdom).
> 
> It is using libxenstore for access to xenstore and supports multiple
> tests to be either selected all or individually. All tests are using
> /local/domain/<own-domid>/xenstore-test/<pid> as base for doing the
> tests. This allows multiple instances of the program to run in
> parallel.
> 
> Signed-off-by: Juergen Gross <jgross@suse.com>

BTW: when running the tests against oxenstored I discovered that
oxenstored is applying the default Xenstore entry size limit of 2000
bytes for dom0, too. All other limits are effective for domUs only.
Is this on purpose?


Juergen


_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] tools/tests: add xenstore testing framework

[Wei Liu]

On Wed, Jan 18, 2017 at 04:16:22PM +0100, Juergen Gross wrote:
> On 18/01/17 13:33, Juergen Gross wrote:
> > Add tools/tests/xenstore for a framework to do tests of xenstore.
> > The aim is to test for correctness and performance.
> > 
> > Add a test program containing some tests meant to be run against any
> > xenstore implementation (xenstored, oxenstored, xenstore-stubdom).
> > 
> > It is using libxenstore for access to xenstore and supports multiple
> > tests to be either selected all or individually. All tests are using
> > /local/domain/<own-domid>/xenstore-test/<pid> as base for doing the
> > tests. This allows multiple instances of the program to run in
> > parallel.
> > 
> > Signed-off-by: Juergen Gross <jgross@suse.com>
> 
> BTW: when running the tests against oxenstored I discovered that
> oxenstored is applying the default Xenstore entry size limit of 2000
> bytes for dom0, too. All other limits are effective for domUs only.
> Is this on purpose?
> 

I don't know.

CC our oxenstored maintainer for input.

> 
> Juergen
> 

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] tools/tests: add xenstore testing framework

[Andrew Cooper]

On 18/01/17 15:16, Juergen Gross wrote:
> On 18/01/17 13:33, Juergen Gross wrote:
>> Add tools/tests/xenstore for a framework to do tests of xenstore.
>> The aim is to test for correctness and performance.
>>
>> Add a test program containing some tests meant to be run against any
>> xenstore implementation (xenstored, oxenstored, xenstore-stubdom).
>>
>> It is using libxenstore for access to xenstore and supports multiple
>> tests to be either selected all or individually. All tests are using
>> /local/domain/<own-domid>/xenstore-test/<pid> as base for doing the
>> tests. This allows multiple instances of the program to run in
>> parallel.
>>
>> Signed-off-by: Juergen Gross <jgross@suse.com>
> BTW: when running the tests against oxenstored I discovered that
> oxenstored is applying the default Xenstore entry size limit of 2000
> bytes for dom0, too. All other limits are effective for domUs only.
> Is this on purpose?

I presume not.  dom0 is supposed to be immune to all quota-related
restrictions.

~Andrew

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] tools/tests: add xenstore testing framework

[David Scott]

> On 18 Jan 2017, at 15:23, Wei Liu <wei.liu2@citrix.com> wrote:
> 
> On Wed, Jan 18, 2017 at 04:16:22PM +0100, Juergen Gross wrote:
>> On 18/01/17 13:33, Juergen Gross wrote:
>>> Add tools/tests/xenstore for a framework to do tests of xenstore.
>>> The aim is to test for correctness and performance.

This is a great idea!

>>> 
>>> Add a test program containing some tests meant to be run against any
>>> xenstore implementation (xenstored, oxenstored, xenstore-stubdom).
>>> 
>>> It is using libxenstore for access to xenstore and supports multiple
>>> tests to be either selected all or individually. All tests are using
>>> /local/domain/<own-domid>/xenstore-test/<pid> as base for doing the
>>> tests. This allows multiple instances of the program to run in
>>> parallel.
>>> 
>>> Signed-off-by: Juergen Gross <jgross@suse.com>
>> 
>> BTW: when running the tests against oxenstored I discovered that
>> oxenstored is applying the default Xenstore entry size limit of 2000
>> bytes for dom0, too. All other limits are effective for domUs only.
>> Is this on purpose?
>> 
> 
> I don't know.
> 
> CC our oxenstored maintainer for input.

I don’t think it’s on purpose— I suspect the code evolved a bit, and dom0 was exempted from one quota but not another.

I think it makes sense to be consistent and to enforce the quotas for domUs only.

Cheers,
Dave
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel

Re: [PATCH] tools/tests: add xenstore testing framework

[Juergen Gross]

On 18/01/17 18:59, David Scott wrote:
> 
>> On 18 Jan 2017, at 15:23, Wei Liu <wei.liu2@citrix.com> wrote:
>>
>> On Wed, Jan 18, 2017 at 04:16:22PM +0100, Juergen Gross wrote:
>>> On 18/01/17 13:33, Juergen Gross wrote:
>>>> Add tools/tests/xenstore for a framework to do tests of xenstore.
>>>> The aim is to test for correctness and performance.
> 
> This is a great idea!

When you are doing critical changes to xenstore this is kind of
mandatory. ;-)

>>>>
>>>> Add a test program containing some tests meant to be run against any
>>>> xenstore implementation (xenstored, oxenstored, xenstore-stubdom).
>>>>
>>>> It is using libxenstore for access to xenstore and supports multiple
>>>> tests to be either selected all or individually. All tests are using
>>>> /local/domain/<own-domid>/xenstore-test/<pid> as base for doing the
>>>> tests. This allows multiple instances of the program to run in
>>>> parallel.
>>>>
>>>> Signed-off-by: Juergen Gross <jgross@suse.com>
>>>
>>> BTW: when running the tests against oxenstored I discovered that
>>> oxenstored is applying the default Xenstore entry size limit of 2000
>>> bytes for dom0, too. All other limits are effective for domUs only.
>>> Is this on purpose?
>>>
>>
>> I don't know.
>>
>> CC our oxenstored maintainer for input.
> 
> I don’t think it’s on purpose— I suspect the code evolved a bit, and dom0 was exempted from one quota but not another.
> 
> I think it makes sense to be consistent and to enforce the quotas for domUs only.

Nice. First bug found by the test program. :-)


Juergen

_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel