From mboxrd@z Thu Jan 1 00:00:00 1970 From: Wei Liu Subject: Re: [PATCH RFC 2/8] golang/xenlight: Add error constants and standard handling Date: Thu, 19 Jan 2017 16:15:01 +0000 Message-ID: <20170119161500.GQ5089@citrix.com> References: <1484769406-17416-1-git-send-email-ronladred@gmail.com> <1484769406-17416-2-git-send-email-ronladred@gmail.com> <1484777791.7492.118.camel@citrix.com> <20170119151337.GB21971@fedora.fios-router.home> <4bf134fd-b985-3579-41ef-e61a30aa8889@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <4bf134fd-b985-3579-41ef-e61a30aa8889@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: George Dunlap Cc: Ronald Rojas , Dario Faggioli , ian.jackson@eu.citrix.com, wei.liu2@citrix.com, xen-devel@lists.xen.org List-Id: xen-devel@lists.xenproject.org T24gVGh1LCBKYW4gMTksIDIwMTcgYXQgMDQ6MDI6NDZQTSArMDAwMCwgR2VvcmdlIER1bmxhcCB3 cm90ZToKPiBPbiAxOS8wMS8xNyAxNToxMywgUm9uYWxkIFJvamFzIHdyb3RlOgo+ID4gT24gV2Vk LCBKYW4gMTgsIDIwMTcgYXQgMTE6MTY6MzFQTSArMDEwMCwgRGFyaW8gRmFnZ2lvbGkgd3JvdGU6 Cj4gPj4gT24gV2VkLCAyMDE3LTAxLTE4IGF0IDE0OjU2IC0wNTAwLCBSb25hbGQgUm9qYXMgd3Jv dGU6Cj4gPj4+IENyZWF0ZSBlcnJvciB0eXBlIEVycm9yeGwgZm9yIHRocm93aW5nIHByb3BlciB4 ZW5saWdodAo+ID4+PiBlcnJvcnMuCj4gPj4+Cj4gPj4+IFVwZGF0ZSBDdHggZnVuY3Rpb25zIHRv IHRocm93IEVycm9yeGwgZXJyb3JzLgo+ID4+Pgo+ID4+PiBTaWduZWQtb2ZmLWJ5OiBSb25hbGQg Um9qYXMgPHJvbmxhZHJlZEBnbWFpbC5jb20+Cj4gPj4+IC0tLQo+ID4+PiAgdG9vbHMvZ29sYW5n L3hlbmxpZ2h0L3hlbmxpZ2h0LmdvIHwgNzcKPiA+Pj4gKysrKysrKysrKysrKysrKysrKysrKysr KysrKysrKysrKysrKy0tCj4gPj4+ICAxIGZpbGUgY2hhbmdlZCwgNzMgaW5zZXJ0aW9ucygrKSwg NCBkZWxldGlvbnMoLSkKPiA+Pj4KPiA+Pj4gZGlmZiAtLWdpdCBhL3Rvb2xzL2dvbGFuZy94ZW5s aWdodC94ZW5saWdodC5nbwo+ID4+PiBiL3Rvb2xzL2dvbGFuZy94ZW5saWdodC94ZW5saWdodC5n bwo+ID4+PiBpbmRleCAxZjEwZTUxLi5kNThmOGI4IDEwMDY0NAo+ID4+PiAtLS0gYS90b29scy9n b2xhbmcveGVubGlnaHQveGVubGlnaHQuZ28KPiA+Pj4gKysrIGIvdG9vbHMvZ29sYW5nL3hlbmxp Z2h0L3hlbmxpZ2h0LmdvCj4gPj4+IEBAIC0zMiw2ICszMiw3NyBAQCBpbXBvcnQgKAo+ID4+PiAg KQo+ID4+PiAgCj4gPj4+ICAvKgo+ID4+PiArICogRXJyb3JzCj4gPj4+ICsgKi8KPiA+Pj4gK3R5 cGUgRXJyb3J4bCBpbnQKPiA+Pj4gKwo+ID4+PiArY29uc3QgKAo+ID4+PiArCUVycm9yTm9uc3Bl Y2lmaWMgICAgICAgICAgICAgICAgICA9IEVycm9yeGwoLQo+ID4+PiBDLkVSUk9SX05PTlNQRUNJ RklDKQo+ID4+PiArCUVycm9yVmVyc2lvbiAgICAgICAgICAgICAgICAgICAgICA9IEVycm9yeGwo LQo+ID4+PiBDLkVSUk9SX1ZFUlNJT04pCj4gPj4+ICsJRXJyb3JGYWlsICAgICAgICAgICAgICAg ICAgICAgICAgID0gRXJyb3J4bCgtQy5FUlJPUl9GQUlMKQo+ID4+PiArCUVycm9yTmkgICAgICAg ICAgICAgICAgICAgICAgICAgICA9IEVycm9yeGwoLUMuRVJST1JfTkkpCj4gPj4+ICsJRXJyb3JO b21lbSAgICAgICAgICAgICAgICAgICAgICAgID0gRXJyb3J4bCgtQy5FUlJPUl9OT01FTSkKPiA+ Pj4gKwlFcnJvckludmFsICAgICAgICAgICAgICAgICAgICAgICAgPSBFcnJvcnhsKC1DLkVSUk9S X0lOVkFMKQo+ID4+PiArCUVycm9yQmFkZmFpbCAgICAgICAgICAgICAgICAgICAgICA9IEVycm9y eGwoLQo+ID4+PiBDLkVSUk9SX0JBREZBSUwpCj4gPj4+ICsJRXJyb3JHdWVzdFRpbWVkb3V0ICAg ICAgICAgICAgICAgID0gRXJyb3J4bCgtCj4gPj4+IEMuRVJST1JfR1VFU1RfVElNRURPVVQpCj4g Pj4+ICsJRXJyb3JUaW1lZG91dCAgICAgICAgICAgICAgICAgICAgID0gRXJyb3J4bCgtCj4gPj4+ IEMuRVJST1JfVElNRURPVVQpCj4gPj4+ICsJRXJyb3JOb3BhcmF2aXJ0ICAgICAgICAgICAgICAg ICAgID0gRXJyb3J4bCgtCj4gPj4+IEMuRVJST1JfTk9QQVJBVklSVCkKPiA+Pj4gKwlFcnJvck5v dFJlYWR5ICAgICAgICAgICAgICAgICAgICAgPSBFcnJvcnhsKC0KPiA+Pj4gQy5FUlJPUl9OT1Rf UkVBRFkpCj4gPj4+ICsJRXJyb3JPc2V2ZW50UmVnRmFpbCAgICAgICAgICAgICAgID0gRXJyb3J4 bCgtCj4gPj4+IEMuRVJST1JfT1NFVkVOVF9SRUdfRkFJTCkKPiA+Pj4gKwlFcnJvckJ1ZmZlcmZ1 bGwgICAgICAgICAgICAgICAgICAgPSBFcnJvcnhsKC0KPiA+Pj4gQy5FUlJPUl9CVUZGRVJGVUxM KQo+ID4+PiArCUVycm9yVW5rbm93bkNoaWxkICAgICAgICAgICAgICAgICA9IEVycm9yeGwoLQo+ ID4+PiBDLkVSUk9SX1VOS05PV05fQ0hJTEQpCj4gPj4+ICsJRXJyb3JMb2NrRmFpbCAgICAgICAg ICAgICAgICAgICAgID0gRXJyb3J4bCgtCj4gPj4+IEMuRVJST1JfTE9DS19GQUlMKQo+ID4+PiAr CUVycm9ySnNvbkNvbmZpZ0VtcHR5ICAgICAgICAgICAgICA9IEVycm9yeGwoLQo+ID4+PiBDLkVS Uk9SX0pTT05fQ09ORklHX0VNUFRZKQo+ID4+PiArCUVycm9yRGV2aWNlRXhpc3RzICAgICAgICAg ICAgICAgICA9IEVycm9yeGwoLQo+ID4+PiBDLkVSUk9SX0RFVklDRV9FWElTVFMpCj4gPj4+ICsJ RXJyb3JDaGVja3BvaW50RGV2b3BzRG9lc05vdE1hdGNoID0gRXJyb3J4bCgtCj4gPj4+IEMuRVJS T1JfQ0hFQ0tQT0lOVF9ERVZPUFNfRE9FU19OT1RfTUFUQ0gpCj4gPj4+ICsJRXJyb3JDaGVja3Bv aW50RGV2aWNlTm90U3VwcG9ydGVkID0gRXJyb3J4bCgtCj4gPj4+IEMuRVJST1JfQ0hFQ0tQT0lO VF9ERVZJQ0VfTk9UX1NVUFBPUlRFRCkKPiA+Pj4gKwlFcnJvclZudW1hQ29uZmlnSW52YWxpZCAg ICAgICAgICAgPSBFcnJvcnhsKC0KPiA+Pj4gQy5FUlJPUl9WTlVNQV9DT05GSUdfSU5WQUxJRCkK PiA+Pj4gKwlFcnJvckRvbWFpbk5vdGZvdW5kICAgICAgICAgICAgICAgPSBFcnJvcnhsKC0KPiA+ Pj4gQy5FUlJPUl9ET01BSU5fTk9URk9VTkQpCj4gPj4+ICsJRXJyb3JBYm9ydGVkICAgICAgICAg ICAgICAgICAgICAgID0gRXJyb3J4bCgtCj4gPj4+IEMuRVJST1JfQUJPUlRFRCkKPiA+Pj4gKwlF cnJvck5vdGZvdW5kICAgICAgICAgICAgICAgICAgICAgPSBFcnJvcnhsKC0KPiA+Pj4gQy5FUlJP Ul9OT1RGT1VORCkKPiA+Pj4gKwlFcnJvckRvbWFpbkRlc3Ryb3llZCAgICAgICAgICAgICAgPSBF cnJvcnhsKC0KPiA+Pj4gQy5FUlJPUl9ET01BSU5fREVTVFJPWUVEKQo+ID4+PiArCUVycm9yRmVh dHVyZVJlbW92ZWQgICAgICAgICAgICAgICA9IEVycm9yeGwoLQo+ID4+PiBDLkVSUk9SX0ZFQVRV UkVfUkVNT1ZFRCkKPiA+Pj4gKykKPiA+Pj4gKwo+ID4+PiArdmFyIGVycm9ycyA9IFsuLi5dc3Ry aW5newo+ID4+PiArCUVycm9yTm9uc3BlY2lmaWM6ICAgICAgICAgICAgICAgICAgIk5vbi1zcGVj aWZpYyBlcnJvciIsCj4gPj4+ICsJRXJyb3JWZXJzaW9uOiAgICAgICAgICAgICAgICAgICAgICAi V3JvbmcgdmVyc2lvbiIsCj4gPj4+ICsJRXJyb3JGYWlsOiAgICAgICAgICAgICAgICAgICAgICAg ICAiRmFpbGVkIiwKPiA+Pj4gKwlFcnJvck5pOiAgICAgICAgICAgICAgICAgICAgICAgICAgICJO dWxsIiwKPiA+Pj4gKwlFcnJvck5vbWVtOiAgICAgICAgICAgICAgICAgICAgICAgICJObyBtZW1v cnkiLAo+ID4+PiArCUVycm9ySW52YWw6ICAgICAgICAgICAgICAgICAgICAgICAgIkludmFsaWQi LAo+ID4+PiArCUVycm9yQmFkZmFpbDogICAgICAgICAgICAgICAgICAgICAgIkJhZCBGYWlsIiwK PiA+Pj4gKwlFcnJvckd1ZXN0VGltZWRvdXQ6ICAgICAgICAgICAgICAgICJHdWVzdCB0aW1lZCBv dXQiLAo+ID4+PiArCUVycm9yVGltZWRvdXQ6ICAgICAgICAgICAgICAgICAgICAgIlRpbWVkIG91 dCIsCj4gPj4+ICsJRXJyb3JOb3BhcmF2aXJ0OiAgICAgICAgICAgICAgICAgICAiTm8gUGFyYXZp cnR1YWxpemF0aW9uIiwKPiA+Pj4gKwlFcnJvck5vdFJlYWR5OiAgICAgICAgICAgICAgICAgICAg ICJOb3QgcmVhZHkiLAo+ID4+PiArCUVycm9yT3NldmVudFJlZ0ZhaWw6ICAgICAgICAgICAgICAg Ik9TIGV2ZW50IGZhaWxlZCIsCj4gPj4+ICsJRXJyb3JCdWZmZXJmdWxsOiAgICAgICAgICAgICAg ICAgICAiQnVmZmVyIGZ1bGwiLAo+ID4+PiArCUVycm9yVW5rbm93bkNoaWxkOiAgICAgICAgICAg ICAgICAgIlVua25vd24gY2hpbGQiLAo+ID4+PiArCUVycm9yTG9ja0ZhaWw6ICAgICAgICAgICAg ICAgICAgICAgIkxvY2sgZmFpbGVkIiwKPiA+Pj4gKwlFcnJvckpzb25Db25maWdFbXB0eTogICAg ICAgICAgICAgICJKU09OIGNvbmZpZyBlbXB5dCIsCj4gPj4+ICsJRXJyb3JEZXZpY2VFeGlzdHM6 ICAgICAgICAgICAgICAgICAiRGV2aWNlIGV4aXN0cyIsCj4gPj4+ICsJRXJyb3JDaGVja3BvaW50 RGV2b3BzRG9lc05vdE1hdGNoOiAiQ2hlY2twb2ludCBkZXZvcHMgZG9lcwo+ID4+PiBub3QgbWF0 Y2giLAo+ID4+PiArCUVycm9yQ2hlY2twb2ludERldmljZU5vdFN1cHBvcnRlZDogIkNoZWNrcG9p bnQgZGV2aWNlIG5vdAo+ID4+PiBzdXBwb3J0ZWQiLAo+ID4+PiArCUVycm9yVm51bWFDb25maWdJ bnZhbGlkOiAgICAgICAgICAgIlZOVU1BIGNvbmZpZyBpbnZhbGlkIiwKPiA+Pj4gKwlFcnJvckRv bWFpbk5vdGZvdW5kOiAgICAgICAgICAgICAgICJEb21haW4gbm90IGZvdW5kIiwKPiA+Pj4gKwlF cnJvckFib3J0ZWQ6ICAgICAgICAgICAgICAgICAgICAgICJBYm9ydGVkIiwKPiA+Pj4gKwlFcnJv ck5vdGZvdW5kOiAgICAgICAgICAgICAgICAgICAgICJOb3QgZm91bmQiLAo+ID4+PiArCUVycm9y RG9tYWluRGVzdHJveWVkOiAgICAgICAgICAgICAgIkRvbWFpbiBkZXN0cm95ZWQiLAo+ID4+PiAr CUVycm9yRmVhdHVyZVJlbW92ZWQ6ICAgICAgICAgICAgICAgIkZlYXR1cmUgcmVtb3ZlZCIsCj4g Pj4+ICt9Cj4gPj4+ICsKPiA+Pj4gK2Z1bmMgKGUgRXJyb3J4bCkgRXJyb3IoKSBzdHJpbmcgewo+ ID4+PiArCWlmIDAgPD0gLWludChlKSAmJiAtaW50KGUpIDwgbGVuKGVycm9ycykgewo+ID4+PiAr CQlzIDo9IGVycm9yc1stZV0KPiA+Pj4gKwkJaWYgcyAhPSAiIiB7Cj4gPj4+ICsJCQlyZXR1cm4g cwo+ID4+PiArCQl9Cj4gPj4+ICsJfQo+ID4+PiArCXJldHVybiAiZXJyb3J4bCAiICsgc3RyY29u di5JdG9hKGludChlKSkKPiA+Pj4gK30KPiA+Pj4gKwo+ID4+PiArLyoKPiA+Pj4gICAqIFR5cGVz OiBCdWlsdGlucwo+ID4+PiAgICovCj4gPj4+ICB0eXBlIENvbnRleHQgc3RydWN0IHsKPiA+Pj4g QEAgLTU1LDggKzEyNiw3IEBAIGZ1bmMgKEN0eCAqQ29udGV4dCkgT3BlbigpIChlcnIgZXJyb3Ip IHsKPiA+Pj4gIAlyZXQgOj0gQy5saWJ4bF9jdHhfYWxsb2ModW5zYWZlLlBvaW50ZXIoJkN0eC5j dHgpLAo+ID4+PiBDLkxJQlhMX1ZFUlNJT04sIDAsIG5pbCkKPiA+Pj4gIAo+ID4+PiAgCWlmIHJl dCAhPSAwIHsKPiA+Pj4gLQkJLy9GSVhNRTogcHJvcGVyIGVycm9yCj4gPj4+IC0JCWVyciA9IGNy ZWF0ZUVycm9yKCJBbGxvY2F0aW5nIGxpYnhsIGNvbnRleHQ6ICIsIHJldCkKPiA+Pj4gKwkJZXJy ID0gRXJyb3J4bChyZXQpCj4gPj4+Cj4gPj4gSW4gZ2VuZXJhbCwgaXQncyBub3QgZ29vZCBwcmFj dGlzZSB0byBkbyBzb21ldGhpbmcgaW4gcGF0Y2ggbiwgYW5kIHRoZW4KPiA+PiB1bmRvL3JlZG8g aXQgaW4gcGF0Y2ggbisxIChvciBpbiBnZW5lcmFsIG4rbSksIHdpdGhpbiB0aGUgc2FtZSBzZXJp ZXMuCj4gPj4KPiA+PiBSZWFzb24gaXMsIGl0IG1ha2VzIHRoaW5ncyBoYXJkZXIgYW5kIGxvbmdl ciB0byByZXZpZXcgKHRoZSBzYW1lIGNvZGUKPiA+PiBuZWVkcyB0byBiZSBsb29rZWQgYXQsIHVu ZGVyc3Rvb2QgYW5kLCBwZXJoYXBzLCBjb21tZW50ZWQgdHdpY2UhKS4KPiA+Pgo+ID4+IFRoZXJl IGFyZSBzaXR1YXRpb25zIHdoZXJlIHRoYXQgY2FuJ3QgYmUgYXZvaWRlZC4uLiBidXQgaW4gdGhp cyBjYXNlLAo+ID4+IGl0IHNlZW1zIHRvIG1lIHRoYXQgdGhlIHNlcmllcyBjYW4gYmUgcmVvcmdh bml6ZWQgaW4gc3VjaCBhIHdheSB0aGF0Cj4gPj4gZXJyb3JzL3N5bWJvbHMgYXJlIGludHJvZHVj ZWQgYmVmb3JlIGJlaW5nIHVzZWQuCj4gPj4KPiA+PiBJZiB0aGF0J3Mgbm90IHRoZSBjYXNlLCBi ZWNhdXNlIG9mIEdvIHNwZWNpZmljIGNoYXJhY3RlcmlzdGljcyB0aGF0IEknbQo+ID4+IHVuYXdh cmUgb2YsIHRoZW4gc29ycnkgZm9yIHRoZSBub2lzZSAoYnV0IHRoZW4gSSdkIHNheSB0aGF0IHRo ZXNlCj4gPj4gc3BlY2lmaWMgY2hhcmFjdGVyaXN0aWNzIGNvdWxkIGJlIGF0IGxlYXN0IHF1aWNr bHkgZXhwbGFpbmVkIGluIGEKPiA+PiBjaGFuZ2Vsb2cgb3IgYSBjb3ZlciBsZXR0ZXIpLgo+ID4g Cj4gPiBJdCdzIHBvc3NpYmxlIHRvIGFkZCB0aGUgZXJyb3JzIGFzIHBhcnQgb2YgdGhlIGZpcnN0 IHBhdGNoIGFuZCB0aGVuCj4gPiBhZGQgdGhlIGNvbnRleHQgZnVuY3Rpb25zIGFzIHRoZSBzZWNv bmQgcGF0Y2ggYXMgR28gd2lsbCBhdCBsZWFzdCAKPiA+IGxldCB5b3UgY29tcGlsZSB0aGUgZXJy b3JzIG9uIGl0J3Mgb3duLiBJIGNhbiBzd2FwIHRoZSBvcmRlciBvZiB0aGUKPiA+IHBhdGNocyBp biB0aGUgbmV4dCByZXZpc2lvbi4KPiAKPiBXaGljaCBwb2ludHMgb3V0IHRoZSBwcm9ibGVtIHdp dGggRGFyaW8ncyBzdWdnZXN0aW9uLiA6LSkKPiAKPiBJdCBpcyBpbmRlZWQgbm9ybWFsIHRoYXQg eW91IGRvbid0IGZpeCB0aGluZ3MgZnJvbSBwcmV2aW91cyBwYXRjaGVzLgo+IEJ1dCB0aGUgImZp eCIgaGVyZSBpcyBmcm9tIHRoZSB2ZXJ5IGZpcnN0IHBhdGNoOiB5b3UgY2FuJ3QgaW50cm9kdWNl IHRoZQo+IGVycm9yIGNvZGUgYmVmb3JlIHlvdSBpbnRyb2R1Y2UgdGhlIGRpcmVjdG9yaWVzIGFu ZCB0aGUgbWFrZWZpbGUgdG8KPiBidWlsZCBpdC4gIFRoZSBvbmx5IHdheSB0byBhdm9pZCB0aGlz ICJmaXgiIHdvdWxkIGJlIHRvIG1lcmdlIHRoZSB0d28KPiBwYXRjaGVzIGludG8gb25lLgo+IAo+ IEJ1dCB0aGF0IG9mIGNvdXJzZSBtZWFucyB0aGF0IHlvdSdyZSBub3Qgc2VwYXJhdGluZyBvdXQg dGhlIGltcG9ydGFudAo+IHRoaW5ncyBmcm9tIHRoZSBmaXJzdCBwYXRjaCAodGhlIE1ha2VmaWxl IHNldHVwKSB3aXRoIHRoZSBpbXBvcnRhbnQKPiB0aGluZ3MgZnJvbSB0aGUgc2Vjb25kIHBhdGNo ICh0aGUgRXJyb3IgaGFuZGxpbmcgZGVzaWduKS4KPiAKPiBJJ2QgcHJlZmVyIGl0IGJlIGxlZnQg YXMgaXQgaXM7IGJ1dCBpdCdzIElhbiBhbmQgV2VpIHRoYXQgaGF2ZSB0aGUgZmluYWwKPiB3b3Jk IG9uIHRoYXQuCj4gCgpJJ20gZmluZSB3aXRoIGl0IGFzLWlzLiBJIHdvdWxkIHJhdGhlciBhdm9p ZCBmb2xkaW5nIHRoaXMgcGF0Y2ggaW50bwp0aGUgcHJldmlvdXMgb25lLgoKV2VpLgoKPiAgLUdl b3JnZQo+IAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18K WGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xp c3RzLnhlbi5vcmcveGVuLWRldmVsCg==