From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stefan Hajnoczi Subject: Re: [PATCH v2 2/6] qdict: Add convenience helpers for wrapped puts Date: Thu, 19 Jan 2017 17:36:11 +0000 Message-ID: <20170119173611.GE27032@stefanha-x1.localdomain> References: <20170118161653.19296-1-eblake@redhat.com> <20170118161653.19296-3-eblake@redhat.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0983998873428072360==" Return-path: In-Reply-To: <20170118161653.19296-3-eblake@redhat.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Eric Blake Cc: Jeff Cody , qemu-devel@nongnu.org, Michael Roth , Gerd Hoffmann , Stefano Stabellini , Alberto Garcia , "open list:Block layer core" , Alexander Graf , Anthony Perard , Fam Zheng , Chrysostomos Nanakos , Stefan Weil , Peter Lieven , "Dr. David Alan Gilbert" , "open list:X86" , Ronnie Sahlberg , Richard Henderson , Kevin Wolf , armbru@redhat.com, "Richard W.M. Jones" , Max Reitz , Paolo Bonzini List-Id: xen-devel@lists.xenproject.org --===============0983998873428072360== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="8vCeF2GUdMpe9ZbK" Content-Disposition: inline --8vCeF2GUdMpe9ZbK Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Jan 18, 2017 at 10:16:49AM -0600, Eric Blake wrote: > Quite a few users of qdict_put() were manually wrapping a > non-QObject. We can make such call-sites shorter, by providing > common macros to do the tedious work. Also shorten nearby > qdict_put_obj(,,QOBJECT()) sequences. >=20 > Signed-off-by: Eric Blake > Reviewed-by: Alberto Garcia >=20 > --- >=20 > v2: rebase to current master >=20 > I'm okay if you want me to break this patch into smaller pieces. > --- > include/qapi/qmp/qdict.h | 8 +++ > block.c | 59 +++++++--------- > block/archipelago.c | 4 +- > block/blkdebug.c | 6 +- > block/blkverify.c | 11 ++- > block/curl.c | 2 +- > block/file-posix.c | 8 +-- > block/file-win32.c | 4 +- > block/iscsi.c | 2 +- > block/nbd.c | 41 ++++++----- > block/nfs.c | 43 +++++------- > block/null.c | 2 +- > block/qcow2.c | 4 +- > block/quorum.c | 13 ++-- > block/ssh.c | 16 ++--- > block/vvfat.c | 10 +-- > blockdev.c | 28 ++++---- > hw/block/xen_disk.c | 2 +- > hw/usb/xen-usb.c | 12 ++-- > monitor.c | 18 ++--- > qapi/qmp-event.c | 2 +- > qemu-img.c | 6 +- > qemu-io.c | 2 +- > qemu-nbd.c | 2 +- > qobject/qdict.c | 2 +- > target/s390x/cpu_models.c | 4 +- > tests/check-qdict.c | 132 ++++++++++++++++++------------= ------ > tests/test-qmp-commands.c | 30 ++++---- > tests/test-qmp-event.c | 30 ++++---- > tests/test-qobject-output-visitor.c | 6 +- > util/qemu-option.c | 6 +- > 31 files changed, 245 insertions(+), 270 deletions(-) Reviewed-by: Stefan Hajnoczi --8vCeF2GUdMpe9ZbK Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEcBAEBAgAGBQJYgPkLAAoJEJykq7OBq3PIopUH/06JeNnJ+ZDPdbVfN2ZbnNXo jdLk78F0MDGKN9vTcw5ofH7kRc9OhRDsj9hwCQKQm5bE5T5EgTobnEYZ0Hsmi/1A moiA5gesHSNvTqAhPM9O93dT3UcHMh/ekxgJTcJX4Z4/GOr3UkRUzvythmNJRJ+e dNH5FuHGX8nrXcCPzmNkq8wxiobu+SpXdz5OpEJW978ppPMxtIZqD9wEvL5VPVvN /CmcLTEy2Hx7nXHwPCipGyd/0Q02CzRNT8wKfGoQGHh6BYQ+YitWulPDdwAbiVRu ZtbPeiL0ndLGTzWX4gTpi0URGGtUte1AXhELJ7PjG3sXoTfUSAnzH11/9dTK2yk= =eHgc -----END PGP SIGNATURE----- --8vCeF2GUdMpe9ZbK-- --===============0983998873428072360== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVs IG1haWxpbmcgbGlzdApYZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCg== --===============0983998873428072360==--