From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Cc: jgross@suse.com, xen-devel@lists.xenproject.org,
Pooya.Keshavarzi@de.bosch.com,
Stefano Stabellini <sstabellini@kernel.org>
Subject: Re: [PATCH] swiotlb-xen: update dev_addr after swapping pages
Date: Thu, 19 Jan 2017 19:27:02 -0500 [thread overview]
Message-ID: <20170120002702.GF22617@char.us.oracle.com> (raw)
In-Reply-To: <11259b25-15ae-332c-9cdf-1ca16a29a13a@oracle.com>
On Thu, Jan 19, 2017 at 06:58:46PM -0500, Boris Ostrovsky wrote:
> On 01/19/2017 01:39 PM, Stefano Stabellini wrote:
> > In xen_swiotlb_map_page and xen_swiotlb_map_sg_attrs, if the original
> > page is not suitable, we swap it for another page from the swiotlb
> > pool.
> >
> > In these cases, we don't update the previously calculated dma address
> > for the page before calling xen_dma_map_page. Thus, we end up calling
> > xen_dma_map_page passing the wrong dev_addr, resulting in
> > xen_dma_map_page mistakenly assuming that the page is foreign when it is
> > local.
> >
> > Fix the bug by updating dev_addr appropriately.
> >
> > This change has no effect on x86, because xen_dma_map_page is a stub
> > there.
> >
> > Signed-off-by: Stefano Stabellini <sstabellini@kernel.org>
> > Signed-off-by: Pooya Keshavarzi <Pooya.Keshavarzi@de.bosch.com>
> > Tested-by: Pooya Keshavarzi <Pooya.Keshavarzi@de.bosch.com>
>
> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
Acked-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
I can carry it via my swiotlb.git tree or if there are some extra
things on the Xen tree - it can go through that?
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2017-01-20 0:27 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-19 18:39 [PATCH] swiotlb-xen: update dev_addr after swapping pages Stefano Stabellini
2017-01-19 23:58 ` Boris Ostrovsky
2017-01-20 0:27 ` Konrad Rzeszutek Wilk [this message]
2017-01-20 0:29 ` Stefano Stabellini
2017-01-20 13:47 ` Konrad Rzeszutek Wilk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170120002702.GF22617@char.us.oracle.com \
--to=konrad.wilk@oracle.com \
--cc=Pooya.Keshavarzi@de.bosch.com \
--cc=boris.ostrovsky@oracle.com \
--cc=jgross@suse.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).